[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-12 Thread gerritbot 
gerritbot added a comment.
Change 347381 abandoned by Hashar:
(Do not submit) unregister qunit tests

Reason:
Got fixed :-}

https://gerrit.wikimedia.org/r/347381TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread gerritbot 
gerritbot added a comment.
Change 347354 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix broken QUnit tests.

https://gerrit.wikimedia.org/r/347354TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread hashar 
hashar added a comment.
Looks like a test did $.ajax = function () {}.  I hate scoping issue, congratulations on figuring out that one! -;-)

The CI change is deployed so the QUnit job should trigger from now on.TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, hasharCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread gerritbot 
gerritbot added a comment.
Change 347596 merged by jenkins-bot:
[integration/config@master] Enable QUnit tests for WikibaseLexeme

https://gerrit.wikimedia.org/r/347596TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread Jakob_WMDE 
Jakob_WMDE added a comment.
They were failing due to some silly test overriding jQuery.ajax. Should be working now. Thanks for looking into it, @hashar!TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDECc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread gerritbot 
gerritbot added a comment.
Change 347596 had a related patch set uploaded (by Jakob):
[integration/config@master] Enable QUnit tests for WikibaseLexeme

https://gerrit.wikimedia.org/r/347596TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-11 Thread gerritbot 
gerritbot added a comment.
Change 347354 had a related patch set uploaded (by Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Fix broken QUnit tests.

https://gerrit.wikimedia.org/r/347354TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-10 Thread hashar 
hashar added a comment.
What is puzzling is Jonas told me that they pass fine locally.  Maybe that is a bad interaction with one of the other extension.  I will try tomorrow by cloning all of them and see and what happens. The list being:

mediawiki/extensions/WikibaseLexeme 
mediawiki/extensions/BetaFeatures 
mediawiki/extensions/Capiunto 
mediawiki/extensions/CirrusSearch 
mediawiki/extensions/Cite 
mediawiki/extensions/Echo 
mediawiki/extensions/Elastica 
mediawiki/extensions/GeoData 
mediawiki/extensions/MwEmbedSupport 
mediawiki/extensions/PdfHandler 
mediawiki/extensions/Scribunto 
mediawiki/extensions/SiteMatrix 
mediawiki/extensions/TimedMediaHandler 
mediawiki/extensions/VisualEditor 
mediawiki/extensions/Wikibase 
mediawiki/extensions/cldrTASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-10 Thread hashar 
hashar added a comment.
https://gerrit.wikimedia.org/r/#/c/347381/1 is a dummy change for WikibaseLexeme that unregister all qunit tests for that extension.  The Qunit job passes.

https://gerrit.wikimedia.org/r/#/c/347381/2 I removed the scripts but kept the dependencies (who knows). And it passes.TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: gerritbot, hashar, Jonas, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Salgo60, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-10 Thread gerritbot 
gerritbot added a comment.
Change 347381 had a related patch set uploaded (by Hashar):
[mediawiki/extensions/WikibaseLexeme@master] (Do not submit) unregister qunit tests

https://gerrit.wikimedia.org/r/347381TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hashar, Jonas, Aklapper, QZanden, Salgo60, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T161287: Run QUnit tests in CI

2017-04-10 Thread hashar 
hashar added a comment.
On both builds there is a time out being reached and the build abort after 60 seconds:

build 5910
00:06:45.981 Chrome 57.0.2987 (Linux 0.0.0): Executed 705 of 1441 (6 FAILED) (0 secs / 1 min 6.224 secs)
00:07:46.005 24 03 2017 07:17:49.848:WARN [Chrome 57.0.2987 (Linux 0.0.0)]: Disconnected (1 times), because no message in 6 ms.

build 6336

00:03:49.340   mediawiki (mw.loader)
00:03:49.340 ✖ Basic
00:03:49.341 ✖ Object method as module name
00:03:49.342 ✖ .using( .. ) Promise

00:03:49.493 ✔ Broken indirect dependency
00:03:49.494 ✔ Out-of-order implementation
00:03:49.496 ✔ Missing dependency
00:04:49.506 10 04 2017 12:00:05.216:WARN [Chrome 57.0.2987 (Linux 0.0.0)]: Disconnected (1 times), because no message in 6 ms.

The second build benefit from a change we made to Karma so it reports a human readable report.

There is some wrong in the MediaWiki core test for the mw.loader.  The next test should be Dependency handling so maybe it fails/times out in that test.  It is defined in tests/qunit/suites/resources/mediawiki/mediawiki.loader.test.js

The other three tests are failing though they are rather dummy one. I have no idea why they would fail though and since the build is aborted the actual errors is not emitted :(TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: hashar, Jonas, Aklapper, QZanden, Salgo60, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs