[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
schoenbaechler added a comment. Moving this back to the “Needs Design/Design doing“ column since there will be modifications to the flow/screens based on feedback from usability testing.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, schoenbaechlerCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cooltey added a comment. Thanks, @cmadeoTASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: coolteyCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. @cooltey I think that this is okay to keep as is, thanks for checkingTASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, cmadeoCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
gerritbot added a comment. Change 478375 merged by jenkins-bot: [apps/android/wikipedia@master] Add "adding title descriptions feed" https://gerrit.wikimedia.org/r/478375TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, gerritbotCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cooltey added a comment. Hi @cmadeo and cc @schoenbaechler Do we have to set a different "default image background color"? The "default image background color" is base30 #72777d for all the four themes, which you can see on the following screenshots. F27613682: Screenshot_1545067039.png Light theme F27614025: Screenshot_1545068457.png Sepia theme F27613694: Screenshot_1545067062.png Dark theme F27613699: Screenshot_1545067076.png Black themeTASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: coolteyCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. @cooltey thanks for jumping on a call to help me understand this better! Yes, let's keep the card style as it is currently implemented and include the overflow only if it doesn't cause too much trouble during implementation. Thank you!TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, cmadeoCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. @cooltey if it's okay I'd prefer if the card wasn't clickable in the preview and to also not include the overflow menu. Being able to click on the card in the editing mode is helpful for additional context, but it could potentially be a bit confusing in the preview as their wikidata description would not show in the preview.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, cmadeoCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cooltey added a comment. Thanks for the update, @cmadeo Have a question about the Article preview screen. Since the card view in Adding title descriptions feed is clickable and able to read the article, should I keep the card view clickable? And in our current bottom sheet dialog, we have the overflow menu with the options shows below, should we also need the same options to be implemented into the Article preview screen's overflow menu? F27560752: Screenshot_1544823545.pngTASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: coolteyCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
RHo added a comment. In T164606#4817354, @cmadeo wrote: Thanks for bringing this up @cooltey. I'm actually a bit stuck about what the answer should be and would love input from @schoenbaechler and @Charlotte. On one end, it seems like it would be a good idea to reduce the number of interfaces to maintain, but on the other the user has more context when they are editing from the article (therefore the UI could be a little more paired down). I can definitely see some benefits to including more context (eg. the new design) in the normal description editing though, so my vote would be to update both editors to be the same (the new version). I am not sure that we really need to review in the article view though as the user will see the article immediately after submitting and can take action to change it if they made a mistake. FWIW, I agree about not needing the review screen for the title description when the user has entered the edit title description screen from the context of reading an article. The reason for the extra detail and review step is that users entering from the Edit action queue have no context of what the article is and move to the next title description after completing this action.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, RHoCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. Thanks for bringing this up @cooltey. I'm actually a bit stuck about what the answer should be and would love input from @schoenbaechler and @Charlotte. On one end, it seems like it would be a good idea to reduce the number of interfaces to maintain, but on the other the user has more context when they are editing from the article (therefore the UI could be a little more paired down). I can definitely see some benefits to including more context (eg. the new design) in the normal description editing though, so my vote would be to update both editors to be the same (the new version). I am not sure that we really need to review in the article view though as the user will see the article immediately after submitting and can take action to change it if they made a mistake.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, cmadeoCc: schoenbaechler, gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Sharvaniharan, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
gerritbot added a comment. Change 478375 had a related patch set uploaded (by Cooltey; owner: Cooltey): [apps/android/wikipedia@master] [WIP] Add "adding title descriptions feed" https://gerrit.wikimedia.org/r/478375TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cooltey, gerritbotCc: gerritbot, Charlotte, cmadeo, RHo, Tbayer, Aklapper, Nandana, Lahi, Gq86, Sharvaniharan, schoenbaechler, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
Charlotte added a comment. @cmadeo - Sure, though remember that because Android has hardware (or in some cases software) back buttons, this is not as much of a concern as it would be on iOS for example.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CharlotteCc: Charlotte, cmadeo, RHo, Tbayer, Aklapper, Nandana, Lahi, Gq86, Sharvaniharan, schoenbaechler, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. @Charlotte would it be possible to do usability testing with the action button as a checkmark in the upper right? I'm a little concerned about having the back navigation elements (back and next) on different areas of the UI.TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cmadeoCc: Charlotte, cmadeo, RHo, Tbayer, Aklapper, Nandana, Lahi, Gq86, Sharvaniharan, schoenbaechler, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
Charlotte added a comment. In T164606#4736578, @cmadeo wrote: In T164606#4725601, @Charlotte wrote: On the "Review" screen can we have a save mechanism that's a little weightier? People are not going to find the small checkmark I think. @Charlotte do you think we could change the title of the screen to 'Review' and then have the save mechanism be either 'Publish' or 'Save'? I'm not sure of how many characters are usually included in these buttons (my apologies) There is almost certainly not going to be enough room in the bar to do this in all languages - the German "Speichern", for example, is unlikely to fit. Why not have a button like is shown on the feed? Because the terms of use the user is agreeing to are at the bottom of the screen, would it perhaps make a bit more sense to have the action of agreeing a little closer to the thing they're agreeing to?TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CharlotteCc: Charlotte, cmadeo, RHo, Tbayer, Aklapper, Nandana, Lahi, Gq86, Sharvaniharan, schoenbaechler, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to
cmadeo added a comment. In T164606#4725601, @Charlotte wrote: Where does the "learn more" link in the onboarding take you to? Tapping on 'Learn more' should open the same 'Title description help' screen that is linked too from the title description editing screen. Please remove the image from the dialog so we don't have make a custom one I mentioned this on a comment in T207333, do you think it'd be possible to build out this custom dialog? Can you confirm that the language wiki dropdown menu will only contain languages the user has set, and that we will not show the dropdown if they only have one set? Confirmed, the drop down should only show on the translate title description task and only contain languages that the user has set. On the "Review" screen can we have a save mechanism that's a little weightier? People are not going to find the small checkmark I think. @Charlotte do you think we could change the title of the screen to 'Review' and then have the save mechanism be either 'Publish' or 'Save'? I'm not sure of how many characters are usually included in these buttons (my apologies)TASK DETAILhttps://phabricator.wikimedia.org/T164606EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cmadeoCc: Charlotte, cmadeo, RHo, Tbayer, Aklapper, Nandana, Lahi, Gq86, Sharvaniharan, schoenbaechler, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Dbrant, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
