[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
gerritbot added a comment. Change 353017 abandoned by Lucas Werkmeister (WMDE): Add margin to popup close button Reason: Superseded by I08e1fe23473d5a0966f542031664dd7424f9bb1c. https://gerrit.wikimedia.org/r/353017TASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, dachary, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
gerritbot added a comment. Change 352857 abandoned by Lucas Werkmeister (WMDE): Remove padding and margin from top of heading Reason: Superseded by I08e1fe23473d5a0966f542031664dd7424f9bb1c. https://gerrit.wikimedia.org/r/352857TASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, dachary, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
Lucas_Werkmeister_WMDE added a comment. Screenshot with change 353017: F8012738: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, dachary, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
gerritbot added a comment. Change 353017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Add margin to popup close button https://gerrit.wikimedia.org/r/353017TASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, dachary, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
gerritbot added a comment. Change 352857 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Remove padding and margin from top of heading https://gerrit.wikimedia.org/r/352857TASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, QZanden, dachary, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164829: Fix alignment constraint check notification headline and close button
Lucas_Werkmeister_WMDE added a comment. I’m not sure exactly what you mean. I can remove the padding-top and margin-top from the “Potential issues” headline (but not the “single value” headline, right?), but what’s wrong with the close button?TASK DETAILhttps://phabricator.wikimedia.org/T164829EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LucasWerkmeister, Lucas_Werkmeister_WMDECc: Aklapper, Lucas_Werkmeister_WMDE, Charlie_WMDE, gerritbot, Jan_Dittrich, QZanden, dachary, Izno, Wikidata-bugs, aude, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs