subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T166470\: Include links in Wikidata HTTP responses to different entity representations as Link headers"

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2020-06-07 Thread abian

abian added a comment.


  I'm sorry I put this aside (my fault). I didn't include tests, but I feel I 
don't know the architecture well enough to write them; I sense that these will 
be complex or that I'll need to touch code elsewhere. I think it's better for 
me to officially give up on these tests so that a developer on the team (or 
other volunteer) can code them. I'll list a few checks I have in mind, but 
please don't consider this list essential or exhaustive:
  
  [ ] A request for a page that is not a Wikibase entity does not generate a 
response with links to alternative structured representations.
  [ ] A request for a Wikibase Item generates a response with links to 
alternative structured representations.
  [ ] A request for a Wikibase Property generates a response with links to 
alternative structured representations.
  [ ] The link headers are well formatted.
  [ ] All the alternative structured representations listed are available.
  [ ] All the alternative structured representations available are listed.
  [ ] All the alternative structured representations listed are about the 
requested Wikibase entity.

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: abian
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2020-06-06 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.


  

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2020-06-06 Thread Ladsgroup

Ladsgroup added a comment.


  In T166470#6199297 , 
@Lydia_Pintscher wrote:
  
  > What is this waiting for/stalled on?
  
  The patch needs to address some code review concerns :)

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2020-06-06 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.


  What is this waiting for/stalled on?

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-11-01 Thread gerritbot

gerritbot added a comment.


  Change 547739 had a related patch set uploaded (by Abián; owner: Abián):
  [mediawiki/extensions/Wikibase@master] Include Link headers in HTTP responses
  
  https://gerrit.wikimedia.org/r/547739

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Chicocvenancio, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-10-30 Thread Addshore

Addshore added a comment.


  ViewEntityAction has access to OutputPage via $this->getOutput() which has 
addLinkHeader which is what you need afaik.

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Chicocvenancio, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-10-30 Thread Ladsgroup

Ladsgroup added a comment.


  I would go with the place that we put `og:description` meta tags but I'm not 
sure if it's possible to add response headers there (It's in 
`ViewEntityAction.php`)

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Chicocvenancio, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, 
Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-09-27 Thread abian

abian added a comment.


  Okay! But I'd need some help to know what/where to touch. To set HTTP headers 
for the Special:EntityData pages I would probably change 
/repo/includes/LinkedData/EntityDataRequestHandler.php 
,
 but what should I touch if I want to set HTTP headers for the wiki pages (not 
necessarily loading them through Special:EntityData)?

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: abian
Cc: Lydia_Pintscher, Addshore, daniel, Aklapper, abian, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-09-27 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.


  Let's do it then :)
  @abian Do you want to propose a patch?

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Addshore, daniel, Aklapper, abian, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

2019-09-27 Thread Addshore

Addshore added a comment.


  I see no reason not to do this.

TASK DETAIL
  https://phabricator.wikimedia.org/T166470

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Addshore, daniel, Aklapper, abian, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Chicocvenancio, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

10 matches

Site Navigation

Mail list logo

Footer information