[Wikidata-bugs] [Maniphest] [Commented On] T168247: Translate hand made HTML templates into JS generated ones
Kiailandi added a comment. In T168247#3506332, @Aklapper wrote: @Kiailandi triaged this task as Unbreak Now! priority. @Kiailandi: This task has been open for nearly two months. If this task has suddenly become a super urgent crucial task that needs to be fixed immediately, setting anything else aside (see the definition of the "Unbreak now!" priority), please elaborate why. If not, please decrease the task priority. Thanks! My bad, fixed. It has always been one of the top priorities as a task, but I suppose the best priority is high. Will fix the other tasks in the same wayTASK DETAILhttps://phabricator.wikimedia.org/T168247EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168247: Translate hand made HTML templates into JS generated ones
Aklapper added a comment. @Kiailandi triaged this task as Unbreak Now! priority. @Kiailandi: This task has been open for nearly two months. If this task has suddenly become a super urgent crucial task that needs to be fixed immediately, setting anything else aside (see the definition of the "Unbreak now!" priority), please elaborate why. If not, please decrease the task priority. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T168247EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Kiailandi, AklapperCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168247: Translate hand made HTML templates into JS generated ones
Kiailandi added a comment. Another part in the UI is played by jQuery.wikibase, I still need to understand if and how this library is partially responsible for the templates generation or is just used to manipulate the dom objects at later stages. I'll try to add some more comments when I'll understand how to leverage both to obtain our final template.TASK DETAILhttps://phabricator.wikimedia.org/T168247EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168247: Translate hand made HTML templates into JS generated ones
Kiailandi added a comment. We can generate the template for our tool starting from the mw.wbTemplates.store.values _javascript_ object which contains the templates used to generate the wikidata pages. We will probably need to extend the available templates with the ones we need for the Primary Sources tool. A possible solution could be to add a mw.psTemplates object or even extending the wbTemplates object directly. Another possible path could be adding our templates to the templates.php file in wikibase-view which declares the same templates. I am still trying to understand which way is the best one as far as maintainability and best practices are concerned.TASK DETAILhttps://phabricator.wikimedia.org/T168247EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: TerraCodes, Jay8g, Liuxinyu970226, PokestarFan, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
