[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2018-10-02 Thread Smalyshev 
Smalyshev added a comment.
@Hrishikes this task is about search and it already has been fixed. Please submit the linking issue as a separate task.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Hrishikes, Addshore, greg, Sjoerddebruin, tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2018-10-02 Thread Hrishikes 
Hrishikes added a comment.
This problem is present in other Wikis too. I have noticed it in enWS and bnWS, whenever a link containing these characters (like য়) goes to a non-Wiki site, it does not work, but it works fine when the link goes to another Wiki.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HrishikesCc: Hrishikes, Addshore, greg, Sjoerddebruin, tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-17 Thread Mahir256 
Mahir256 added a comment.
@greg Okay, thank you for the clarification. I will close this task after Monday, then. (Probably should fix the URL I linked to, though.)TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mahir256Cc: Addshore, greg, Sjoerddebruin, tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-17 Thread Sjoerddebruin 
Sjoerddebruin added a comment.
Wikidata is still on MediaWiki 1.31.0-wmf.7, while the change is included in 1.31.0-wmf.8.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-17 Thread Smalyshev 
Smalyshev added a comment.
@Mahir256 Please note wmf.8 is still not deployed on www.wikidata.org - see https://phabricator.wikimedia.org/T178635.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-15 Thread Smalyshev 
Smalyshev added a comment.
Seems to be working ok on test.wikidata.org, so closing. If it fails on wikidata when the train moves on, please reopen.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-15 Thread Smalyshev 
Smalyshev added a comment.
@thiemowmde I think it should fix it but can't check since it's not deployed yet (not even on test). So I'd like to keep it open until we can verify the problem is indeed gone.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-11 Thread gerritbot 
gerritbot added a comment.
Change 387959 abandoned by Smalyshev:
Normalize search term before matching against result

Reason:
looks like better solution has been found

https://gerrit.wikimedia.org/r/387959TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-10 Thread gerritbot 
gerritbot added a comment.
Change 390365 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] To identify superseded requests, use the requested search term instead of the returned search term

https://gerrit.wikimedia.org/r/390365TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-09 Thread gerritbot 
gerritbot added a comment.
Change 390365 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/extensions/Wikibase@master] To identify superseded requests, use the requested search term instead of the returned search term

https://gerrit.wikimedia.org/r/390365TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-05 Thread hoo 
hoo added a comment.

In T170779#3734809, @Smalyshev wrote:
@Snaterlicious, @hoo, @thiemowmde Do you know why the check is there and what it meant to be doing? @tstarling raised the following concern:

The search term is normalized by the server using $wgContLang->normalize(), which potentially includes transformations beyond NFC, especially if the content language is Arabic or Malayalam. So even if you do client-side NFC using the same version of Unicode as the server, there is at least a hypothetical possibility of a hang.


Replied on gerrit.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: tstarling, Snaterlicious, gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-02 Thread TJones 
TJones added a comment.
@Smalyshev, thanks for tracking this one down! That was some weird behavior, but things getting normalized and not matching makes sense.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TJonesCc: gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, Lewizho99, Maathavan, Jdrewniak, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-01 Thread gerritbot 
gerritbot added a comment.
Change 387959 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[data-values/value-view@master] Normalize search term before matching against result

https://gerrit.wikimedia.org/r/387959TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hoo, Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-01 Thread Smalyshev 
Smalyshev added a comment.
In jquery.ui.suggester.js we've got this:

			if ( typeof requestTerm === 'string' && requestTerm !== self._term ) {
// Skip request since it does not correspond to the current search term.
return;
			}

So looks like the term we get from the result may not be the original one but normalized one, because this check fails for the search above, thus ensuring no results.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-11-01 Thread Smalyshev 
Smalyshev added a comment.
Looking at the network trace when searching for ଡ଼, the result is returned (Q31441900) but for some reason is not displayed. The warning is there, but does not prevent the display of the result. I suspect the frontend, but will dig deeper.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, debt, Liuxinyu970226, TJones, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-10-27 Thread TJones 
TJones added a comment.
Note that you don’t need to change your interface to Bengali to see these effects, and the fact that it is the Bengali keyword for “category” doesn’t seem to matter either. You can search for single characters and get the described behavior.

(Be sure to clear the search box between examples—otherwise you the old results, as @Mahir256 noted above.)

For Bengali and Devanagari characters, the precomposed versions hang, and the decomposed versions et suggestions:


Bengaliয়U+09DFprecomposedhangs
Bengaliয়U+09AF U+09BCdecomposedworks
Devanagariग़U+095Aprecomposedhangs
Devanagariग़U+0917 U+093Cdecomposedworks
Gurmukhiਗ਼U+0A5Aprecomposedhangs
Gurmukhiਗ਼U+0A17 U+0A3Cdecomposedworks



Oddly, the opposite behavior happens for Latin, Cyrillic, and Greek characters—the precomposed versions work and the decomposed versions hang:


LatinñU+00F1precomposedworks
LatinñU+006E U+303decomposedhangs
LatinéU+00E9precomposedworks
LatinéU+0065 U+0301decomposedhangs
LatinởU+1EDFprecomposedworks
LatinởU+01A1 U+0309decomposedhangs
CyrillicЃU+0403precomposedworks
CyrillicЃU+0413 U+0301decomposedhangs
CyrillicЀU+0400precomposedworks
CyrillicЀU+0415 U+0300decomposedhangs
CyrillicЍU+040Dprecomposedworks
CyrillicЍU+0418 U+0300decomposedhangs
GreekἆU+1F06precomposedworks
GreekἆU+1F00 U+0342decomposedhangs



However, when there is no precomposed alternative, the decomposed version works fine (depending on your fonts, the mixed script versions may or may not look right):


Latinq́U+0071 U+0301decomposedworks
Latinq̀U+0071 U+0300decomposedworks
Latinq̃U+0071 U+0303decomposedworks
Latinq̉U+0071 U+0309decomposedworks
Latinq͂U+0071 U+0342decomposedworks
Latin + Bengaliq়U+0071 U+09BCdecomposedworks
Latin + Devanagariq़U+0071 U+093Cdecomposedworks
Latin + Gurmukhiq਼U+0071 U+0A3Cdecomposedworks



So, I’m really not sure what’s going on here, but it looks like it is more than just Indic languages that have the problem, and there seems to be an “expected” form which works, and an “unexpected” form that doesn’t—and the (pre|de)composition difference can break in either direction for a given script.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TJonesCc: debt, Liuxinyu970226, TJones, PokestarFan, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T170779: Wikidata search suggestions do not display on screen if character whose decomposition contains nukta is present in search query

2017-10-26 Thread Mahir256 
Mahir256 added a comment.
@debt No, the results are simply not appearing. The JSON response is still normal, but the results do not render on screen. The symptoms as listed in the task description still persist.TASK DETAILhttps://phabricator.wikimedia.org/T170779EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mahir256Cc: debt, Liuxinyu970226, TJones, PokestarFan, daniel, thiemowmde, Aftabuzzaman, Mahir256, Aklapper, Lahi, GoranSMilovanovic, QZanden, EBjune, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs