[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-08-12 Thread eranroz 
eranroz added a comment.
If I'm not missing something this is pretty easy to be done by generalizing the claims trick for labels/sitelinks/descriptions.

see patch: https://gerrit.wikimedia.org/r/#/c/371651TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Danmichaelo, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-08-13 Thread gerritbot 
gerritbot added a comment.
Change 371651 had a related patch set uploaded (by Legoktm; owner: Eranroz):
[mediawiki/extensions/Wikibase@master] xkill - lazy track labels/sitelinks/claims

https://gerrit.wikimedia.org/r/371651TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Danmichaelo, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, GoranSMilovanovic, QZanden, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-09-20 Thread Bawolff 
Bawolff added a comment.
As an aside, in the case of commons, it might make sense to always record label usage as being for all languages, instead of which specific language, since commons uses weird {{int:...}} hacks for multilingualness, which won't record all the usages for non-canonical language parses (OTOH, that's an issue commons has had with recording link usages for a very long time, so its not like non-canonical parse link tracking issues is anything new to commons)TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, BawolffCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread daniel 
daniel added a comment.
What's the status of this? With usage tracking balooning on several sites, this seems rather urgent!TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, danielCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread eranroz 
eranroz added a comment.
@daniel , I'll update the code soon per the code review comments. 
AFAIK it is currently blocked for deployment by T151717#3675687.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread daniel 
daniel added a comment.
@eranroz I see no blocker, T151717#3675687 is only relevant for enabling per-property statement usage tracking, which has a separate feature switch. Avoiding X tracking when no statements are used, but only labels and/or sitelinks, would still be very helpful. There is potential for increasing the usage tracking table (because we may track L.de and L.en instead of just X), but I don't expect that increase to be explosive - and it should be offset by a dramatic reduction of inserts into recentchanges. We should have an eye on it, though.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, danielCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread hoo 
hoo added a comment.
Please implement as I documented on gerrit: Have a feature flag which switches between X+C usages and no X usage, but dynamic tracking. That way we can enable this wiki per wiki.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, hooCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread daniel 
daniel added a comment.
Looking at things like https://commons.wikimedia.org/w/index.php?title=File:Vincent_Willem_van_Gogh_110.jpg&action=""> it seems like we really should get this done ASAP.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, danielCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-12 Thread eranroz 
eranroz added a comment.

In T172914#3679739, @daniel wrote:
Looking at things like https://commons.wikimedia.org/w/index.php?title=File:Vincent_Willem_van_Gogh_110.jpg&action=""> it seems like we really should get this done ASAP.


Nice example,I get your point  :)
Please go over the last patch (adds descriptions + feature flag and its documentation).  Also note that once deployed it should disabled in wmf-config and enabled per wiki as it may increase the wbc_entity_usage row number.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 386408 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Make disabled usage aspect use the new config

https://gerrit.wikimedia.org/r/386408TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 386408 merged by jenkins-bot:
[operations/mediawiki-config@master] Make disabled usage aspect use the new config

https://gerrit.wikimedia.org/r/386408TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-10-25T18:36:30Z]  Synchronized wmf-config/InitialiseSettings.php: Make disabled usage aspect use the new config T172914 (duration: 00m 50s)TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, StashbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 386421 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable fine grained usage tracking on statement usage wikis

https://gerrit.wikimedia.org/r/386421TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-10-25T18:45:44Z]  Synchronized wmf-config/InitialiseSettings.php: Enable fine grained usage tracking on statement usage wikis T172914 (duration: 00m 50s)TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, StashbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 386466 had a related patch set uploaded (by Hoo man; owner: Eranroz):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.5] xkill - lazy track labels/sitelinks/claims

https://gerrit.wikimedia.org/r/386466TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 371651 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] xkill - lazy track labels/sitelinks/claims

https://gerrit.wikimedia.org/r/371651TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread hoo 
hoo added a comment.
It slipped my mind that deploying this now would mean we sometimes track C or D usages alone, which we don't yet support.

Added the remaining steps to the road map. I guess this will be blocked for a while… :(

I reverted the already merged change, feel free to upload a "revert revert" for later.TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, hooCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T172914: mw.wikibase.entity: Use __index to lazy register entity usages

2017-10-25 Thread gerritbot 
gerritbot added a comment.
Change 386466 abandoned by Hoo man:
xkill - lazy track labels/sitelinks/claims

https://gerrit.wikimedia.org/r/386466TASK DETAILhttps://phabricator.wikimedia.org/T172914EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranroz, gerritbotCc: Stashbot, Bawolff, thiemowmde, gerritbot, Halfak, Aklapper, daniel, Lydia_Pintscher, aude, Liuxinyu970226, CennoxX, Scott_WUaS, Ltrlg, Oliv0, Izno, eranroz, PokestarFan, Doc_James, hoo, Lahi, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs