[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread gerritbot 
gerritbot added a comment.
Change 380754 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update hash when initializing snakview

https://gerrit.wikimedia.org/r/380754TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread gerritbot 
gerritbot added a comment.
Change 380753 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix statementview change propagation

https://gerrit.wikimedia.org/r/380753TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread gerritbot 
gerritbot added a comment.
Change 380753 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix statementview change propagation

https://gerrit.wikimedia.org/r/380753TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread gerritbot 
gerritbot added a comment.
Change 380754 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update hash when initializing snakview

https://gerrit.wikimedia.org/r/380754TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Ah, that bit in statementview is my own hacked-together code, so it’s pretty likely wrong :) no need to assume that the author knew what they were doing in that case.TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T176604: Snak hashes for qualifiers and references missing in entity HTML after statement save

2017-09-26 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
I think there might be some type confusion. When updating the value, statementview propagates the claim’s qualifiers to the qualifier listview:

this._qualifiers.option( key, value.getClaim().getQualifiers() );

value.getClaim().getQualifiers() is a wikibase.datamodel.SnakList, which has a length and an array of _items, but is not itself an array. But listview seems to expect an array directly, or at least something subscriptable:

for ( var i = 0; i < value.length; i++ ) {
this._addLiValue( value[ i ] );
}

With the SnakList in value, value[ i ] is undefined.TASK DETAILhttps://phabricator.wikimedia.org/T176604EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs