[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-29 Thread gerritbot 
gerritbot added a comment.
Change 394779 merged by jenkins-bot:
[mediawiki/core@master] Try to opportunistically flush statsd data in maintenance scripts

https://gerrit.wikimedia.org/r/394779TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, gerritbotCc: aaron, Smalyshev, Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-12-04T18:46:40Z]  Started dumpwikidatajson.sh on snapshot1007 (T181385)TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, StashbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-12-04T18:40:40Z]  Ran scap pull on snapshot1001 (T181385)TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, StashbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-12-04T18:35:16Z]  Synchronized php-1.31.0-wmf.10/includes/objectcache/ObjectCache.php: Only send statsd data for WAN cache in non-CLI mode (T181385) (duration: 00m 44s)TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, StashbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread gerritbot 
gerritbot added a comment.
Change 395055 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.10] Only send statsd data for WAN cache in non-CLI mode

https://gerrit.wikimedia.org/r/395055TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread gerritbot 
gerritbot added a comment.
Change 395055 had a related patch set uploaded (by Hoo man; owner: Aaron Schulz):
[mediawiki/core@wmf/1.31.0-wmf.10] Only send statsd data for WAN cache in non-CLI mode

https://gerrit.wikimedia.org/r/395055TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread hoo 
hoo added a comment.
So I merged the patch that makes sure we only actually collect this data if not in CLI mode.

I also tried putting MediaWikiServices::getInstance()->getStatsdDataFactory()->setEnabled( false ); in DumpScript::__construct, but this only had limited effect. For that to properly work, BufferingStatsdDataFactory::produceStatsdData needs to normalize and set the entity's key before aborting. Any idea why that is @aaron?TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, hooCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-04 Thread gerritbot 
gerritbot added a comment.
Change 394772 merged by jenkins-bot:
[mediawiki/core@master] Only send statsd data for WAN cache in non-CLI mode

https://gerrit.wikimedia.org/r/394772TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: Envlh, gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread hoo 
hoo added a comment.

In T181385#3806047, @aaron wrote:
How long do these run? The sample rate in config is set to be extremely low. So perhaps:


The buffering class buffers things that won't even be saved



That's definitely the case here, given that the sample rate is only applied later on.TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, hooCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread aaron 
aaron added a comment.

In T181385#3806113, @gerritbot wrote:
Change 394779 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
 [mediawiki/core@master] Try to opportunistically flush statsd data in maintenance scripts

https://gerrit.wikimedia.org/r/394779


This seems more general and preferable than the other patch, but leaving both here to look at.TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaronCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread gerritbot 
gerritbot added a comment.
Change 394779 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Try to opportunistically flush statsd data in maintenance scripts

https://gerrit.wikimedia.org/r/394779TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread gerritbot 
gerritbot added a comment.
Change 394772 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Only send statsd data for WAN cache in non-CLI mode

https://gerrit.wikimedia.org/r/394772TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread aaron 
aaron added a comment.
How long do these run? The sample rate in config is set to be extremely low. So perhaps:


The buffering class buffers things that won't even be saved
The buffering could be disable in CLI mode
TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaronCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread gerritbot 
gerritbot added a comment.
Change 394758 merged by ArielGlenn:
[operations/puppet@production] Wikidata weekly json and rdf dumps disabled temporarily

https://gerrit.wikimedia.org/r/394758TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Lewizho99, Maathavan, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-02 Thread gerritbot 
gerritbot added a comment.
Change 394758 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[operations/puppet@production] Wikidata weekly json and rdf dumps disabled temporarily

https://gerrit.wikimedia.org/r/394758TASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, gerritbotCc: gerritbot, Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Imarlier, Lahi, Gq86, GoranSMilovanovic, QZanden, Vali.matei, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T181385: Wikidata entity dumpers stuck with 100% CPU on snapshot1007

2017-12-01 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2017-12-02T03:51:21Z]  Ran "scap pull" on snapshot1001, after final T181385 testsTASK DETAILhttps://phabricator.wikimedia.org/T181385EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, StashbotCc: Legoktm, Addshore, Krinkle, demon, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, Aklapper, daniel, Lydia_Pintscher, ArielGlenn, aude, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, Wikidata-bugs, Svick, Mbch331, jeremyb___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs