[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Anomie added a comment. FYI: I ran it on a bunch more wiktionaries and all worked. I also tried running it on incubatorwiki and sourceswiki, but both failed (I inserted the necessary row manually on those two).TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: hashar, Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Fjalapeno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Ladsgroup added a comment. It might cause fatals here and there. Proceed with caution. One reason is that compact language links is the default in most wikis so it never reaches InterwikiSortOrder.phpTASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: hashar, Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Fjalapeno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Anomie added a comment. I just ran it on several wiktionaries and it seemed to work?TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: hashar, Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Fjalapeno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Anomie added a comment. It looks like it's just that the need to run populateSitesTable.php when enabling Wikibase on wikis never made it into the right documentation.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: hashar, Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Fjalapeno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T19:43:03Z] ladsgroup@terbium:~$ foreachwikiindblist wikidataclient extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https (T183019)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T19:35:32Z] ladsgroup@terbium:~$ mwscript extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https on fawiki and hewiki (T183019)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T19:18:26Z] ladsgroup@terbium:~$ mwscript extensions/Wikibase/lib/maintenance/populateSitesTable.php --wiki=mediawikiwiki --force-protocol https (T183019)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T14:37:35Z] Synchronized php-1.31.0-wmf.23/extensions/Wikibase/lib/tests/phpunit/Sites/SiteMatrixParserTest.php: [[gerrit:416745|Add code of special wikis as interwiki when populating sites table, part II (T183019)]] (duration: 01m 16s)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T14:35:47Z] Synchronized php-1.31.0-wmf.23/extensions/Wikibase/lib/includes/Sites/SiteMatrixParser.php: [[gerrit:416745|Add code of special wikis as interwiki when populating sites table (T183019)]] (duration: 01m 16s)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T14:31:01Z] Synchronized php-1.31.0-wmf.24/extensions/Wikibase/lib/tests/phpunit/Sites/SiteMatrixParserTest.php: [[gerrit:416744|Add code of special wikis as interwiki when populating sites table, part II (T183019)]] (duration: 01m 15s)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416745 merged by Ladsgroup: [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416745TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-03-07T14:27:19Z] Synchronized php-1.31.0-wmf.24/extensions/Wikibase/lib/includes/Sites/SiteMatrixParser.php: [[gerrit:416744|Add code of special wikis as interwiki when populating sites table (T183019)]] (duration: 01m 16s)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416744 merged by Ladsgroup: [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.24] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416744TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416744 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.24] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416744TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416745 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.23] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416745TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416705 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416705TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Ladsgroup added a comment. ^ If this gets merged and backported, what needs to happen is to run it on all clients (see https://wikitech.wikimedia.org/wiki/Add_a_wiki#Wikidata) and we are all good until the overhaul happens.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 416705 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Add code of special wikis as interwiki when populating sites table https://gerrit.wikimedia.org/r/416705TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Ladsgroup added a comment. Yeah, yeah. Of course. I'm working on mid-term (fixing populateSites.php maintenance script) and long-term solutions (rewriting SiteLookup) too. This is just to be sure that fixes the problem.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Anomie added a comment. In T183019#4005758, @Stashbot wrote: Mentioned in SAL (#wikimedia-operations) [2018-02-27T13:00:36Z] inserting wikidata-related interwikis to site_identifiers table using eval.php in enwiki (T183019) I was considering doing the same thing to resolve the immediate problem here. But we'll need to do that for every other wiki too, they're all missing it.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AnomieCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-02-27T13:00:36Z] inserting wikidata-related interwikis to site_identifiers table using eval.php in enwiki (T183019)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Ladsgroup added a comment. of course, populateSitesTable doesn't update site_identifiers table.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Ladsgroup added a comment. With the rebuilding of these tables, it's still can't find it. Problem lies somewhere else it seemsTASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-02-23T18:28:32Z] mwscript extensions/Wikibase/lib/maintenance/populateSitesTable.php --wiki=enwiki --force-protocol https (T183019)TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, StashbotCc: Stashbot, gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
daniel added a comment. *sigh* I started to rewrite SiteLookup stuff twice, and failed to finish it both times... This is so annoying.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5)
gerritbot added a comment. Change 405881 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use external username when building RecentChange entry https://gerrit.wikimedia.org/r/405881TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 2)
gerritbot added a comment. Change 405881 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Use external username when building RecentChange entry https://gerrit.wikimedia.org/r/405881TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users
gerritbot added a comment. Change 403629 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/core@master] Move methods for handling external usernames to a dedicated class https://gerrit.wikimedia.org/r/403629TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users
thiemowmde added a comment. I just talked to @Lydia_Pintscher about the 3 options. I believe #3 would be bad. What would happen? Let's say I make an edit on Wikidata, and this edit spreads to 100 client wikis. My user account is automatically created on all these wikis the same time. On half of the wikis a bot comes and adds a welcome message to the local talk page. I get notifications for all of these. This is bad for multiple reasons: The obvious issue is the Echo spam, and also that I now have multiple dozen talk pages I never wanted. #2 does have an important benefit: for all edits that are done from a client (currently only for sitelinks, but we want to have much more client editing), the local recent changes entries for this edit will point to the local user. This is exactly what I would expect as a user doing this edit. I never visited Wikidata. I don't want recent changes entries point to a user page on Wikidata I do not use. The problem with #2 is that for all other wikis that are not my home wiki, the recent changes entires will also point to local user pages I do not use, and do not want to maintain. #1 is the most consistent solution. Always point to Wikidata. After all, the edit was actually done on Wikidata. With solution #1, the user doing edits from a client wiki will wonder why recent changes entires do not point to his own local user page, but to Wikidata. The good thing about this issue is that it is always very easy to solve: this is only 1 user page the user needs to maintain, not hundreds.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, hoo, Lydia_Pintscher, daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users
daniel added a comment. Ok, so this boils down to: in core, find a good place for helper functions for constructing and parsing interwiki user names. As per https://gerrit.wikimedia.org/r/#/c/386625/10, that code is currently in WikiImporter and Linker. determine the interwiki prefix for the repo (via SiteLookup, probably) and make it known to RecentChangeFactory in RecentChangeFactory::prepareChangesAttributes, set $userText to an interwiki name (using the new helper function) if $clientUserId is 0. TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users
Anomie added a comment. In T183019#3890155, @daniel wrote: @Anomie We already do the SUL lookup and use the local user ID if it exists. The relevant code is in RecentChangeFactory::getClientUserId. So, if I understand correctly, all we would have to do now is to add a prefix to $userText if $clientUserId is 0 in prepareChangesAttributes. That sounds correct. Is there a helper methods for safely constructing such an interwiki user name? There isn't. If you want to add one, I'll review the patch. Also, should we be creating an actor entry directly, or is it OK to continue to use rc_user and rc_user_text when constructing a RecentChange object? It's ok to continue to use rc_user and rc_user_text, this code takes care of it.TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AnomieCc: daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183019: Wikibase must not insert local recentchanges entries for nonexistent local users
daniel added a comment. @Anomie We already do the SUL lookup and use the local user ID if it exists. The relevant code is in RecentChangeFactory::getClientUserId. So, if I understand correctly, all we would have to do now is to add a prefix to $userText if $clientUserId is 0 in prepareChangesAttributes. Is there a helper methods for safely constructing such an interwiki user name? Also, should we be creating an actor entry directly, or is it OK to continue to use rc_user and rc_user_text when constructing a RecentChange object?TASK DETAILhttps://phabricator.wikimedia.org/T183019EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Ladsgroup, aude, thiemowmde, Anomie, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
