[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-02-27 Thread gerritbot
gerritbot added a comment.
Change 406612 abandoned by WMDE-leszek:
[DNM] Add EntityPresenter interface and simple implementation

https://gerrit.wikimedia.org/r/406612TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: He7d3r, thiemowmde, gerritbot, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-02-20 Thread gerritbot
gerritbot added a comment.
Change 406608 abandoned by WMDE-leszek:
[DNM] Move the lexeme "displaying" logic to the LexemePresenter

https://gerrit.wikimedia.org/r/406608TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: He7d3r, thiemowmde, gerritbot, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-02-20 Thread gerritbot
gerritbot added a comment.
Change 406306 abandoned by WMDE-leszek:
[DNM] Display lexemes in statements

https://gerrit.wikimedia.org/r/406306TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: He7d3r, thiemowmde, gerritbot, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)

2018-02-02 Thread WMDE-leszek
WMDE-leszek added a comment.
What the patches don't cover (possibly because of this tasks wording) are:


How to put derived Lexeme labels, descriptions, and "aliases" a.k.a. "secondary labels" (whatever that is on a Lexeme, maybe the Forms?) into wb_terms and search indexes?
Is an EntityIdFormatter (possibly a plain text one) enough to have proper Lexeme labels in RDF exports?


This indeed not done. Are these necessary for get lexemes in the statement on on lexeme (or item) page?
I suspecting wb_terms would be ralated to searching for the lexeme, when adding it to the statement. But searching is different thing, that we are actually going to jump on after solving the display part.
But I might have easily missed something, so if there are more requirements, this should be added indeed.TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: thiemowmde, gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-01-29 Thread gerritbot
gerritbot added a comment.
Change 406612 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] [DNM] Add EntityPresenter interface and simple implementation

https://gerrit.wikimedia.org/r/406612TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-01-29 Thread WMDE-leszek
WMDE-leszek added a comment.
Two proof-of-concept patches uploaded. Intentionally simplified etc. Not meant to be merged in any way.

https://gerrit.wikimedia.org/r/406306 adds a formatter class to display lexemes as HTML.
https://gerrit.wikimedia.org/r/406608 moves out the "logic" on how the lexeme is to be displayed (i.e. which data of it to use etc) to a service. It could then be used in other places, e.g. in non-HTML formatters, but possibly in other places too. Note: the "custom" HTML formatter is going to be needed any way, given the specific HTML display (ie. title attribute of the link).TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-01-29 Thread gerritbot
gerritbot added a comment.
Change 406608 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] [DNM] Move the lexeme "displaying" logic to the LexemePresenter

https://gerrit.wikimedia.org/r/406608TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement

2018-01-26 Thread gerritbot
gerritbot added a comment.
Change 406306 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] [DNM] Display lexemes in statements

https://gerrit.wikimedia.org/r/406306TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, gerritbotCc: gerritbot, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs