[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
jcrespo added a comment. okTASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Superyetkin, jcrespoCc: Ladsgroup, Lydia_Pintscher, jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
Ladsgroup added a comment. One tip, add =true so it doesn't minify the result and seeing results will be easier: curl 'https://en.wikipedia.org/w/load.php?debug=false=en=ext.cite.styles%7Cext.echo.badgeicons%7Cext.echo.styles.badge%7Cext.uls.interlanguage%7Cext.visualEditor.desktopArticleTarget.noscript%7Cext.wikimediaBadges%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.sectionAnchor%7Cmediawiki.skinning.interface%7Cskins.vector.styles%7Cwikibase.client.init&_only_=styles=vector=true' | grep -C 50 '/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png' The result is okay: .badge-featuredarticle, .badge-featuredportal, .badge-featuredlist { list-style-image: url(data:image/png;base64,iVBORw0KGgoNSUhEUgkNCAIAAAD0YtNRBnRSTlMA/AD+APzoM1ogWklEQVR4AWP48+8PLkR7uUdzcMvtU8EhdykHKAciEXL3pvw5FQIURaBDJkARoDhY3zEXiCgCHbNBmAlUiyaBkENoxZSDWnOtBmoAQu7TnT+3WuDOA7KBIkAGAGwiNeqjusp/AElFTkSuQmCC); list-style-image: url(/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png?ed948)!ie; } This is part of WikimediaBadges extension: https://phabricator.wikimedia.org/diffusion/EWMB/browse/master/resources/skins/vector/wikimedia-badges.css The thing is that the url is not giving out 404: https://en.wikipedia.org/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png?ed948 The url that was giving out 404 for trwiki had an extra Wikidata bundle: https://en.wikipedia.org/w/extensions/Wikidata/extensions/WikimediaBadges/resources/images/badge-golden-star.png The reason that the url is struck through in your browser is that, it's not using that url and it's using the SVG version (the above list-style-image rule) instead which is faster. HTHTASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Superyetkin, LadsgroupCc: Ladsgroup, Lydia_Pintscher, jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
jcrespo added a comment. curl 'https://en.wikipedia.org/w/load.php?debug=false=en=ext.cite.styles%7Cext.echo.badgeicons%7Cext.echo.styles.badge%7Cext.uls.interlanguage%7Cext.visualEditor.desktopArticleTarget.noscript%7Cext.wikimediaBadges%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.sectionAnchor%7Cmediawiki.skinning.interface%7Cskins.vector.styles%7Cwikibase.client.init&_only_=styles=vector' \ | grep '/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png'TASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Superyetkin, jcrespoCc: Ladsgroup, Lydia_Pintscher, jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
Ladsgroup added a comment. I don't think we have anything else that is used wiki-wide in large scale. Unless my query is wrong. ladsgroup@tin:~$ mwgrep "WikimediaBadges" bhwiki MediaWiki:Gadget-LiveRCSiteConfig.js fiwiki MediaWiki:Gadget-LiveRCSiteConfig.js frwiki MediaWiki:Gadget-LiveRCSiteConfig.js frwiki MediaWiki:Gadget-LiveRCSiteConfig.js/Dev.js itwiki MediaWiki:Gadget-LiveRCSiteConfig.js kabwiki MediaWiki:Gadget-LiveRCSiteConfig.js (total: 6, shown: 6) ladsgroup@tin:~$ mwgrep "WikimediaBadges" --user dewiki User:Dr Brains/LiveRCSiteConfig.js enwiki User:Ladsgroup/monobook.css enwiki User:Mr. Guye/sandbox.js/debug.js fawiki User:Alfa80/Gadget-LiveRCSiteConfig.js frwikinews User:Dr Brains/LiveRCSiteConfig.js hiwiki User:SM7/Gadget-LiveRCSiteConfig.js (total: 6, shown: 6)TASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Superyetkin, LadsgroupCc: Ladsgroup, Lydia_Pintscher, jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
jcrespo added a comment. @Superyetkin As per Ladsgroup, it seems the CSS you added here is not correct https://tr.wikipedia.org/w/index.php?title=MediaWiki%3AVector.css=revision=18969658=18388018 Please double check it. @Ladsgroup Apparently, that reference is not the only one, I think it is a very common addition, but it works on others because it is overriden, see my comment above. While not necessarily our responsability, maybe we should announce it louder so people retire the invalid reference from other wikis too.TASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: Ladsgroup, Lydia_Pintscher, jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
jcrespo added a comment. This is maybe a defect on the deployment of the badges extension/Wikidata or a breakage on apache redirects. However, I have open other languages, that show the image on the browser, and all generate a 404- the image comes from a base64 encoding, not from the static image: Styles applied to featured articles: * list-style-image: url(data:image/png;base64,iVBORw0KGgoNSUhEUgkNCAIAAAD0YtNRBnRST…NBmAlUiyaBkENoxZSDWnOtBmoAQu7TnT+3WuDOA7KBIkAGAGwiNeqjusp/AElFTkSuQmCC); * list-style-image: url(/w/extensions/WikimediaBadges/resources/images/badge-golden-star.png?ed948)!ie; I am inclined to think it looks like a deployment mistake, for some reasons, on tr, the applied style is, on top of the others: url(//tr.wikipedia.org/w/extensions/Wikidata/extensions/WikimediaBadges/resources/images/badge-golden-star.png); I am using https://en.wikipedia.org/wiki/Book_of_Kells as a base for checking (it is featured on enwiki and others).TASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: jcrespo, Superyetkin, Aklapper, Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T186815: Badges not displaying on trwiki
Superyetkin added a comment. How to fix it?TASK DETAILhttps://phabricator.wikimedia.org/T186815EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SuperyetkinCc: Superyetkin, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs