[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
Rschen7754 added a comment. So far so good, some of the pages are working again, and others are working after a purge. I'm still monitoring the script errors category. Thanks for fixing this!TASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_Pintscher, Rschen7754Cc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
Ladsgroup added a comment. I took a look at this and it seems this task is a symptom and not a problem on its own. If it's going down gradually, it means we are hitting scalability issues and there are several ways to handle that. One of them includes optimizing wb_terms table which we are on it but it takes months to become fully useful but if we are returning too many errors like this suddenly, it is a regression bug. Looking at the slow-parse graph in logstash, it tells me that we had an increase around 15 of February which started to decrease around first of March and last week is the lowest in the past 30 days. This drop started exactly when I enabled reading from term_full_entity_id instead of term_entity_id. It helps because we remove an additional where clause from the query (term_entity_type = 'item', etc.). For historical reasons: F14407345: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, LawExplorer, Vali.matei, Volker_E, Wikidata-bugs, aude, GWicke, TheDJ, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
happy5214 added a comment. https://www.wikidata.org/wiki/User:Happy5214/sandbox/California4 replaces that sandbox with https://www.wikidata.org/wiki/Module:Roadtable/section/sandbox2, which replaces the getEntityObject call with a call to getLabelByLang and one getAllStatements call for each property in the "full" model. As you can see, it is significantly worse than the getEntityObject version linked in my last comment.TASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: happy5214Cc: happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
happy5214 added a comment. As the author of the module in question, I should add that there were no such time issues when the module was written, as the expensive function count was reached well before time limits were reached. The third page linked in the report uses a test module specifically written to test these limits (https://www.wikidata.org/wiki/Module:Roadtable/section/sandbox). This module only loads the entity object and retrieves its properties and English label.TASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: happy5214Cc: happy5214, Rschen7754, Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T188378: Error for some Lua modules "The time allocated for running scripts has expired"
Mr.Ibrahem added a comment. I saw that in arwiki last daysTASK DETAILhttps://phabricator.wikimedia.org/T188378EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mr.IbrahemCc: Mr.Ibrahem, hoo, thiemowmde, Lydia_Pintscher, Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
