[Wikidata-bugs] [Maniphest] [Commented On] T189483: Enforce edit rate limits when editing lexeme
gerritbot added a comment. Change 423968 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Test rate limit for all custom APIs and special pages https://gerrit.wikimedia.org/r/423968TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: gerritbot, Addshore, Lydia_Pintscher, Aklapper, WMDE-leszek, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189483: Enforce edit rate limits when editing lexeme
Addshore added a comment. Moving to peer review. Selenium / browser tests are not really possible here as we can't easily change the configuration for a single test. All UI actions use the API anyway, so as long as the API returns the expected error in the default format the UI should handle that.TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Addshore, Lydia_Pintscher, Aklapper, WMDE-leszek, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189483: Enforce edit rate limits when editing lexeme
gerritbot added a comment. Change 423968 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] Test rate limit for all custom APIs and special pages https://gerrit.wikimedia.org/r/423968TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: gerritbot, Addshore, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189483: Enforce edit rate limits when editing lexeme
Addshore added a comment. All APIs and special pages edit using services / classes / code provided by WIkibase, all of which check the edit rate limits. I'm not entirely sure how testable this is, but we could write an integration test for each API endpoint ensuring the rate limit is checked.TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lydia_Pintscher, Aklapper, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
