[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages
gerritbot added a comment. Change 446609 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] DNM Attempt to make EntityInfoBuilder not using wb_terms https://gerrit.wikimedia.org/r/446609TASK DETAILhttps://phabricator.wikimedia.org/T198868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aleksey_WMDE, WMDE-leszek, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages
WMDE-leszek added a comment. AFAIK, the main reason it exists is to load all the labels for the properties to be displayed on a page in a single query. I've found code doing it for the client, but don't see this for the entity page (I remember it was there, but things have probably changed). I guess the interface you mean is EntityInfoBuilder, and in particular its implementation SqlEntityInfoBuilder. It indeed gets data from wb_terms table. If I am not mistaken, this class does not use any "prefetching" lookup service, but relies on making SQL selects directly. This use case should also be explored here, definitely!TASK DETAILhttps://phabricator.wikimedia.org/T198868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, Aleksey_WMDE, WMDE-leszek, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages
gerritbot added a comment. Change 444873 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Count number of $entityIds being prefetched https://gerrit.wikimedia.org/r/444873TASK DETAILhttps://phabricator.wikimedia.org/T198868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aleksey_WMDE, WMDE-leszek, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages
gerritbot added a comment. Change 444873 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)): [mediawiki/extensions/Wikibase@master] Count number of $entityIds being prefetched https://gerrit.wikimedia.org/r/444873TASK DETAILhttps://phabricator.wikimedia.org/T198868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aleksey_WMDE, WMDE-leszek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T198868: Do not get entity data from wb_terms when "prefetching" data for displaying on pages
Aleksey_WMDE added a comment. Apparently, the "prefetching"/buffering is done for LabelDescriptionLookup services, so that when the label/description of particular item/property is to be shown multiple times (e.g. the item appears several times on a page), the label/description is only fetch ones from the storage, and then kept in a in-memory buffer until the end of request. AFAIK, the main reason it exists is to load all the labels for the properties to be displayed on a page in a single query. I've found code doing it for the client, but don't see this for the entity page (I remember it was there, but things have probably changed).TASK DETAILhttps://phabricator.wikimedia.org/T198868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aleksey_WMDE, WMDE-leszek, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
