[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
Ladsgroup added a comment. This is a little bit more complex than it looks because the frontend sends exactly the same request when someone adds a gloss with duplicated language (invalid) or just changes the gloss (valid). So handling it in backend seems tricky or not even needed. We need to do the check in frontend anyway.TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 455863 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Throw error when two glosses in a sense have the same language https://gerrit.wikimedia.org/r/455863TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 457919 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Check for duplicate gloss language codes https://gerrit.wikimedia.org/r/457919TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 455863 abandoned by Ladsgroup: [WIP] Throw error when two glosses in a sense have the same language https://gerrit.wikimedia.org/r/455863TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 457919 abandoned by Lucas Werkmeister (WMDE): Check for duplicate gloss language codes Reason: This clearly goes against whatever we’re currently doing for similar cases elsewhere, whether I like it or not. https://gerrit.wikimedia.org/r/457919TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
Addshore added a comment. @Lydia_Pintscher & #wmde-design how does this look? F25751927: image.png The Forms version looks like this: F25751935: image.png I could also switch the order of the add button and the error: F25751944: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, AddshoreCc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 459564 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP Senses: Prevent redundant gloss languages https://gerrit.wikimedia.org/r/459564TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 459569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] WIP: Warn about sense glosses with duplicate language codes https://gerrit.wikimedia.org/r/459569TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 459564 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Senses: Prevent redundant gloss languages https://gerrit.wikimedia.org/r/459564TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss
gerritbot added a comment. Change 459569 abandoned by Lucas Werkmeister (WMDE): WIP: Warn about sense glosses with duplicate language codes Reason: Superseded by Ifa48f76dff. https://gerrit.wikimedia.org/r/459569TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Ladsgroup, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
