[Wikidata-bugs] [Maniphest] [Commented On] T204488: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`

2019-07-04 Thread gerritbot
gerritbot added a comment.


  Change 520734 had a related patch set uploaded (by Cparle; owner: Cparle):
  [mediawiki/extensions/WikibaseMediaInfo@master] Use regex to replace commas 
in quantity value
  
  https://gerrit.wikimedia.org/r/520734

TASK DETAIL
  https://phabricator.wikimedia.org/T204488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, gerritbot
Cc: Cparle, Addshore, gerritbot, Aklapper, matthiasmullie, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, Eladio.15, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, 
Matanya, Mbch331, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204488: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`

2019-07-03 Thread gerritbot
gerritbot added a comment.


  Change 520453 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Remove clear() method as it's 
not used
  
  https://gerrit.wikimedia.org/r/520453

TASK DETAIL
  https://phabricator.wikimedia.org/T204488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, gerritbot
Cc: Cparle, Addshore, gerritbot, Aklapper, matthiasmullie, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, Eladio.15, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, 
Matanya, Mbch331, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204488: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`

2019-07-03 Thread gerritbot
gerritbot added a comment.


  Change 520453 had a related patch set uploaded (by Cparle; owner: Cparle):
  [mediawiki/extensions/WikibaseMediaInfo@master] Remove clear() method as it's 
not used
  
  https://gerrit.wikimedia.org/r/520453

TASK DETAIL
  https://phabricator.wikimedia.org/T204488

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Cparle, Addshore, gerritbot, Aklapper, matthiasmullie, darthmon_wmde, 
Edtadros, Eladio.15, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, 
LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, aude, 
Fabrice_Florin, Matanya, Mbch331, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T204488: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear`

2019-01-18 Thread Addshore
Addshore added a comment.
So, the situation here changed and datamodel changed to avoid the breaking change.
MediaInfo now uses 9.x, but the MediaInfo entity does have a clear method, (that may not be used?), and also the entity does not implement ClearableEntity.

Either:


The clear method should be removed if it is not used.
MediaInfo entity should implement the ClearableEntity interface.
TASK DETAILhttps://phabricator.wikimedia.org/T204488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, gerritbot, Aklapper, matthiasmullie, Eladio.15, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, Wong128hk, Wikidata-bugs, aude, Fabrice_Florin, Matanya, Mbch331, Legoktm___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs