[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-11-01 Thread gerritbot 
gerritbot added a comment.
Change 463264 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] When an invalid language code is requested use 'und' instead

https://gerrit.wikimedia.org/r/463264TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Jonas, Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-10-13 Thread Krinkle 
Krinkle added a comment.
I'm not sure it is used anywhere, but it just stands for "language undetermined", which is the case when a user passes random crap in there?

Yes, sorry for the confusion, I wasn't disagreeing on it being a good way to handle this kind of input. That makes perfect sense.

But, there is a strong and long precedent for MediaWiki to normalize and fallback to English, not something like und. So doing this only in Wikibase seems like a bad idea to me.

Is there a logical requirement for such a language code here in Wikibase, or would it be possible to do what MediaWiki does here and consistently normalise to en and treat it as such all the way through the stack?TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, KrinkleCc: Jonas, Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-10-09 Thread gerritbot 
gerritbot added a comment.
Change 463323 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Switch Wikibase.NewItemIdFormatter log to error from critical

https://gerrit.wikimedia.org/r/463323TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Jonas, Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread gerritbot 
gerritbot added a comment.
Change 463323 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Switch Wikibase.NewItemIdFormatter log to error from critical

https://gerrit.wikimedia.org/r/463323TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread Krinkle 
Krinkle added a comment.
@Jonas The uselang-hacks represent a legacy feature for the community, originally for Commons but probably other wikis as well. Examples:


https://commons.wikimedia.org/w/index.php?title=Commons:Hochladen=de
https://commons.wikimedia.org/w/index.php?title=Special:Upload=defromgov

https://commons.wikimedia.org/wiki/Commons:Upload
https://commons.wikimedia.org/w/index.php?title=Special:Upload
https://commons.wikimedia.org/w/index.php?title=Special:Upload=ownwork
https://commons.wikimedia.org/w/index.php?title=Special:Upload=fromflickr




In T204791#4622102, @gerritbot wrote:
[mediawiki/extensions/Wikibase@master] When an invalid language code is requested use 'und' instead
 https://gerrit.wikimedia.org/r/463264


I'm familiar with und but have not seen it before MediaWiki context. I may've missed it, but if it is true, then we should probably avoid introducing it in just one area like this – Under the "principle of least surprise", and more generally to reduce inconsistencies and things that can go wrong, or are different without significant benefit (given that consistency is a big benefit, one we would lose). If it is unused and Wikibase does use it, I would recommend documenting the reasoning of this trade-off and filing a task with plan for how/when to resolve the technical debt. You'll want to talk to Wikimedia's Language Engineering team about what the recommended alternatives would be.TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, KrinkleCc: Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread Stashbot 
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-09-27T16:34:52Z]  Synchronized wmf-config/InitialiseSettings.php: T204791 (duration: 00m 57s)TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, StashbotCc: Stashbot, TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread gerritbot 
gerritbot added a comment.
Change 463307 merged by jenkins-bot:
[operations/mediawiki-config@master] logging: Disable 'Wikibase.NewItemIdFormatter' channel

https://gerrit.wikimedia.org/r/463307TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread gerritbot 
gerritbot added a comment.
Change 463307 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[operations/mediawiki-config@master] logging: Disable 'Wikibase.NewItemIdFormatter' channel

https://gerrit.wikimedia.org/r/463307TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread Jonas 
Jonas added a comment.
Interestingly



falls back to English but

⧼lang⧽

not.

Also Language class has interesting special features

	protected static function newFromCode( $code, $fallback = false ) {
		if ( !self::isValidCode( $code ) ) {
			throw new MWException( "Invalid language code \"$code\"" );
		}

		if ( !self::isValidBuiltInCode( $code ) ) {
			// It's not possible to customise this code with class files, so
			// just return a Language object. This is to support uselang= hacks.
			$lang = new Language;
			$lang->setCode( $code );
			return $lang;
		}

Whatever uselang=hacks is ...TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-27 Thread gerritbot 
gerritbot added a comment.
Change 463264 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] When an invalid language code is requested use 'und' instead

https://gerrit.wikimedia.org/r/463264TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: TerraCodes, Liuxinyu970226, Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
One option would be to treat all invalid language codes as und (“undetermined”).TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
This might be coming from a misbehaving gadget, lua module, etc. on a client wiki, which might try to do something like this:

// ...
url += '=' + mw.message('lang').escaped();

MediaWiki:Lang is a message translating to the current user language on some, but not all Wikis (for example, wikidata and dewiki have it, enwiki doesn’t).TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
When an invalid language code is requested some other default formatting will be used. << @Lydia_Pintscher to decide this.

Decision: treat it as an unknown language that falls back to English, just like e. g. uselang=1234. (Note that language fallback indicators should appear, so this isn’t the same as just treating it like English.)TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-21 Thread gerritbot 
gerritbot added a comment.
Change 461624 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff, Throw exception with key when invalid

https://gerrit.wikimedia.org/r/461624TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lydia_Pintscher, gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-20 Thread gerritbot 
gerritbot added a comment.
Change 461624 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff, Throw exception with key when invalid

https://gerrit.wikimedia.org/r/461624TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Addshore, WMDE-leszek, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-20 Thread Addshore 
Addshore added a comment.
Wikibase assumes that the language code in the ParserOptions is valid, but the ParserOptions will happily have whatever language the user provided.

/var/www/mediawiki/extensions/Wikibase/repo/includes/Content/EntityContent.php:272:
object(Language)[652]
  public 'mConverter' => 
object(FakeConverter)[653]
  public 'mLang' => 
(Language)[652]
  public 'mVariants' => null
  public 'mCode' => string '⧼lang⧽' (length=10)
  public 'mLoaded' => boolean false
  public 'mMagicExtensions' => 
array (size=0)
  empty
  public 'mMagicHookDone' => boolean false
  private 'mHtmlCode' => null
  private 'mParentLanguage' => boolean false
  public 'dateFormatStrings' => 
array (size=0)
  empty
  public 'mExtendedSpecialPageAliases' => null
  protected 'namespaceNames' => null
  protected 'mNamespaceIds' => null
  protected 'namespaceAliases' => null
  public 'transformData' => 
array (size=0)
  empty

The language is used in EntityContent::getParserOutputFromEntityView to construct an EntityParserOutputGeneratorTASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WMDE-leszek, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-20 Thread Addshore 
Addshore added a comment.
Looking at the request URLs this seems to be users requesting invalid language codes, and the code makes it all the way into the cache key, that is then invalid as it contains bad chars.

Example:
https://www.wikidata.org/wiki/Q101971?uselang=%E2%A7%BClang%E2%A7%BD

Each single hit on a page like that results in multiple log messages.
I wonder why we bother formating entity ids for invalid languagesTASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WMDE-leszek, Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T204791: Wikibase critical error "Failed to format entity ID. Cache key contains characters that are not allowed"

2018-09-18 Thread Krinkle 
Krinkle added a comment.
This is the first time I've seen a log error in MediaWiki with severity CRITICAL. Given that this issue has been around for over 30 days and that the urls it applies to  all seem to render fine, this is probably incorrect use of this severity.TASK DETAILhttps://phabricator.wikimedia.org/T204791EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Aklapper, Krinkle, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs