[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-08 Thread gerritbot 
gerritbot added a comment.
Change 464870 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Drop hook usage in Watchlist mobile via off feature flag

https://gerrit.wikimedia.org/r/464870TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EnricoCNC, LawExplorer, Winter, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-08 Thread pmiazga 
pmiazga added a comment.
We decided to drop the hook usage anyway, if something goes wrong and mobile watchlist becomes unusable we are able to quickly bring back the old behavior by setting the MFWatchlistRunsChangesListSpecialPageQuery config option to true.TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EnricoCNC, LawExplorer, Winter, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread Jdlrobson 
Jdlrobson added a comment.
Fatals are no longer happening but we need to work out what to do with this hook inside mobilefrontend.TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EnricoCNC, LawExplorer, Winter, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread gerritbot 
gerritbot added a comment.
Change 464850 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] UBN: Hide Flow changes from Special:Watchlist on mobile

https://gerrit.wikimedia.org/r/464850TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread gerritbot 
gerritbot added a comment.
Change 464870 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop hook usage in Watchlist mobile

https://gerrit.wikimedia.org/r/464870TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread Jdlrobson 
Jdlrobson added a comment.
Let me do a step back, my question is -> do we need to call that hook? /cc @Jdlrobson

Was added by the one and only Brion Vibber so I'm guessing so!
I think it's a little dangerous for Hook users to call methods which may throw exceptions without the exception handling so it makes sense to fix this in Flow.TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread gerritbot 
gerritbot added a comment.
Change 464850 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Flow@master] Hide Flow changes from Special:Watchlist on mobile

https://gerrit.wikimedia.org/r/464850TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread pmiazga 
pmiazga added a comment.
Yeah, it may the problem as different things expect some fields to be present in the FormOptions, even we don't use it, we will have to define same set options as ChangesListSpecialPage, maybe we can re-use the ChangesListSpecialPage class (initialize it just to get the options), but honestly that is one big hack.

Let me do a step back, my question is -> do we need to call that hook? /cc @JdlrobsonTASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EnricoCNC, LawExplorer, Winter, Lewizho99, Maathavan, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, Catrope, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread Jdlrobson 
Jdlrobson added a comment.
New issues now
https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Watchlist&mobileaction=toggle_view_mobile

[W7eX5QpEEj4AAD7IPo4A] /w/index.php?title=Special:Watchlist&mobileaction=toggle_view_mobile MWException from line 146 of /srv/mediawiki/php-master/includes/FormOptions.php: Invalid option hidepageedits

Backtrace:

#0 /srv/mediawiki/php-master/includes/FormOptions.php(181): FormOptions->validateName(string, boolean)
#1 /srv/mediawiki/php-master/includes/FormOptions.php(402): FormOptions->getValue(string)
#2 /srv/mediawiki/php-master/extensions/Flow/Hooks.php(2181): FormOptions->offsetGet(string)
#3 /srv/mediawiki/php-master/includes/Hooks.php(174): FlowHooks::onChangesListSpecialPageQuery(string, array, array, array, array, array, FormOptions)
#4 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(285): Hooks::run(string, array)
#6 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/SpecialMobileWatchlist.php(72): SpecialMobileWatchlist->doFeedQuery()
#7 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(58): SpecialMobileWatchlist->executeWhenAvailable(NULL)
#8 /srv/mediawiki/php-master/extensions/MobileFrontend/includes/specials/MobileSpecialPageFeed.php(26): MobileSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(569): MobileSpecialPageFeed->execute(NULL)
#10 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(868): MediaWiki->performRequest()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(525): MediaWiki->main()
#14 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): include(string)
#16 {main}TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread gerritbot 
gerritbot added a comment.
Change 464814 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Pass query_options to the ChangesListSpecialPageQuery hook

https://gerrit.wikimedia.org/r/464814TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-05 Thread gerritbot 
gerritbot added a comment.
Change 464814 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Pass query_options to the ChangesListSpecialPageQuery hook

https://gerrit.wikimedia.org/r/464814TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-04 Thread Krinkle 
Krinkle added a comment.
(Not in a production branch yet, marking as blocker for the next branch instead.)TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-04 Thread Niedzielski 
Niedzielski added a comment.
I didn't realize we had a separate one for beta. I wish our Gerrit / tooling errors went there instead of prod!TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-04 Thread Jdlrobson 
Jdlrobson added a comment.

In T206274#4644087, @Niedzielski wrote:
I wonder why this isn't showing up in the logstash.


Are you checking https://logstash-beta.wmflabs.org/ ?TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdforrester-WMF, pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-04 Thread pmiazga 
pmiazga added a comment.
It's caused by this change: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/463879/3/includes/specials/SpecialMobileWatchlist.phpTASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: pmiazgaCc: pmiazga, Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T206274: MobileFrontend's Watchlist is causing 500 server error on beta cluster

2018-10-04 Thread Niedzielski 
Niedzielski added a comment.
I wonder why this isn't showing up in the logstash.TASK DETAILhttps://phabricator.wikimedia.org/T206274EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NiedzielskiCc: Niedzielski, TerraCodes, Liuxinyu970226, Aklapper, Jdlrobson, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs