[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2019-04-25 Thread Volker_E 
Volker_E added a comment.


  Extension:Translate is ignored for the time being, as it is outdated on 
various levels of #ui-standardization 
 and updating the 
edit icon alone doesn't make sense.

TASK DETAIL
  https://phabricator.wikimedia.org/T207190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Volker_E
Cc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, 
MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, 
TerraCodes, Volker_E, alaa_wmde, Nandana, A.S.Kochergin, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Winter, Iniquity, 
_jensen, rosalieper, JGirault, Psychoslave, Wikidata-bugs, aude, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2019-04-25 Thread Volker_E 
Volker_E added a comment.


  Extension:ContentTranslation (v1; 'edit.svg') is ignored, it's only 
accessible to people who have already started a translation now, as CX2 relies 
on OOUI and will be archived in the mid-future (current approximation: 1 year).

TASK DETAIL
  https://phabricator.wikimedia.org/T207190

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Volker_E
Cc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, 
MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, 
TerraCodes, Volker_E, alaa_wmde, Nandana, A.S.Kochergin, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Winter, Iniquity, 
_jensen, rosalieper, JGirault, Psychoslave, Wikidata-bugs, aude, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-11-07 Thread gerritbot 
gerritbot added a comment.
Change 467731 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace custom edit icon by standard one

https://gerrit.wikimedia.org/r/467731TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E, gerritbotCc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-16 Thread gerritbot 
gerritbot added a comment.
Change 467731 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Wikibase@master] Replace custom edit icon by standard one

https://gerrit.wikimedia.org/r/467731TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Iniquity, JGirault, Psychoslave, Wikidata-bugs, Jdlrobson, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread gerritbot 
gerritbot added a comment.
Change 468083 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Update 'edit' icon to standard

https://gerrit.wikimedia.org/r/468083TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, Jdlrobson, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread alexhollender 
alexhollender added a comment.
awesome, looks great. thanks.TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alexhollenderCc: Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread Ryasmeen 
Ryasmeen added a comment.
So, the solid one is the wrong one? I am seeing two edit icons though for section editing when I switch to MinervaNeue>desktop. Is that a regression?

F26620833: Screen Shot 2018-10-17 at 3.23.43 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alexhollender, RyasmeenCc: Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread gerritbot 
gerritbot added a comment.
Change 468083 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Update 'edit' icon to standard

https://gerrit.wikimedia.org/r/468083TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alexhollender, gerritbotCc: Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread Jdlrobson 
Jdlrobson added a comment.
@Ryasmeen Patch isn't quite on beta cluster yet! Will assign you and add to Audiences-QA as soon as it is. Sorry for the confusion!

You should be only seeing one icon though... when I visit https://en.m.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)/sandbox I'm not seeing 2 icons.TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alexhollender, JdlrobsonCc: Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread Ryasmeen 
Ryasmeen added a comment.
@Jdlrobson: So that happens when I click on the link "Desktop" at the bottom of that page and have MinervaNeue set.TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alexhollender, RyasmeenCc: Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-17 Thread Ryasmeen 
Ryasmeen added a comment.

In T207190#4676208, @Jdlrobson wrote:
this is on beta cluster now.


yeah, I see the solid edit icon now.TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RyasmeenCc: Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-18 Thread ABorbaWMF 
ABorbaWMF added a comment.
Looks ok on most of the edit icons I could find. It does look like the Language edit button is still incorrect.
F26624713: Screen Shot 2018-10-18 at 2.09.32 PM.png
F26624714: Screen Shot 2018-10-18 at 2.10.06 PM.png
F26624715: Screen Shot 2018-10-18 at 2.11.26 PM.png

Language edits
F26624721: Screen Shot 2018-10-18 at 2.07.19 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E, ABorbaWMFCc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-18 Thread Volker_E 
Volker_E added a comment.
@ABorbaWMF Thanks, yes. Language “Add links” link is part of extension WikiBase and not yet merged…TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_ECc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, Quiddity, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-18 Thread Jdlrobson 
Jdlrobson added a comment.
@Volker_E on mobile, the edit icon seems to conflict a little with the toggle indicators and language icons (which are less blocky). It also seems like it has alignment issues/height issue compared to watch icon.
Is that just because I'm not a designer?
F26625062: Screen Shot 2018-10-18 at 5.01.28 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_E, JdlrobsonCc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207190: Use consistent 'edit' icon across web products

2018-10-18 Thread Volker_E 
Volker_E added a comment.
@Jdlrobson Identifying several issues from your comment:


First issue (blocky) is foremost a context-specific, if you feel strongly about it, you should raise it as separate task as these icons have been all designed with our icon guidelines in mind.
Toggle indicator is an indicator and not an icon and doesn't need to be as strong.
To the watch icon, apart from context, it might be that the watch star icon wasn't updated after T177432, although I remember that it has been.
The coloring is a separate issue as well, I think that mobile has various issues here, see F26625188: image.png for example. There should be a clear pattern to follow when an icon is an active element, it's selected, it's only informative, it's disabled…?!
TASK DETAILhttps://phabricator.wikimedia.org/T207190EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_ECc: ABorbaWMF, Ryasmeen, Jdlrobson, alexhollender, gerritbot, RHo, Pginer-WMF, MZMcBride, Maryana, Glaisher, Aklapper, Esanders, tarlocesilion, Ricordisamoa, TerraCodes, Liuxinyu970226, Volker_E, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, Lewizho99, Maathavan, Iniquity, JGirault, Psychoslave, Wikidata-bugs, aude, Ladsgroup, Mbch331, Rxy, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs