[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[WMDE-leszek]

WMDE-leszek added a comment.


  In T207893#5431241 , 
@dom_walden wrote:
  
  > In T207893#5429435 , 
@dbarratt wrote:
  >
  >> Oversight on my part, it looks like the creation code (in both patches) is 
using `AbstractBlock::isSitewide()` instead of 
`AbstractBlock::appliesToNamespace()` (as is outlined in the task description). 
Using the former means that someone who is blocked from a namespace **will** be 
allowed to create an item in that namespace, using the latter will ensure they 
are blocked properly from that namespace.
  >
  > As I understand it, the namespace blocking for Lexemes was done in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/520200. 
But please confirm this.
  > Testing on beta , I **cannot** 
create a new Lexeme (either via Special:NewLexeme or 
api.php?action=wbeditentity) if I am partially blocked from the "Lexeme" 
namespace or if I am sitewide blocked.
  > I **can** if I am partially blocked but not from the Lexeme namespace.
  
  thanks @dom_walden ! So are we fine to conclude this is now resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, WMDE-leszek
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.


  In T207893#5431250 , 
@Ladsgroup wrote:
  
  > I just want to mention those parts are for basic access to the special 
page, the real action is being handled by PermissionManager so nothing is 
broken here.
  
  Ah! perfect. thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, dbarratt
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Ladsgroup]

Ladsgroup added a comment.


  In T207893#5429435 , 
@dbarratt wrote:
  
  > Oversight on my part, it looks like the creation code (in both patches) is 
using `AbstractBlock::isSitewide()` instead of 
`AbstractBlock::appliesToNamespace()` (as is outlined in the task description). 
Using the former means that someone who is blocked from a namespace **will** be 
allowed to create an item in that namespace, using the latter will ensure they 
are blocked properly from that namespace.
  
  I just want to mention those parts are for basic access to the special page, 
the real action is being handled by PermissionManager so nothing is broken here.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Ladsgroup
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dom_walden]

dom_walden added a comment.


  In T207893#5429435 , 
@dbarratt wrote:
  
  > Oversight on my part, it looks like the creation code (in both patches) is 
using `AbstractBlock::isSitewide()` instead of 
`AbstractBlock::appliesToNamespace()` (as is outlined in the task description). 
Using the former means that someone who is blocked from a namespace **will** be 
allowed to create an item in that namespace, using the latter will ensure they 
are blocked properly from that namespace.
  
  As I understand it, the namespace blocking for Lexemes was done in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/520200. 
But please confirm this.
  
  Testing on beta , I **cannot** create 
a new Lexeme (either via Special:NewLexeme or api.php?action=wbeditentity) if I 
am partially blocked from the "Lexeme" namespace or if I am sitewide blocked.
  
  I **can** if I am partially blocked but not from the Lexeme namespace.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, dom_walden
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 531347 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Add site wide block check to 
checkBlocked
  
  https://gerrit.wikimedia.org/r/531347

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, MattLongCT, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, aezell, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, dmaza, 
Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 531347 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
  [mediawiki/extensions/WikibaseLexeme@master] Add site wide block check to 
checkBlocked
  
  https://gerrit.wikimedia.org/r/531347

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, gerritbot
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dom_walden]

dom_walden added a comment.


  I am blocked from https://wikidata.beta.wmflabs.org/wiki/Special:NewLexeme 
even if I am only partially blocked.
  
  Maybe the appropriate change needs to be made here: 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/master/src/MediaWiki/Specials/SpecialNewLexeme.php#120

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dom_walden
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[WMDE-leszek]

WMDE-leszek added a comment.


  @dom_walden I've just added you to admin group on 
https://wikidata.beta.wmflabs.org (rights expire in 24 hours, let me know if 
this is a silly restriction, so I will make you unexpirying admin)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, WMDE-leszek
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[alaa_wmde]

alaa_wmde added a comment.


  @dbarratt @Niharika have you tested this? is it good?

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, alaa_wmde
Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, 
Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, 
Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, 
aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Addshore]

Addshore added a comment.


  @dbarratt @Niharika I added you both to the admin group on test wikidata

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Addshore
Cc: dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, 
WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, 
MGChecker, darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Sario528, 
Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, 
_jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.


  It's already enabled there! :)
  https://wikidata.beta.wmflabs.org/wiki/Special:Block
  and
  https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Block

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dbarratt
Cc: dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, 
WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, 
MGChecker, darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, 
dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.


  In T207893#5329793 , 
@Niharika wrote:
  
  > In T207893#5329617 , 
@dbarratt wrote:
  >
  >> It's also enabled in production at:
  >> https://test.wikidata.org/wiki/Special:Block
  >
  > @dbarratt Do you have rights on that site to give me and @dom_walden access 
to `Special:Block`?
  
  I can access it myself, but not grant access.
  
  But we can also enable on beta. :)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dbarratt
Cc: dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, 
WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, 
MGChecker, darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, 
dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  @Niharika User:NKohli (WMF) doesn’t seem to exist on testwikidata yet, I 
think you’ll have to create the account there first before rights can be given 
to it. (@dbarratt exists, but I don’t have the rights to make him admin, 
apparently.)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, 
WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, 
MGChecker, darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, 
dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.


  It's also enabled in production at:
  https://test.wikidata.org/wiki/Special:Block

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dbarratt
Cc: hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, 
TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, 
darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, dmaza, 
GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Niharika]

Niharika added a comment.


  In T207893#5326996 , 
@Ladsgroup wrote:
  
  > In T207893#5326979 , 
@Niharika wrote:
  >
  >> Thanks @hoo. What's the best way to test this?
  >
  > Enabling partial blocks on wikidata and commons in beta cluster would be a 
good point IMO
  
  Thanks @Ladsgroup!

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Niharika
Cc: hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, 
TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, 
darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, dmaza, 
GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Ladsgroup]

Ladsgroup added a comment.


  In T207893#5326979 , 
@Niharika wrote:
  
  > Thanks @hoo. What's the best way to test this?
  
  Enabling partial blocks on wikidata and commons in beta cluster would be a 
good point IMO

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, 
TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, 
darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, dmaza, 
GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Niharika]

Niharika added a comment.


  Thanks @hoo. What's the best way to test this?

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Niharika
Cc: hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, 
TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, 
darthmon_wmde, MattLongCT, alaa_wmde, Nandana, aezell, Lahi, Gq86, dmaza, 
GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, 
Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 517450 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add namespace-based block check on 
SpecialNewEntity
  
  https://gerrit.wikimedia.org/r/517450

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 517442 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Make SpecialWikibasePage only respect 
site-wide block
  
  https://gerrit.wikimedia.org/r/517442

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 520200 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Add namespace-based block check 
to SpecialNewLexeme
  
  https://gerrit.wikimedia.org/r/520200

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 520200 had a related patch set uploaded (by Hoo man; owner: Hoo man):
  [mediawiki/extensions/WikibaseLexeme@master] Add namespace-based block check 
to SpecialNewLexeme
  
  https://gerrit.wikimedia.org/r/520200

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.


  You can see an example of not knowing in MediaWiki by blocking a test user 
from a namespace (say `MediaWiki`) and then attempting to create a new page in 
that namespace.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, dbarratt
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, alaa_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 517450 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Add namespace-based block check on 
SpecialNewEntity
  
  https://gerrit.wikimedia.org/r/517450

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, MattLongCT, joker88john, 
CucyNoiD, Nandana, NebulousIris, aezell, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, dmaza, Bsandipan, Lordiis, GoranSMilovanovic, SPoore, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, 
Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[gerritbot]

gerritbot added a comment.


  Change 517442 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Make SpecialWikibasePage only respect 
site-wide block
  
  https://gerrit.wikimedia.org/r/517442

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
MattLongCT, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, 
Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Ladsgroup]

Ladsgroup added a comment.


  This is rather lots of work, SpecialWikibasePage is not the right place to 
keep the list, Making it per special page also is complex, like 
Special:SetLabel can be used on property and item and if the person is blocked 
on item namespace, there's no way to make sure it's applied until the user 
actually tries it (in which EntityStore should handle it properly using 
PermissionManager), so maybe we should just drop it? I would prefer if the 
special page still checks for site-wide bans.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
MattLongCT, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, 
Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Niharika]

Niharika added a comment.


  In T207893#5255918 , 
@WMDE-leszek wrote:
  
  > @Niharika would you mind reminding us what is the planned timeline of the 
deployment of partial blocks? Just so that we know how urgently the fix is 
needed (I do anticipate that ASAP is preferred, but given you've "only" raised 
the priority up to "Normal" we would also only prioritize it accordingly)
  
  
  Our planned rollout for Partial blocks is end of this month (June). I was 
actually going to raise the priority higher but I didn't want to step on 
anyone's toes (whoever prioritizes tickets at your end). ASAP is indeed 
preferred.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Niharika
Cc: Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
MattLongCT, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, 
Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[WMDE-leszek]

WMDE-leszek added a comment.


  @Niharika would you mind reminding us what is the planned timeline of the 
deployment of partial blocks? Just so that we know how urgently the fix is 
needed (I do anticipate that ASAP is preferred, but given you've "only" raised 
the priority up to "Normal" we would also only prioritize it accordingly)

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
MattLongCT, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, 
Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Addshore]

Addshore added a comment.


  Thanks for all of the details.
  I believe that 1 bit of phpdoc, which sounds like it will now be altered, is 
what was throwing me a bit off.
  
  @lydia I believe we have all of the details we need to write this up for 
pickup. :)
  I'll try and get that done this week (unless someone wants to jump in before 
me) or if we just want to pick it up and have whoever implements it read 
through the comments.!

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Tchanders]

Tchanders added a comment.


  In T207893#5251961 , 
@dbarratt wrote:
  
  > In T207893#5250838 , 
@Addshore wrote:
  >
  > > So I guess we use BlockManager to get the blocks of a user?
  >
  >
  > You can use either `User::getBlock()` or `BlockManager::getUserBlock()`. 
They are //slightly// different, but for your purposes, it should always return 
the same result.
  
  
  You should use User::getBlock, since that will call 
BlockManager::getUserBlock and run the hooks too.
  
  (BlockManager::getUserBlock should be treated as internal and only be called 
by User::getBlockedStatus (as documented). Eventually, the blocks logic should 
be taken out of User, as part of the wider effort to untangle such 
dependencies, at which point the way to get a block will be via the 
BlockManager, but we're not there yet.)
  
  >> And then check the blocks to see if they apply to the namespace we are 
creating in?
  > 
  > Yes. :)
  
  Yes, so somethig like:
  
$block = $user->getBlock();
if ( $block && $block->appliesToNamespace( $ns ) ) { ... }
  
  
  
  >> Blockmanager::getUserBlock only returns one block ("the most relevant 
one"), what happens in the situation when a user has 2 block for different 
namespaces?
  > 
  > You will get a `CompositeBlock` object which will extend from 
`AbstractBlock` class and have all of the same methods. MediaWiki has, up until 
this week, always returned a single, most-relevant block anyways. Starting 
soon, you'll get a `CompositeBlock` which can be used the same way.
  
  A few things to add here:
  
  - Two blocks can't be stored against exactly the same target, but a user can 
be affected by more than one block if there are blocks against their account 
and IP address, or against some ranges that cover their IP address
  - "the most relevant one" is a not-terribly-helpful way of saying the most 
"specific" one, meaning that a user account block is chosen over an IP block, 
which is chosen over an IP range block (and narrower IP range blocks are 
favoured over wider ones). Thanks for pointing this out, will improve the docs.
  - AHT should be merging this soon: 
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497668/ After this, if 
BlockManager::getUserBlock finds more than one block, then instead of choosing 
just one, it will return a composite block combining the strictest features of 
all the blocks. So if there are blocks that apply to different namespaces, this 
composite block will apply to all of them.
  
  >> Is there a way to get all blocks of a user? Or a way to see if any of a 
users blocks apply to a namespace?
  > 
  > We could probably build that into `CompositeBlock` if you really need them, 
but calling `::appliesToNamespace()` on the `AbstractBlock` returned from 
`User::getBlock()` or `BlockManager::getUserBlock()` should be what you want.
  > 
  >> Maybe we need a User::isBlockedFromNamespace, or rather 
PermissionManager::isBlockedFromNamespace() ?
  > 
  > I think the best way would be to determine if the `AbstractBlock` applies 
to the namespace with `AbstractBlock::appliesToNamespace()`.
  
  After the above patch is merged, doing `$user->getBlock()` and 
`$block->appliesToNamespace( $ns )` as shown above will do all of this.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tchanders
Cc: Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, 
Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Addshore]

Addshore added a comment.


  I just had another quick look at this today.
  
  In T207893#4787089 , 
@dbarratt wrote:
  
  > In T204991  we've added the 
method `Block::appliesToNamespace()` which can be used for new entity creation.
  
  
  So I guess we use BlockManager to get the blocks of a user?
  And then check the blocks to see if they apply to the namespace we are 
creating in?
  
  Blockmanager::getUserBlock only returns one block ("the most relevant one"), 
what happens in the situation when a user has 2 block for different namespaces?
  Is there a way to get all blocks of a user? Or a way to see if any of a users 
blocks apply to a namespace?
  
  Maybe we need a User::isBlockedFromNamespace, or rather 
PermissionManager::isBlockedFromNamespace() ?
  
  In T207893#5109784 , 
@Lydia_Pintscher wrote:
  
  > @WMDE-leszek can we sit down together and get this ready for pickup?
  
  
  The work that is needed for editing special pages is already outlined in the 
task description, although some refactoring will be needed there in order to 
get the Title to the method where we check blocks, or just do the block 
checking in each special page class itself.
  
  Then we need to resolve my questions at the top of this comment about 
appliesToNamespace for entity creation.
  
  As for edits through the API, as far as I can tell these block checks are 
already handled via the edit actions an EditEntityAction -> Action.php in core. 
So nothing to do there.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, 
Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Niharika]

Niharika added a comment.


  In T207893#5109784 , 
@Lydia_Pintscher wrote:
  
  > @WMDE-leszek can we sit down together and get this ready for pickup?
  
  
  Hi @Lydia_Pintscher! Is there an update on this? We're getting ready to 
deploy partial blocks across all wikis.

TASK DETAIL
  https://phabricator.wikimedia.org/T207893

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Niharika
Cc: Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, 
Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, Premeditated, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.

In T207893#4718146, @Lucas_Werkmeister_WMDE wrote:
Note that checkBlocked is also used in SpecialNewEntity, where we don’t have a title to check yet. What’s the correct way to check if a user is allowed to create a page?


If it makes more sense, we could make a method on Block that would allow you to pass in a namespace and it would return a boolean based on whether the user is blocked from that namespace. Would that be helpful?TASK DETAILhttps://phabricator.wikimedia.org/T207893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dbarrattCc: TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, PEarleyWMF, RuyP, jrbs, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[TBolliger]

TBolliger added a comment.

In T207893#4721082, @Addshore wrote:
Is the #anti-harassment team going to work on this or is the expectation that it be picked up by #wikidata ?


Great question — right now our team is focussed on getting Partial Blocks into releasable shape for a few early adopter Wikipedias. We'll only be bugfixing and building new functionality for them. Once we're satisfied with the level of functionality and quality, we'll release to more wikis, bugfixing as needed. Enabling this functionality will depend on when different communities are ready.

Of course, if the wikidata team wants to hop in early and make any wikidata specific fixes, AHT would be happy to help code review and provide input.TASK DETAILhttps://phabricator.wikimedia.org/T207893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TBolligerCc: TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, PEarleyWMF, RuyP, jrbs, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Addshore]

Addshore added a comment.
Is the #anti-harassment team going to work on this or is the expectation that it be picked up by #wikidata ?TASK DETAILhttps://phabricator.wikimedia.org/T207893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, TBolliger, QZanden, LawExplorer, JJMC89, PEarleyWMF, RuyP, jrbs, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[dbarratt]

dbarratt added a comment.

In T207893#4718146, @Lucas_Werkmeister_WMDE wrote:
Note that checkBlocked is also used in SpecialNewEntity, where we don’t have a title to check yet. What’s the correct way to check if a user is allowed to create a page?


I would:

For creation, use the reserved `0` for the entity (i.e. `Q0` or `Property:P0`).

unless that's a bad idea? That should allow for namespace checking, etc.TASK DETAILhttps://phabricator.wikimedia.org/T207893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dbarrattCc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, TBolliger, QZanden, LawExplorer, JJMC89, PEarleyWMF, RuyP, jrbs, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Note that checkBlocked is also used in SpecialNewEntity, where we don’t have a title to check yet. What’s the correct way to check if a user is allowed to create a page?TASK DETAILhttps://phabricator.wikimedia.org/T207893EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, TBolliger, QZanden, LawExplorer, JJMC89, PEarleyWMF, RuyP, jrbs, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs