[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-17 Thread gerritbot 
gerritbot added a comment.
Change 473585 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities

https://gerrit.wikimedia.org/r/473585TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-16 Thread gerritbot 
gerritbot added a comment.
Change 473587 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms

https://gerrit.wikimedia.org/r/473587TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-16 Thread gerritbot 
gerritbot added a comment.
Change 473586 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes

https://gerrit.wikimedia.org/r/473586TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Alright, I’ve uploaded one possible approach:


 Wikibase
 WikibaseLexeme


It’s not the nicest thing in the world, but I think it’s acceptable. Alternative suggestions are welcome, though.

Related but independent is another fix in WikibaseLexeme.TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread gerritbot 
gerritbot added a comment.
Change 473586 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Don’t detect fragments of form IDs of other lexemes

https://gerrit.wikimedia.org/r/473586TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread gerritbot 
gerritbot added a comment.
Change 473587 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix the fragment of old-style links to forms

https://gerrit.wikimedia.org/r/473587TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread gerritbot 
gerritbot added a comment.
Change 473585 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix the fragment of old-style links to subentities

https://gerrit.wikimedia.org/r/473585TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Michael, gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.

In T208423#4731782, @Lucas_Werkmeister_WMDE wrote:

The component which prettifies entity links in edit summaries hasn’t been updated for the new form anchors yet, apparently.
Could that component also be used to update the anchor from e. g. #L41-F1 to #F1, solving this issue without requiring any database modifications?



The first part of this is fixed with the above change, I’ll try to do the second part now.TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-14 Thread gerritbot 
gerritbot added a comment.
Change 472953 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment

https://gerrit.wikimedia.org/r/472953TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-12 Thread gerritbot 
gerritbot added a comment.
Change 472953 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Create lexeme id from fragment

https://gerrit.wikimedia.org/r/472953TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
I looked a bit into this as well, and I think LexemeHandler::getIdForTitle needs to be updated. It currently tries to “parse” the fragment as an ID; in addition, it should also attempt to parse text + fragment as an ID.TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-09 Thread Michael 
Michael added a comment.
Results of the investigation so far:

The relevant pattern is in WikibaseLexeme/src/Domain/Model/FormId.php:

const PATTERN = '/^L[1-9]\d*-F[1-9]\d*\z/';

However, simply removing the first part of the pattern breaks \Wikibase\Lexeme\Domain\Model\LexemeSubEntityId::extractLexemeIdAndSubEntityId, which relies on the two-part form.TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, D3r1ck01, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
I actually noticed a different problem on L42’s history on testwikidata:

(‎Created claim: lexeme form of choice (P1): merge target/merge source/foo (L103)) (undo)
 (‎Created claim: lexeme form of choice (P1): MediaWikis (L41-F1)) (undo) (restore)

In the older edit (below), the link [[L41#L41-F1]] is rendered as a link to the L41-F1 entity, using the representation of that form (MediaWikis – plural: the lexeme’s lemma is MediaWiki, singular). In the newer edit, however (above), the link [[L103#F1]] is rendered as a link to the L103 entity, using the lemmas of that lexeme, instead of the representations of its first form (which would be just merge sorce). So that’s two related things:


The component which prettifies entity links in edit summaries hasn’t been updated for the new form anchors yet, apparently.
Could that component also be used to update the anchor from e. g. #L41-F1 to #F1, solving this issue without requiring any database modifications?


Unfortunately, I don’t remember where that component actually is right now, and I can’t find anything relevant in WikibaseLexeme’s wiring files.TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-07 Thread Michael 
Michael added a comment.
Turns out the wikitext for the comment from the summary is directly in the database as wikitext. Thus is seems not savely possible to fix the old entries.

Screenshots are from system recreating the problem:

F27096357: Screenshot_2018-11-07 phpmyadmin mw localhost 8080 db-master default revision phpMyAdmin 4 8 3.png

F27096356: Screenshot_2018-11-07 phpmyadmin mw localhost 8080 db-master default revision phpMyAdmin 4 8 3(1).pngTASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T208423: Revision summaries use outdated form links

2018-11-07 Thread Michael 
Michael added a comment.
It seems this is only a problem with historic entries. New ones are fine-ish: https://test.wikidata.org/w/index.php?title=Lexeme:L42="">TASK DETAILhttps://phabricator.wikimedia.org/T208423EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MichaelCc: WMDE-leszek, Lea_Lacroix_WMDE, Lydia_Pintscher, Pablo-WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs