[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2020-01-23 Thread Jdforrester-WMF 
Jdforrester-WMF added a comment.


  REL1_32 is EOL. Is this a problem in any other branch, or can we Invalid it 
again?

TASK DETAIL
  https://phabricator.wikimedia.org/T209216

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, hashar, Tgr, Addshore, D3r1ck01, Zoranzoki21, gerritbot, 
Aklapper, mmodell, Reedy, Legoktm, Paladox, darthmon_wmde, Nandana, Urfiner, 
Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, MGChecker, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-13 Thread Reedy 
Reedy added a comment.

In T209216#4740264, @Paladox wrote:
@Addshore nope, it was caused by https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/505e4860cc720e1a5098fd3272268448d3342074#diff-0bca4e0eecbdd09ab1c39db21d521610 which is in REL1_32+





In T209216#4737409, @Reedy wrote:
That would break running composer install/update in the extension dir and expecting it to work...

Wouldn't change running it in MW core root


TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: Addshore, D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-12 Thread Paladox 
Paladox added a comment.
@Addshore nope, it was caused by https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/505e4860cc720e1a5098fd3272268448d3342074#diff-0bca4e0eecbdd09ab1c39db21d521610 which is in REL1_32+TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc: Addshore, D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-12 Thread Addshore 
Addshore added a comment.

In T209216#4736991, @Paladox wrote:
Nope, this works in REL1_31 so this has to be a problem in 1.32.


or something was done wrong in the REL1_31 branch / release?TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-11 Thread Addshore 
Addshore added a comment.

In T209216#4737409, @Reedy wrote:
That would break running composer install/update in the extension dir and expecting it to work...

Wouldn't change running it in MW core root


Indeed, Wikibase composer dependencies are meant to be installed by doing composer update / install in the root mediawiki dir and using the composer merge plugin.
This is documented in the extension readme https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/README.md#install

I wouldn't expect the wikibase deps to be in the tarballed mediawiki-vendor repo.TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Reedy 
Reedy added a comment.
That would break running composer install/update in the extension dir and expecting it to work...

Wouldn't change running it in MW core rootTASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Paladox 
Paladox added a comment.
Yes, here https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/505e4860cc720e1a5098fd3272268448d3342074#diff-0bca4e0eecbdd09ab1c39db21d521610

(But dosent really explain why it had to be removed compared to checking if vendor/autoload.php exists in the extension root and then fallback to mw core vendor)TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc: D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Reedy 
Reedy added a comment.

In T209216#4737022, @Paladox wrote:
Aha, they removed this

// This is the path to the autoloader generated by composer in case of a composer install.
if ( is_readable( __DIR__ . '/../vendor/autoload.php' ) ) {
require_once __DIR__ . '/../vendor/autoload.php';
}

from WikibaseLib.php (it's in mw 1.31 but not 1.32)


Do you know in which commit? And hence, why?TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Reedy 
Reedy added a comment.

In T209216#4737057, @Paladox wrote:
Nope, it seems they changed it to using the merge plugin (as you said earlier). But i would expect a extension to try to load it locally before using the mw core one.


That’s why composer.json has the thing to mark that an extension has dependencies so you can have them locally in the extension or in the one for core

Wikibase et are complexTASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread D3r1ck01 
D3r1ck01 added a comment.
Related maybe? https://discourse-mediawiki.wmflabs.org/t/fatal-error-interface-psr-simplecache-cacheinterface-not-found/726TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: D3r1ck01, Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Paladox 
Paladox added a comment.
Nope, it seems they changed it to using the merge plugin (as you said earlier). But i would expect a extension to try to load it locally before using the mw core one.TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc: Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Reedy 
Reedy added a comment.

In T209216#4737022, @Paladox wrote:
Aha, they removed this

// This is the path to the autoloader generated by composer in case of a composer install.
if ( is_readable( __DIR__ . '/../vendor/autoload.php' ) ) {
require_once __DIR__ . '/../vendor/autoload.php';
}

from WikibaseLib.php (it's in mw 1.31 but not 1.32)


They don’t have an extension.json then?TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Paladox 
Paladox added a comment.
Aha, they removed this

// This is the path to the autoloader generated by composer in case of a composer install.
if ( is_readable( DIR . '/../vendor/autoload.php' ) ) {

require_once __DIR__ . '/../vendor/autoload.php';

}

from WikibaseLib.php (it's in mw 1.31 but not 1.32)TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc: Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Paladox 
Paladox added a comment.
So i found a hack, if you add require_once DIR ../vendor/autoload.php it works in WikibaseRepo.php.

So i guess that's what is needed?TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PaladoxCc: Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread Zoranzoki21 
Zoranzoki21 added a comment.
wikibase/data-model/src/Entity/Item.php
wikibase/data-model/src/Entity/ItemId.php
wikibase/data-model/src/Entity/ItemIdParser.php
wikibase/data-model/src/Entity/ItemIdSet.php

These files should be rollbacked,TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21Cc: Zoranzoki21, gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread gerritbot 
gerritbot added a comment.
Change 472787 abandoned by Zoranzoki21:
Revert "Remove non-tarball dependencies from release branch"

Reason:
Per Reedy`s comment in task

https://gerrit.wikimedia.org/r/472787TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, RazeSoldier, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209216: Wikibase cannot find a class on REL1_32

2018-11-10 Thread gerritbot 
gerritbot added a comment.
Change 472787 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/vendor@REL1_32] Revert "Remove non-tarball dependencies from release branch"

https://gerrit.wikimedia.org/r/472787TASK DETAILhttps://phabricator.wikimedia.org/T209216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, mmodell, Reedy, Legoktm, Paladox, Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, D3r1ck01, MGChecker, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs