[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[Addshore]

Addshore added a comment.


  In T209803#5316994 , 
@alaa_wmde wrote:
  
  > We will open a separate task for moving this repo under wmde github org
  
  Currently at https://github.com/wikidata/WikibaseImport
  The docker images have been switched to read from this location 
https://github.com/wmde/wikibase-docker/commit/dc466bf858d30ccfddf26cded81a4acea2440bad

TASK DETAIL
  https://phabricator.wikimedia.org/T209803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: alaa_wmde, Addshore, Lydia_Pintscher, aude, DD063520, dbs, erik_s_paulson, 
Aklapper, Iflorez, darthmon_wmde, Jelabra, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Asahiko, 
Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T209803#5273110 , 
@DD063520 wrote:
  
  > I have some other pull requests that I didn't do up to now because they 
seam not to be accepted:
  >
  > 1. adds a property Wikidata ID so that one has a link between the new and 
the old entities
  > 2. some refactoring making the import faster
  > 3. a bug about the number of statements of entities Salut Dennis
  
  
  Sorry about that. We didn't have this on our radar.

TASK DETAIL
  https://phabricator.wikimedia.org/T209803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Addshore, Lydia_Pintscher, aude, DD063520, dbs, erik_s_paulson, Aklapper, 
darthmon_wmde, Jelabra, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[DD063520]

DD063520 added a comment.


  I have some other pull requests that I didn't do up to now because they seam 
not to be accepted:
  
  1. adds a property Wikidata ID so that one has a link between the new and the 
old entities
  2. some refactoring making the import faster
  3. a bug about the number of statements of entities
  
  Salut
  Dennis
  
  PS the problem is that I'm not a php coder so the code might not have hight 
quality

TASK DETAIL
  https://phabricator.wikimedia.org/T209803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DD063520
Cc: Addshore, Lydia_Pintscher, aude, DD063520, dbs, erik_s_paulson, Aklapper, 
darthmon_wmde, Jelabra, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[DD063520]

DD063520 added a comment.


  This pull request should fix the issue:
  https://github.com/filbertkm/WikibaseImport/pull/41

TASK DETAIL
  https://phabricator.wikimedia.org/T209803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DD063520
Cc: DD063520, dbs, erik_s_paulson, Aklapper, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[dbs]

dbs added a comment.
Ah, the square metre and square kilometre issue have been known for a couple of years now: https://github.com/filbertkm/WikibaseImport/issues/16TASK DETAILhttps://phabricator.wikimedia.org/T209803EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dbsCc: dbs, erik_s_paulson, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Addshore, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

[dbs]

dbs added a comment.
I reproduced this problem on a fresh Wikibase 1.31 Docker image. The end of my first attempt showed:

[2018-11-19 02:21:59]: Adding statements: Q16107138
[2018-11-19 02:22:01]: DB connection was already closed or the connection dropped.
[2018-11-19 02:22:01]: Done

There were no logs in /var/log/mediawiki/ to peruse. However, the database message made me wonder if there was an issue specifically connected with adding the statements.

I ran the importEntities.php command again. It reported that all of the entities and properties had already been created, but this time no database message followed the "Adding statements" log entry. And voila, now the statements were all visible at http://localhost:8181/wiki/Item:Q2 and visible in WDQS.

Subsequent importEntities.php commands on the same image were inconsistent:


Q2882604 and Q7532877 worked on the first try.
Q133116 failed with an illegal value related to Q25343 ("square metre"):


[2018-11-19 02:40:12]: Adding statements: Q133116
[2018-11-19 02:40:15]: Illegal value: http://www.wikidata.org/entity/Q25343
[2018-11-19 02:40:15]: Done


Q340 failed with an illegal value related to Q712226 ("square kilometre"). Hmm.
TASK DETAILhttps://phabricator.wikimedia.org/T209803EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: dbsCc: dbs, erik_s_paulson, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, D3r1ck01, Wikidata-bugs, aude, Addshore, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs