subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T217329\: bug in 1.33.0\-wmf.18 breaks abstract dumps on testwikidatawiki \| MWContentSerializationException $entityId and $targetId can not be the same"

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2020-05-19 Thread Krinkle

Krinkle added a comment.


  Seen on www.wikidata.org as well.
  
  - reqId: `4a83c7b9-dff6-4185-9a7d-b9dac050a1ab`
  - reqId: `a0bb4945-e080-4b41-a402-4c0edb562eff`
  - reqId: `081d5f57-ff6a-4f29-9971-fa722d7eae6b`
  - reqId: `df03dd06-c3cd-4853-b04a-dba00183800f`
  
  
  
wikidatawiki 
/w/api.php?action=query=json=revisions=2=Lexeme%3AL123=content%7Cuser%7Cids=max=%7C%7C=20190401115845%7C899647120

MWContentSerializationException from line 299 of 
/srv/mediawiki/php-1.35.0-wmf.31/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Pablo-WMDE, alaa_wmde, gerritbot, Addshore, WMDE-leszek, 
Lucas_Werkmeister_WMDE, ArielGlenn, Naike, jannee_e, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-08-09 Thread Addshore

Addshore added a comment.


  It's a shame we have cases of self redirects already in history that we have 
to try to deal with.
  
  @alaa_wmde thoughts?
  basically when coming from storage, we want to allow deserialization and 
serialization.
  when coming from a user we want to disallow it.
  Then when we load such cases from storage to display to users in JSON we can 
just show them the JSON, and when displaying them the UI we can show them a 
page stating that this revision of the entity is invalid.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: alaa_wmde, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Lunewa, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Agabi10, Jonas, 
gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-08-08 Thread ArielGlenn

ArielGlenn added a comment.


  The python scripts at the dump end are (mostly) protected against exceptions 
from MediaWiki generally and from this failure case in particular. Since we 
have problematic data in production I've re-opened the ticket so that the 
WikiBase issue can somehow be resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, ArielGlenn
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Agabi10, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-08-08 Thread Addshore

Addshore added a comment.


  @ArielGlenn do I understand correctly however that this revision on 
wikidata.org is not an issue for dumps?
  
  We probably don't want to delete the revision from wikidata.org.
  A nice way to handle this in the UI might be to just accept the fact that the 
deserializes do not deserialize the revision and display the entity JSON 
instead.
  Alternatively we could poke the deserializers to allow redirecting to ones 
self, but really this should never have been possible, but maybe there is 
somewhere else we could put the check..

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Agabi10, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-06-05 Thread Krinkle

Krinkle added a comment.


  Still seen on 1.34-wmf.8.
  
  - XPam4gpAICsAAEeT0uER
  - GET testwikidatawiki /w/index.php?title=Q193394=no
  
  Fatal exception: `MWContentSerializationException from line 299 of 
/srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.`

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, darthmon_wmde, WDoranWMF, Premeditated, EvanProdromou, Nandana, 
Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Pchelolo, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-13 Thread ArielGlenn

ArielGlenn added a comment.


  I'm fine with that approach.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, darthmon_wmde, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-13 Thread Addshore

Addshore added a comment.


  As this is just test wiki (and not a real wiki), and that this can no longer 
occur, perhaps we should just totally nuke the page from the db

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, darthmon_wmde, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-06 Thread ArielGlenn

ArielGlenn added a comment.


  Fixed for dumps but not within MediaWiki, i.e. 
https://test.wikidata.org/w/index.php?title=Q193394=no  still gives an 
error. The bad entry needs to be removed or MW should do something nicer about 
such entries.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-05-06 Thread Krinkle

Krinkle added a comment.


  @ArielGlenn Is this resolved?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Agabi10, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-04-08 Thread gerritbot

gerritbot added a comment.


  Change 499402 **merged** by jenkins-bot:
  [mediawiki/core@master] redo: don't die producing xml files if rev text 
export conversion fails
  
  https://gerrit.wikimedia.org/r/499402

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Jonas, 
gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-04-08 Thread gerritbot

gerritbot added a comment.


  Change 499403 **merged** by jenkins-bot:
  [mediawiki/extensions/ActiveAbstract@master] don't die when revision 
serialization fails during link processing
  
  https://gerrit.wikimedia.org/r/499403

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Jonas, 
gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-04-01 Thread ArielGlenn

ArielGlenn added a comment.


  In T217329#5073668 , 
@daniel wrote:
  
  > By the way: //$entityId and $targetId can not be the same// is somewhat 
alarming. It indicates that an invalid entity redirect exists in the database 
of testwikidatawiki. I wonder how that happened.
  
  
  Someone entered it for testing, I imagine. But it cannot now be deleted. And 
in any case the code should be resilient against these sorts of errors.
  
  > If I understand correctly, the presence of these errors indicates invalid 
data in the database. This should not just be ignored. On the other hand, 
MediaWiki should not fatal out either. I suspect that the same error would not 
just occur while generating dumps, but also when trying to view the respective 
revision?
  
  It does; that's mentioned above (see Impact in the task description. But I 
don't want to try to fix MW generally. The dumps scripts should handle any 
errors thrown at them by MW core, and I'll be updating the patches accordingly, 
thanks for your comments.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: daniel, Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-04-01 Thread daniel

daniel added a comment.


  If I understand correctly, the presence of these errors indicates invalid 
data in the database. This should not just be ignored. On the other hand, 
MediaWiki should not fatal out either. I suspect that the same error would not 
just occur while generating dumps, but also when trying to view the respective 
revision?
  
  In general, exception handling should happen as close to the UI as possible. 
For bulk operations like dump generation, that is of course inconvenient, since 
it would abort the dump. Exceptions should be caught in a way that allows dump 
generation to proceed, but the exception should be reported to the user 
somehow, both on the CLI as well as on Special:Export.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-04-01 Thread daniel

daniel added a comment.


  By the way: //$entityId and $targetId can not be the same// is somewhat 
alarming. It indicates that an invalid entity redirect exists in the database 
of testwikidatawiki. I wonder how that happened.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-27 Thread ArielGlenn

ArielGlenn added a comment.


  I dislike both of the above patches and I don't have better ideas. I've run 
the abstracts job with these patches applied just to get the dump file produced 
for this run.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-27 Thread gerritbot

gerritbot added a comment.


  Change 499403 had a related patch set uploaded (by ArielGlenn; owner: 
ArielGlenn):
  [mediawiki/extensions/ActiveAbstract@master] don't die when revision 
serialization fails during link processing
  
  https://gerrit.wikimedia.org/r/499403

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-27 Thread gerritbot

gerritbot added a comment.


  Change 499402 had a related patch set uploaded (by ArielGlenn; owner: 
ArielGlenn):
  [mediawiki/core@master] redo: don't die producing xml files if rev text 
export conversion fails
  
  https://gerrit.wikimedia.org/r/499402

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-27 Thread ArielGlenn

ArielGlenn added a comment.


  Fixing me that gives me a failure later on:
  
2019-03-27 07:25:10: testwikidatawiki (ID 54422) 6 pages (32.9|363.6/sec 
all|curr), 7 revs (38.4|60.6/sec all|curr), ETA 2019-03-27 09:29:56 [max 287591]
[e1818746fd28c6a70c6cf5a5] [no req]   MWContentSerializationException from 
line 299 of 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.
Backtrace:
#0 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/Wikibase/repo/includes/Content/EntityHandler.php(383):
 Wikibase\Lib\Store\EntityContentDataCodec->decodeRedirect(string, NULL)
#1 
/srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/RevisionStore.php(1472): 
Wikibase\Repo\Content\EntityHandler->unserializeContent(string, NULL)
#2 
/srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/RevisionStore.php(1634): 
MediaWiki\Revision\RevisionStore->loadSlotContent(MediaWiki\Revision\SlotRecord,
 NULL, NULL, NULL, integer)
#3 [internal function]: 
MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}(MediaWiki\Revision\SlotRecord)
#4 /srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/SlotRecord.php(307): 
call_user_func(Closure, MediaWiki\Revision\SlotRecord)
#5 
/srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/RevisionRecord.php(175): 
MediaWiki\Revision\SlotRecord->getContent()
#6 /srv/mediawiki/php-1.33.0-wmf.23/includes/Revision.php(1086): 
MediaWiki\Revision\RevisionRecord->getContent(string)
#7 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ActiveAbstract/AbstractFilter.php(250):
 Revision::getRevisionText(stdClass)
#8 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/ActiveAbstract/AbstractFilter.php(129):
 AbstractFilter->sectionLinks(stdClass)
#9 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/DumpFilter.php(81): 
AbstractFilter->writeClosePage(string)
#10 
/srv/mediawiki/php-1.33.0-wmf.23/includes/export/ExportProgressFilter.php(39): 
DumpFilter->writeClosePage(string)
#11 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(480): 
ExportProgressFilter->writeClosePage(string)
#12 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(445): 
WikiExporter->outputPageStreamBatch(Wikimedia\Rdbms\ResultWrapper, stdClass)
#13 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(269): 
WikiExporter->dumpPages(string, boolean)
#14 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(154): 
WikiExporter->dumpFrom(string, boolean)
#15 
/srv/mediawiki/php-1.33.0-wmf.23/maintenance/includes/BackupDumper.php(288): 
WikiExporter->pagesByRange(integer, integer, boolean)
#16 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/dumpBackup.php(83): 
BackupDumper->dump(integer, integer)
#17 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/doMaintenance.php(94): 
DumpBackup->execute()
#18 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/dumpBackup.php(138): 
require_once(string)
#19 /srv/mediawiki/multiversion/MWScript.php(100): require_once(string)
#20 {main}

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-26 Thread ArielGlenn

ArielGlenn added a comment.


  And in fact that changeset 
(https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443608/)  did break this 
again at exactly the point I asked about above. The new stacktrace:
  
[0bda89b2b61b164a0232340b] [no req]   MWContentSerializationException from 
line 299 of 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.
Backtrace:
#0 
/srv/mediawiki/php-1.33.0-wmf.23/extensions/Wikibase/repo/includes/Content/EntityHandler.php(383):
 Wikibase\Lib\Store\EntityContentDataCodec->decodeRedirect(string, NULL)
#1 
/srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/RevisionStore.php(1472): 
Wikibase\Repo\Content\EntityHandler->unserializeContent(string, NULL)
#2 
/srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/RevisionStore.php(1634): 
MediaWiki\Revision\RevisionStore->loadSlotContent(MediaWiki\Revision\SlotRecord,
 NULL, NULL, NULL, integer)
#3 [internal function]: 
MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}(MediaWiki\Revision\SlotRecord)
#4 /srv/mediawiki/php-1.33.0-wmf.23/includes/Revision/SlotRecord.php(307): 
call_user_func(Closure, MediaWiki\Revision\SlotRecord)
#5 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/XmlDumpWriter.php(302): 
MediaWiki\Revision\SlotRecord->getContent()
#6 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(485): 
XmlDumpWriter->writeRevision(stdClass)
#7 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(445): 
WikiExporter->outputPageStreamBatch(Wikimedia\Rdbms\ResultWrapper, stdClass)
#8 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(269): 
WikiExporter->dumpPages(string, boolean)
#9 /srv/mediawiki/php-1.33.0-wmf.23/includes/export/WikiExporter.php(154): 
WikiExporter->dumpFrom(string, boolean)
#10 
/srv/mediawiki/php-1.33.0-wmf.23/maintenance/includes/BackupDumper.php(288): 
WikiExporter->pagesByRange(integer, integer, boolean)
#11 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/dumpBackup.php(83): 
BackupDumper->dump(integer, integer)
#12 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/doMaintenance.php(94): 
DumpBackup->execute()
#13 /srv/mediawiki/php-1.33.0-wmf.23/maintenance/dumpBackup.php(138): 
require_once(string)
#14 /srv/mediawiki/multiversion/MWScript.php(100): require_once(string)
#15 {main}
  
  I'll look at it tomorrow and put up a patch if someone else hasn't gotten to 
it by then.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-22 Thread ArielGlenn

ArielGlenn added a comment.


  Does XmlDumpWriter need a similar fix at a later stanza? Lines 298, 301 here: 
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443608/46/includes/export/XmlDumpWriter.php
 Do we have a wiki configured such that this code path can be tested with a 
broken revision?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-22 Thread gerritbot

gerritbot added a comment.


  Change 496348 **merged** by jenkins-bot:
  [mediawiki/core@master] don't die producing xml files if rev text export 
conversion fails
  
  https://gerrit.wikimedia.org/r/496348

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-19 Thread Krinkle

Krinkle added a comment.


  (//Still seen on 1.33-wmf.21.//)
  
[{exception_id}] {exception_url} MWContentSerializationException from line 
299 of 
/srv/mediawiki/php-1.33.0-wmf.21/extensions/Wikibase/lib/includes/Store/EntityContentDataCodec.php:
 $entityId and $targetId can not be the same.
  
  - Request ID: `25be09c77941a6bd1bdcdebd` (jobrunner)
  - Request ID (2): `XJFCTgpAADgAAD45lNcAAACT` (app server)

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-14 Thread ArielGlenn

ArielGlenn added a comment.


  I've run the abstracts job on testwikidatawiki with the patch deployed 
manually on one of the snapshot hosts, and it was successful.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-13 Thread gerritbot

gerritbot added a comment.


  Change 496348 had a related patch set uploaded (by ArielGlenn; owner: 
ArielGlenn):
  [mediawiki/core@master] don't die producing xml files if rev text export 
conversion fails
  
  https://gerrit.wikimedia.org/r/496348

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-13 Thread ArielGlenn

ArielGlenn added a comment.


  I'll need to catch this in XmlDumpWriter after all. Too bad. dumpTextPass 
already does the right thing, so we'll do that too.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-13 Thread ArielGlenn

ArielGlenn added a comment.


  No joy. It must be triggered somewhere else too; I've imported the bad rev in 
a (very) old  Wikidata installation and am now doing the update/upgrade dance 
so I can hack away at it locally.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, ArielGlenn, 
alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-12 Thread Addshore

Addshore added a comment.


  How is this looking @ArielGlenn ?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-05 Thread gerritbot

gerritbot added a comment.


  Change 494219 **merged** by jenkins-bot:
  [mediawiki/extensions/ActiveAbstract@master] when revision serialization 
fails, indicate the error in the xml
  
  https://gerrit.wikimedia.org/r/494219

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-04 Thread ArielGlenn

ArielGlenn added a comment.


  Is it possible that the current revision is serialized earlier when the page 
title is set up? I guess testing will show...

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, 
ArielGlenn, alaa_wmde, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Lunewa, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-04 Thread gerritbot

gerritbot added a comment.


  Change 494219 had a related patch set uploaded (by ArielGlenn; owner: 
ArielGlenn):
  [mediawiki/extensions/ActiveAbstract@master] when revision serialization 
fails, indicate the error in the xml
  
  https://gerrit.wikimedia.org/r/494219

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, 
ArielGlenn, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-04 Thread ArielGlenn

ArielGlenn added a comment.


  Perhaps there should be a maintenance script to delete such revisions; if we 
have them, other folks might have them also. I can see such a script getting 
the raw revision text for a specified id/batch of ids, checking that each one 
is a self-reference of that sort, and then deleting it without serialization, 
if there a code path which avoids that.
  
  As far as the dumps in general, they don't expand wikitext, except for the 
abstracts dumps. For that case, in AbstractFilter.php we can likely add 
something to writeClosePage which, if it encounters a fatal error of the 
MWContentSerializationException type, it could log the issue and do
  
$xml .= Xml::element( 'abstract', [ 'serialization-error' => '' ] ) . "\n";
  
  so that the script can continue on. Thoughts?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, ArielGlenn, 
alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-01 Thread Addshore

Addshore added a comment.


  We can probably catch the exception in EntityContentDataCodec::decodeRedirect 
and rethrow a MWContentSerializationException as is documented there.
  However im not sure if that will actually be handled further up the chain?
  EntityHandler::unserializeContent is documented as throwing a 
MWContentSerializationException but ContentHandler::unserializeContent is not.
  When we get to MWContentSerializationException though, perhaps this could be 
handled in WikiExporter for the dump?
  Not sure where exactly for the web request path though.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, 
Lahi, Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-01 Thread ArielGlenn

ArielGlenn added a comment.


  Groan can the error be handled differently then? I guess there's not much 
choice now...

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Addshore, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-03-01 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Well, it’s impossible to delete the page via the API, that just returns the 
same error. I suppose we //could// delete it from the database directly, but 
that’s a pretty extreme solution.

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, rosalieper, 
Jonas, gnosygnu, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Addshore, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-02-28 Thread ArielGlenn

ArielGlenn added a comment.


  If that sort of revision can't be created even by api, that's good enough for 
me. Someone on the MediaWiki side of things probably ought to weigh in on the 
case you mention above (fatal when viewing the deleted revision).

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-02-28 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  (Wikibase would still throw a fatal error if someone with appropriate 
privileges looked at the deleted revisions… not sure if that’s a big deal.)

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-02-28 Thread ArielGlenn

ArielGlenn added a comment.


  It shouldn't exist, but MediaWiki/Wikibase should not throw a fatal exception 
when handling it, either. Or is it now impossible for such revision text to be 
saved?

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2019-02-28 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  According to Quarry , Q193394 is the 
only self-redirecting item on test.wikidata.org, and there is no such item at 
all on www.wikidata.org. (Assuming my query is correct, of course.)
  
  Can we just delete the test.wikidata.org page? Such a redirect should not 
exist, and it is just a test wiki…

TASK DETAIL
  https://phabricator.wikimedia.org/T217329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, hashar, ArielGlenn, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Lunewa, QZanden, LawExplorer, _jensen, Jonas, gnosygnu, 
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

38 matches

Mail list logo