[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513250 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Tests: Reset PermissionManager 
service
  
  https://gerrit.wikimedia.org/r/513250

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: WDoranWMF, Tgr, nray, Umherirrender, Vedmaka, daniel, Krinkle, 
Liuxinyu970226, kostajh, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, EvanProdromou, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Cparle, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513268 **merged** by jenkins-bot:
  [mediawiki/core@master] Reset services after setting group permissions in 
tests
  
  https://gerrit.wikimedia.org/r/513268

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: WDoranWMF, Tgr, nray, Umherirrender, Vedmaka, daniel, Krinkle, 
Liuxinyu970226, kostajh, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, EvanProdromou, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Cparle, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[daniel]

daniel added a comment.


  @kostajh @WDoranWMF I'm here for another couple of hours today, and I'm also 
available on Monday. I think at least the first two patches can go in now:
  
  - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/513268
  - 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/513250
  
  With the extensions patched, it should also be fine now to re-apply the 
original change:
  
  - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/514474/3

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, daniel
Cc: WDoranWMF, Tgr, nray, Umherirrender, Vedmaka, daniel, Krinkle, 
Liuxinyu970226, kostajh, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, EvanProdromou, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Cparle, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[WDoranWMF]

WDoranWMF added a comment.


  @kostajh Thank you so much. I'll sync with @daniel and make sure we're able 
to.

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, WDoranWMF
Cc: WDoranWMF, Tgr, nray, Umherirrender, Vedmaka, daniel, Krinkle, 
Liuxinyu970226, kostajh, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, EvanProdromou, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Cparle, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[kostajh]

kostajh added a comment.


  @WDoranWMF I've reviewed and can merge it if someone from CPT would be around 
to handle any breakages in extensions (see this comment 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: WDoranWMF, Tgr, nray, Umherirrender, Vedmaka, daniel, Krinkle, 
Liuxinyu970226, kostajh, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, EvanProdromou, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Cparle, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, 
Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513197 **merged** by jenkins-bot:
  [mediawiki/extensions/CentralAuth@master] Override MediaWikiServices so tests 
can pass
  
  https://gerrit.wikimedia.org/r/513197

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: nray, Umherirrender, Vedmaka, daniel, Krinkle, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513248 **merged** by jenkins-bot:
  [mediawiki/extensions/MassMessage@master] Tests: Override MediaWiki Services
  
  https://gerrit.wikimedia.org/r/513248

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: nray, Umherirrender, Vedmaka, daniel, Krinkle, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[Vedmaka]

Vedmaka added a comment.


  In T224607#555 , 
@Umherirrender wrote:
  
  > MediaWikiTestCase::setGroupPermissions should override the services, not 
each extension calling that function or at least mention the fact, that it is 
needed.
  
  
  I believe there are a couple of issues with just adding services override 
into `MediaWikiTestCase::setGroupPermissions` :
  
  - In some cases groups permissions in tests being changed via globals - 
directly or via `setMwGlobals` calls and not via `setGroupPermissions`, for 
example:
- 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/509165/5/tests/phpunit/AbuseFilterTest.php#94
- 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/509619/7/repo/tests/phpunit/includes/Actions/EditEntityActionTest.php#922
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/509619
  - Some tests override services individually so `overrideMwServices` call is 
prohibited (at the moment). eg:
- 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/repo/tests/phpunit/includes/Api/WikibaseApiTestCase.php#34
  
  So it looks like we either need to change the logic around 
`overrideMwServices`/`setService` or we could try to reset `PermissionManger` 
only via `MediaWikiServices::resetServiceForTesting`, though this would solve 
only the second problem and not the first.

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, Vedmaka
Cc: nray, Umherirrender, Vedmaka, daniel, Krinkle, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513283 abandoned by Kosta Harlan:
  Add CentralAuth, MassMessage and WikibaseLexeme to gated extensions
  
  https://gerrit.wikimedia.org/r/513283

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: nray, Umherirrender, Vedmaka, daniel, Krinkle, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513283 had a related patch set uploaded (by Kosta Harlan; owner: Kosta 
Harlan):
  [integration/config@master] Add CentralAuth, MassMessage and WikibaseLexeme 
to gated extensions
  
  https://gerrit.wikimedia.org/r/513283

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513268 had a related patch set uploaded (by Daniel Kinzler; owner: 
Daniel Kinzler):
  [mediawiki/core@master] Reset services after setting group permissions in 
tests.
  
  https://gerrit.wikimedia.org/r/513268

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[daniel]

daniel added a comment.


  In T224607#555 , 
@Umherirrender wrote:
  
  > MediaWikiTestCase::setGroupPermissions should override the services, not 
each extension calling that function or at least mention the fact, that it is 
needed.
  
  
  Indeed. I'm making a patch.

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, daniel
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513250 had a related patch set uploaded (by Kosta Harlan; owner: Kosta 
Harlan):
  [mediawiki/extensions/WikibaseLexeme@master] Tests: Reset PermissionManager 
service
  
  https://gerrit.wikimedia.org/r/513250

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh, gerritbot
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513248 had a related patch set uploaded (by Kosta Harlan; owner: Kosta 
Harlan):
  [mediawiki/extensions/MassMessage@master] Tests: Override MediaWiki Services
  
  https://gerrit.wikimedia.org/r/513248

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[Umherirrender]

Umherirrender added a comment.


  MediaWikiTestCase::setGroupPermissions should override the services, not each 
extension calling that function

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[gerritbot]

gerritbot added a comment.


  Change 513197 had a related patch set uploaded (by Kosta Harlan; owner: Kosta 
Harlan):
  [mediawiki/extensions/CentralAuth@master] Override MediaWikiServices so tests 
can pass
  
  https://gerrit.wikimedia.org/r/513197

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
darthmon_wmde, Premeditated, DannyS712, Nandana, Mringgaard, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, 
Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[kostajh]

kostajh added a comment.


  @Umherirrender the Depends-On references in that patch contain the hints 
about what needs to happen. I'll submit a fix now for CentralAuth.

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
darthmon_wmde, Premeditated, DannyS712, Nandana, Mringgaard, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, 
Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[kostajh]

kostajh added a comment.


  > So we have unexpected permissions errors and a fresh merged patch set about 
permissions - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/502484/
  
  Yeah I was just looking at it. That's the problematic commit. One commit 
prior to that, and CentralAuth tests work.

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Umherirrender, Vedmaka, daniel, Krinkle, Sario528, Liuxinyu970226, kostajh, 
darthmon_wmde, Premeditated, DannyS712, Nandana, Mringgaard, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, 
Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[kostajh]

kostajh added a comment.


  > When was the last passing build for this repo in Gerrit?
  
  I believe it was this patch 
,
 see here: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/513022#message-23c59fbf073ad026b6d98c1fd892b1f40681b199
  
  We also had builds passing for backports to wmf.6 and wmf.7 today 
https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FGrowthExperiments

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Krinkle, Sario528, Liuxinyu970226, kostajh, darthmon_wmde, Premeditated, 
DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, Snowolf, aude, 
Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

[Krinkle]

Krinkle added a comment.


  @kostajh To confirm, the build is passing for core, CentralAuth, MassMessage 
and WikibaseLexeme. But the build is failing for commits to GrowthExperiments, 
for which these gates tests also run. Is that right?
  
  I don't see any changes in `core:/includes/api` last 24 hours that appear 
related to `apierror-writeapidenied`  or `CentralAuthIdLookupTest`.  Might be 
hard to find someone to start investigating without narrowing it down first.
  
  When was the last passing build for this repo in Gerrit?

TASK DETAIL
  https://phabricator.wikimedia.org/T224607

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Sario528, Liuxinyu970226, kostajh, darthmon_wmde, Premeditated, 
DannyS712, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, Snowolf, aude, 
Darkdadaah, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs