[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-07-30 Thread gerritbot 
gerritbot added a comment.


  Change 518256 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Update phan, cleanup config
  
  https://gerrit.wikimedia.org/r/518256

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
darthmon_wmde, Redabr4, Zanziii, Sadisticturd, DannyS712, Nandana, 
A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518236 **merged** by Jforrester:
  [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on 
WikibaseLexeme and make pass
  
  https://gerrit.wikimedia.org/r/518236

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518249 abandoned by Jforrester:
  Temporarily suppress phan checks to unbreak build.
  
  Reason:
  Squashed into parent.
  
  https://gerrit.wikimedia.org/r/518249

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde 
alaa_wmde added a comment.


  > Ah, I haven't been clear. Extensions *should* override the default config, 
e.g. to define additional dependencies (many extensions do that). But it's 
vital that the default config is first included, then overridden for the 
necessary part. What happened for Lexeme (and WB itself) is that the default 
config has just been copypasted. And you'll probably agree that copypastas are 
always very bad for maintainability in the long term.
  
  Ah I see .. I might have also read through your comment too quickly .. thanks 
for the second clarification.
  
  > Definitely, I implicitly meant that.
  
  Awesome! thanks for taking care of the clean-up too :)

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona 
Daimona added a comment.


  In T226244#5273866 , 
@alaa_wmde wrote:
  
  > @Daimona understood. I also think the clean-up work is necessary. I'm not 
such a fan of statements of the sort "extensions must use mediawiki config 
rather than overriding/changing them" but that's a separate topic anyway.
  
  
  Ah, I haven't been clear. Extensions *should* override the default config, 
e.g. to define additional dependencies (many extensions do that). But it's 
vital that the default config is first included, then overridden for the 
necessary part. What happened for Lexeme (and WB itself) is that the default 
config has just been copypasted. And you'll probably agree that copypastas are 
always very bad for maintainability in the long term.
  
  > I would actually like to merge my patch first to fix the build first.. your 
patch can then rebase on it. Is that fine by you?
  
  Definitely, I implicitly meant that.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde 
alaa_wmde added a comment.


  @Daimona understood. I also think the clean-up work is necessary. I'm not 
such a fan of statements of the sort "extensions must use mediawiki config 
rather than overriding/changing them" but that's a separate topic anyway.
  
  > At this point, I'd like to fix all issues reported for my patch, but that 
could take some time. And at the end, the same config change will have to be 
applied to Wikibase itself.
  
  I would actually like to merge my patch first to fix the build first.. your 
patch can then rebase on it. Is that fine by you?

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona 
Daimona added a comment.


  In T226244#5273853 , 
@alaa_wmde wrote:
  
  > In T226244#5273849 , 
@gerritbot wrote:
  >
  > > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  > >  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup 
config
  > >
  > > https://gerrit.wikimedia.org/r/518256
  >
  >
  > @Daimona think you are trying to achieve the same effect I did with 
https://gerrit.wikimedia.org/r/518249 
(https://phabricator.wikimedia.org/T226244#5273778).
  >
  > Though I wouldn't add an explicit dependency here on Wikibase phan config. 
Lexeme and Wikibase can have different configurations in the long run. What do 
you think?
  
  
  @alaa_wmde Actually, not really. With the phan dependency in composer, we can 
use the standard MediaWiki config (source 
), which is what all 
extensions should do. For some reason, Wikibase redeclares its own config, so 
that it'll inevitably drift from the default. My change introduces a dependency 
on the standard config, not the Wikibase one, so this is the right way to go :-)
  I also tried to *remove* all suppressions to see what's really left to fix. 
The first thing I noticed is that all "A inherits B which is declared at X and 
also at Y" warnings have gone, and that was due to misconfiguration including 
Wikibase twice, probably.
  Now it complains about some methods not being declared (instead of being 
declared twice, eheh), but that's probably something we can fix via config. 
You'll also notice many warnings like "...can usually be simplified to...". 
They come from a phan plugin which is included in the standard config, but not 
in Wikibase - that's what I meant with "it'll inevitably drift from the 
default".
  
  At this point, I'd like to fix all issues reported for my patch, but that 
could take some time. And at the end, the same config change will have to be 
applied to Wikibase itself.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde 
alaa_wmde added a comment.


  In T226244#5273849 , 
@gerritbot wrote:
  
  > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  >  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup 
config
  >
  > https://gerrit.wikimedia.org/r/518256
  
  
  @Daimona think you are trying to achieve the same effect I did with 
https://gerrit.wikimedia.org/r/518249 
(https://phabricator.wikimedia.org/T226244#5273778).
  
  Though I wouldn't add an explicit dependency here on Wikibase phan config. 
Lexeme and Wikibase can have different configurations in the long run. What do 
you think?

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup config
  
  https://gerrit.wikimedia.org/r/518256

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518249 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa 
Sarhan):
  [mediawiki/extensions/WikibaseLexeme@master] Temporarily suppress phan checks 
to unbreak build.
  
  https://gerrit.wikimedia.org/r/518249

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde 
alaa_wmde added a comment.


  Another possible source?
  WikibaseLexeme `.phan/config.php` looks different from Wikibase one.
  
  For example, one reported error on Lexeme build:
  
12:37:08   
12:37:08 
12:37:08   
  
  Looking in Lexemes phan config, `PhanUnreferencedUseNormal` is not configured 
to be ignored, while it is configured to be ignored in Wikibase 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/.phan/config.php#371
  
  So ignoring those checks for now in Lexeme phan config should as well be 
enough until we enable them again later and fix one by one

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona 
Daimona added a comment.


  @noarave It actually did. It's just that phan completed its analysis and 
found several errors. Of note, you should also add a phan config file - I can 
amend your patch, although I don't know if I'll have time to fix all the errors.
  @hashar Actually, it's not Lexeme. It's the phan runner, specifically this 
line 

 which chooses 0.8.0 as fallback if it cannot find phan in the composer. So 
basically, this issue also affects any repo where no phan version is specified. 
Changing the fallback option to phan 1.3.4 could solve it - unless it creates 
more troubles.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread hashar 
hashar added a comment.


  That did cause the container to trigger the installation of phan 1.3.4 
instead of the outdated 0.8.0 fallback.
  
  
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/518236/
 now fails because of new Phan reported errors. I guess the easiest is to just 
suppress them using `@suppress` comment:
  https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#suppress
  
  I guess we have missed WikibaseLexeme was still using 0.8.0 :-\

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread noarave 
noarave added a comment.


  @Daimona unfortunately requiring phan config 0.6.1 in composer.json did not 
seem to have an effect.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 518236 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
  [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on 
WikibaseLexeme
  
  https://gerrit.wikimedia.org/r/518236

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona 
Daimona added a comment.


  AIUI, only the last mentioned patch is culprit. The dependency on Wikibase 
should only be used to tell what MW extensions to install before testing 
Lexeme, but that shouldn't be related to the phan version to use. What 
happened, instead, is that IMHO phan72 jobs were made live too early. 
Currently, the phan runner still supports phan 0.8.0, which in turn can only 
run on PHP70. Lexeme doesn't specify a phan version to run, and for some reason 
the 0.8.0 version is picked.
  I think some solutions could be to:
  
  1. Explicitly require phan config 0.6.1 in Lexeme's composer.json
  2. Make the phan72 job install a recent version of phan (not 0.8.0)
  
  CC @Jdforrester-WMF

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs