subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T229280\: Wikibase\\DataModel\\Services\\Lookup\\EntityLookupException\: Call to a member function getTargetId\(\) on a non\-object \(null\)"

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-11-04 Thread gerritbot

gerritbot added a comment.


  Change 543872 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Added Entity Revision Lookup 
that can handle inconsistent redirects on file pages
  
  https://gerrit.wikimedia.org/r/543872

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: LarsWirzenius, Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, 
Pablo-WMDE, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, 
brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-29 Thread gerritbot

gerritbot added a comment.


  Change 545297 abandoned by Addshore:
  Added dedicated exception to distinct issue when revision is inconsistently 
marked as redirect
  
  Reason:
  not going to backport now
  
  https://gerrit.wikimedia.org/r/545297

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: LarsWirzenius, Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, 
Pablo-WMDE, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, 
brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-29 Thread gerritbot

gerritbot added a comment.


  Change 545301 abandoned by Addshore:
  Extracted logic of load "entity data" from wiki page to own class
  
  Reason:
  not going to backport now
  
  https://gerrit.wikimedia.org/r/545301

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: LarsWirzenius, Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, 
Pablo-WMDE, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, 
brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-29 Thread Addshore

Addshore added a comment.


  I see some patches on the branch, I guess the plan is backport these, but I 
don't see anything scheduled yet.
  Will check in our daily which is in just over 1 hour.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: LarsWirzenius, Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, 
Pablo-WMDE, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, 
brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-22 Thread gerritbot

gerritbot added a comment.


  Change 545301 had a related patch set uploaded (by Alaa Sarhan; owner: 
WMDE-leszek):
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.3] Extracted logic of load 
"entity data" from wiki page to own class
  
  https://gerrit.wikimedia.org/r/545301

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-22 Thread gerritbot

gerritbot added a comment.


  Change 545297 had a related patch set uploaded (by Alaa Sarhan; owner: 
WMDE-leszek):
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.3] Added dedicated exception to 
distinct issue when revision is inconsistently marked as redirect
  
  https://gerrit.wikimedia.org/r/545297

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-22 Thread gerritbot

gerritbot added a comment.


  Change 543868 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Extracted logic of load "entity data" 
from wiki page to own class
  
  https://gerrit.wikimedia.org/r/543868

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-22 Thread gerritbot

gerritbot added a comment.


  Change 543860 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Added dedicated exception to distinct 
issue when revision is inconsistently marked as redirect
  
  https://gerrit.wikimedia.org/r/543860

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-21 Thread Mholloway

Mholloway added a comment.


  I abandoned my patch in favor of those from @WMDE-leszek, which look good to 
me.  I'll add my +1s but I think it's probably more appropriate for full-time 
Wikibase and WikibaseMediaInfo devs to merge.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-21 Thread gerritbot

gerritbot added a comment.


  Change 534536 abandoned by Mholloway:
  Allow for entity content existing on redirect pages
  
  Reason:
  Abandoning in favor of Leszek's more thought-out approach (see 
https://gerrit.wikimedia.org/r/#/q/topic:mediainfo-redirect-kaboom)
  
  https://gerrit.wikimedia.org/r/534536

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-17 Thread WMDE-leszek

WMDE-leszek added a comment.


  I've drafted out the version of https://gerrit.wikimedia.org/r/534536 which I 
like better as https://gerrit.wikimedia.org/r/543872 and 
https://gerrit.wikimedia.org/r/543868.
  These patches are not fully ready yet (as this was draft, I did pretty sloppy 
work in the test department), but should be rather easy to get to mergeable 
state.
  I intended to create a nice regression test for the issue visible to users, 
but failed badly (reason for the delay). I wholeheartedly invite others to give 
it a try!

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-17 Thread gerritbot

gerritbot added a comment.


  Change 543872 had a related patch set uploaded (by WMDE-leszek; owner: 
WMDE-leszek):
  [mediawiki/extensions/WikibaseMediaInfo@master] Added Entity Revision Lookup 
that can handle inconsistent redirects on file pages
  
  https://gerrit.wikimedia.org/r/543872

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-17 Thread gerritbot

gerritbot added a comment.


  Change 543868 had a related patch set uploaded (by WMDE-leszek; owner: 
WMDE-leszek):
  [mediawiki/extensions/Wikibase@master] Extracted logic of load "entity data" 
from wiki page to own class
  
  https://gerrit.wikimedia.org/r/543868

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-17 Thread gerritbot

gerritbot added a comment.


  Change 543860 had a related patch set uploaded (by WMDE-leszek; owner: 
WMDE-leszek):
  [mediawiki/extensions/Wikibase@master] Added dedicated exception to distinct 
issue when revision is inconsistently marked as redirect
  
  https://gerrit.wikimedia.org/r/543860

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-17 Thread Tarrow

Tarrow added a comment.


  I checked in the Wikidata team what the status was and we hope to have some 
additional code for review soon (hopefully today). Sorry about the delay.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Tarrow, Addshore, egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, 
zeljkofilipin, Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, 
Aklapper, brennen, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
Iflorez, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-07 Thread WMDE-leszek

WMDE-leszek added a comment.


  We'll provide some (hopefully  helpful) input for SDC folks in the next 24 
hours or so

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-10-07 Thread Krinkle

Krinkle added a comment.


  @Cparle @Mholloway Looks like next step is CR for 
https://gerrit.wikimedia.org/r/534536. Is this something SDC can/should review 
internally, or is it blocked on WMDE? Looks like the expectation was for SDC to 
review internally but delayed due to offsites. Perhaps WMDE can help?
  
  These production URLs have been fatal for over 2 months. Would be good to see 
this resolved soon one way or another – both as user, and as Logstash crawler. 
Thanks :)

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, 
darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, 
NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-30 Thread Krinkle

Krinkle added a comment.


  Still reproducible at the example URL as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-23 Thread zeljkofilipin

zeljkofilipin added a comment.


  Looks like it's still in wmf.23.
  
[XYi8uQpAAEYAAFwX@0kAAABW] 
/w/index.php?title=File:Buddha_with_Naga_(snake).jpg&redirect=no   
Wikibase\DataModel\Services\Lookup\EntityLookupException from line 82 of 
/srv/mediawiki/php-1.34.0-wmf.23/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php:
 Call to a member function getTargetId() on a non-object (null)

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-23 Thread Cparle

Cparle added a comment.


  Pinging @brennen again to see if our fix for T231276 
 has indeed fixed this (if it has we 
can abandon the other patch @WMDE-leszek )

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-23 Thread WMDE-leszek

WMDE-leszek added a comment.


  @Cparle @Mholloway while the review of https://gerrit.wikimedia.org/r/534536 
is still to happen/on-going, I am wondering about the priority of this task. 
It's been an Unbreak Now! task for 2+ weeks, if WMDE is blocking resolution of 
such an important issue, we probably should stop doing so rather quick.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-09 Thread Mholloway

Mholloway added a comment.


  Update: https://commons.wikimedia.org/wiki/File:Susana_Pavon_Instagram.jpg 
and https://commons.wikimedia.org/wiki/File:Rockstar_San_Diego_Logo.svg.png / 
https://commons.wikimedia.org/w/index.php?title=File:Rockstar_San_Diego_Logo.svg.png&redirect=no
  are fixed (by https://gerrit.wikimedia.org/r/534854, presumably), but 
https://commons.wikimedia.org/w/index.php?title=File:Buddha_with_Naga_(snake).jpg&redirect=no
 still throws.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-05 Thread Mholloway

Mholloway added a comment.


  Yeah, this is something of a stopgap.  I think part of the issue here is that 
just creating a redirect to the file page of a duplicate file seems like the 
wrong thing to do on an editor's part, though I'd need to check on-wiki for 
what it has to say about this.
  
  There is the capability to delete a file and its page on grounds that it's a 
duplicate (though only admins and the like have this right), which seems like 
what should have happened here, but it doesn't appear to do any reconciliation 
of content.  It would be good if Commons had something like Phabricator's 
"close as duplicate" functionality that would at least attempt to merge the 
mediainfo content for the two.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-05 Thread Cparle

Cparle added a comment.


  This approach means that if you have MediaInfo content in a slot on the page, 
and someone edits the wikitext to make the page into a redirect, then the 
MediaInfo content becomes inaccessible.
  
  Is this what we want?
  
  The only alternative I can think of off the top of my head would be to 
prevent a redirect if there was a MediaInfo slot on a page, not sure if this is 
actually possible though

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread Mholloway

Mholloway added a comment.


  Propsed a possible fix, but needs review by someone with deeper Wikibase 
knowledge than I have in case there are negative implications I'm not seeing.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
Edtadros, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread gerritbot

gerritbot added a comment.


  Change 534536 had a related patch set uploaded (by Mholloway; owner: Michael 
Holloway):
  [mediawiki/extensions/Wikibase@master] Allow for entity content existing on 
redirect pages
  
  https://gerrit.wikimedia.org/r/534536

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread Mholloway

Mholloway added a comment.


  This can be reproduced locally by uploading a file, adding mediainfo content, 
then editing the page wikitext to hand-create a redirect (e.g., change the page 
content to `#REDIRECT [[File:Foo.jpg]]`).

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread Mholloway

Mholloway added a comment.


  From the various reports it sounds like there are a couple of 
probably-related errors here, but I think this is the code path at least one of 
them.  TL;DR There seems to be an expectation of some bookkeeping happening in 
the entity content when a related page becomes a redirect page, and that isn't 
actually happening, which breaks subsequent assumptions.
  
  File:Rockstar_San_Diego_Logo.svg.png 
 has 
page ID 76630136.
  
  RevisionBasedEntityLookup::hasEntity() calls getLatestRevisionId() on its 
member EntityRevisionLookup, which is a WikiPageEntityRevisionLookup.  
WikiPageEntityRevisionLookup loads page and revision info from the DB, and sees 
that the associated page is a redirect page:
  
mysql:research@dbstore1004.eqiad.wmnet [commonswiki]> select 
page_is_redirect from page where page_id = 76630136;
+--+
| page_is_redirect |
+--+
|1 |
+--+
1 row in set (0.00 sec)
  
  Seeing that the page is a redirect, it attempts to load an EntityRedirect 
object in its private loadEntity method, but instead finds a still-existing, 
valid MediaInfo entity:
  
>>> $slot = 
MediaWiki\MediaWikiServices::getInstance()->getRevisionStore()->getRevisionByTitle(
 Title::newFromText( 'File:Rockstar_San_Diego_Logo.svg.png' ) )->getSlot( 
'mediainfo' );
=> MediaWiki\Revision\SlotRecord {#1459}
>>> $blob = 
Mediawiki\MediawikiServices::getInstance()->getBlobStore()->getBlob( 
$slot->getAddress() );
=> 
"{"type":"mediainfo","id":"M76630136","labels":{"ja":{"language":"ja","value":"\u30ed\u30b4"}},"descriptions":[],"statements":[]}"
>>> $entity = 
Wikibase\Repo\WikibaseRepo::getDefaultInstance()->getEntityContentDataCodec()->decodeEntity(
 $blob, $slot->getFormat() );
=> Wikibase\MediaInfo\DataModel\MediaInfo {#6194}
  
  So it returns that and a null EntityRedirect instead of the EntityRedirect 
that the calling was expecting, and then errors out when calling getTargetId() 
on the null EntityRevision.
  
  From looking at the decodeEntity and decodeRedirect methods of 
EntityContentDataCodec, It looks like the expectation is that the entity 
content would have a `redirect` key, causing decodeEntity to return null and 
signal to the caller to attempt to decode the content as a redirect, but we as 
we can see from the content blob, there is no `redirect` key present:
  
=> 
"{"type":"mediainfo","id":"M76630136","labels":{"ja":{"language":"ja","value":"\u30ed\u30b4"}},"descriptions":[],"statements":[]}"

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread Cparle

Cparle added a comment.


  @alaa_wmde I'll take a look tomorrow

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread egardner

egardner added a comment.


  @alaa_wmde I'm not working actively on this at the moment, so I've 
un-assigned myself.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner
Cc: egardner, Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, 
Mholloway, alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, 
darthmon_wmde, Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-09-04 Thread alaa_wmde

alaa_wmde added a comment.


  @egardner let's know whether you find something new, esp. regarding the 
redirect bit to it.. or if you are not working on it actively at the moment, so 
that we switch to it.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner, alaa_wmde
Cc: Cparle, Krinkle, Liuxinyu970226, Pablo-WMDE, zeljkofilipin, Mholloway, 
alaa_wmde, WMDE-leszek, Ramsey-WMF, Michael, Aklapper, brennen, darthmon_wmde, 
Edtadros, DannyS712, Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-08-06 Thread egardner

egardner added a comment.


  I'm still trying to follow the exact code-path here. This is what I can say 
after digging around so far:
  
  Wikibase has a hook method called 
`onSkinTemplateBuildNavUrlsNavUrlsAfterPermalink` that is defined in 
Wikibase/repo/RepoHooks.php. I think that this method was originally written to 
support some kind of Wikibase-specific Entity page; the comments here mention 
that the method "allows us to set up navigation URLs to later be used in the 
toolbox."
  
  It looks like this hook method also gets called on regular File pages when 
the MediaInfo extension is enabled, presumably because entity lookup is 
happening on those pages now.
  
  I have not been able to reproduce this error locally yet. On a normal File 
page (whether or not Structured Data is already present), this method will be 
called and the appropriate MediaInfo entity ("M-item") will be looked up. Since 
our file already has an EntityId (even if no structured data is present yet), 
the method runs to completion and some navigation URLs are set up. I don't 
think these are actually used anywhere in the File page.
  
  The method is also called when a user navigates to the page of a 
recently-deleted file (which I think is part of what was happening here). I 
deleted a file locally and stepped through the code again in a debugger in an 
attempt to reproduce this error. 
`onSkinTemplateBuildNavUrlsNavUrlsAfterPermalink` gets called as before, but 
now the EntityId is null. This causes the method to return early and no errors 
get thrown.
  
  The "path not taken" in this case might be the one that led to the error in 
question. `onSkinTemplateBuildNavUrlsNavUrlsAfterPermalink` contains a guard 
clause that looks like this:
  
$entityId = $entityIdLookup->getEntityIdForTitle( $title );
if ( $entityId === null || !$entityLookup->hasEntity( $entityId ) ) {
return;
}
  
  When I walked through the code on a recently-deleted File page, I hit the 
first condition here, since the `$entityId` of the page in question was equal 
to `null`.
  
  It looks like the second condition is the source of the error. Somehow, the 
`$entityId` is non-null but the attempt to actually look it up throws an error.
  
  Could this be caused by some kind of caching issue, maybe? A file has been 
deleted, but the file page remains accessible to some users with stale caches? 
Perhaps calls to `getEntityIdForTitle` for those users are still returning an 
ID, but attempts to access more information are blowing up because the actual 
entity the ID used to correspond to has been deleted?

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner
Cc: Ramsey-WMF, Michael, Aklapper, brennen, darthmon_wmde, Edtadros, DannyS712, 
Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-08-06 Thread egardner

egardner added a comment.


  Timebox of "today" at any rate. I'll post updates based on what I can 
discover.

TASK DETAIL
  https://phabricator.wikimedia.org/T229280

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner
Cc: Ramsey-WMF, Michael, Aklapper, brennen, darthmon_wmde, DannyS712, Nandana, 
JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

[Wikidata-bugs] [Maniphest] [Commented On] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

33 matches

Site Navigation

Mail list logo

Footer information