subject:"\[Wikidata\-bugs\] \[Maniphest\] \[Commented On\] T231276\: RevisionBasedEntityLookup.php\: Revision 363395998 belongs to M77688146 instead of expected M81625979"

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-10 Thread hashar

hashar added a comment.


  It is definitely gone. Thank you very much!

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle, hashar
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, B20180, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-10 Thread Yann

Yann added a comment.


  
https://commons.wikimedia.org/wiki/File:%E0%A4%B6%E0%A4%BF%E0%A4%B2%E0%A5%8D%E0%A4%AA%E0%A4%95%E0%A4%BE%E0%A4%B0_%E0%A4%9A%E0%A4%B0%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%B0%E0%A4%95%E0%A5%8B%E0%A4%B6_%E0%A4%96%E0%A4%82%E0%A4%A1_%E0%A5%A8_%E2%80%93_%E0%A4%B8%E0%A4%BE%E0%A4%B9%E0%A4%BF%E0%A4%A4%E0%A5%8D%E0%A4%AF.pdf
 is also OK.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Yann
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, B20180, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-10 Thread zeljkofilipin

zeljkofilipin added a comment.


  - The file that caused the error now opens fine: 
https://commons.wikimedia.org/wiki/File:Bolsonaro_with_Israeli_PM_Benjamin_Netanyahu,_Tel_Aviv,_31_March_2019.jpg
  - The last occurence of `Revision 363605807 belongs to M77688146 instead of 
expected M81625979` in the logs seems to be 2019-09-09T12:44:50
  
  If you think the problem is fixed, feel free to resolve the task.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, B20180, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-09 Thread Cparle

Cparle added a comment.


  So ... @zeljkofilipin can we close this now?

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-09 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-09-09T12:55:19Z] 
 Synchronized 
php-1.34.0-wmf.21/extensions/WikibaseMediaInfo/: ubn patch T231276 
 (duration: 00m 58s)

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-09 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-09-09T12:51:33Z] 
 Synchronized php-1.34.0-wmf.21/extensions/Wikibase: ubn 
patch T231276  (duration: 01m 03s)

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-09 Thread gerritbot

gerritbot added a comment.


  Change 534853 **merged** by Urbanecm:
  [mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.21] EntityRevisionLookup: 
specific exception for entity id mismatch
  
  https://gerrit.wikimedia.org/r/534853

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-09 Thread gerritbot

gerritbot added a comment.


  Change 534854 **merged** by Urbanecm:
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.21] Entity lookup: 
mend old ids when loading
  
  https://gerrit.wikimedia.org/r/534854

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-08 Thread gerritbot

gerritbot added a comment.


  Change 533907 abandoned by Urbanecm:
  [stopgap] Don't throw an exception on unexpected difference between M* ids
  
  Reason:
  other patch was proposed
  
  https://gerrit.wikimedia.org/r/533907

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-06 Thread Jdforrester-WMF

Jdforrester-WMF added a comment.


  Cherry-picked because this is 97% of all fatals in production. I appreciate 
that this is a bandage and not a fix.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, 
WMDE-leszek, Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-06 Thread gerritbot

gerritbot added a comment.


  Change 534854 had a related patch set uploaded (by Jforrester; owner: Pablo 
Grass (WMDE)):
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.21] Entity lookup: 
mend old ids when loading
  
  https://gerrit.wikimedia.org/r/534854

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-06 Thread gerritbot

gerritbot added a comment.


  Change 534853 had a related patch set uploaded (by Jforrester; owner: Pablo 
Grass (WMDE)):
  [mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.21] EntityRevisionLookup: 
specific exception for entity id mismatch
  
  https://gerrit.wikimedia.org/r/534853

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-05 Thread gerritbot

gerritbot added a comment.


  Change 534218 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Entity lookup: mend old ids 
when loading
  
  https://gerrit.wikimedia.org/r/534218

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-05 Thread gerritbot

gerritbot added a comment.


  Change 534216 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] EntityRevisionLookup: specific 
exception for entity id mismatch
  
  https://gerrit.wikimedia.org/r/534216

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-04 Thread gerritbot

gerritbot added a comment.


  Change 534216 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [mediawiki/extensions/Wikibase@master] EntityRevisionLookup: specific 
exception for entity id mismatch
  
  https://gerrit.wikimedia.org/r/534216

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread gerritbot

gerritbot added a comment.


  Change 534218 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [mediawiki/extensions/WikibaseMediaInfo@master] Entity lookup: mend old ids 
when loading
  
  https://gerrit.wikimedia.org/r/534218

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Urbanecm

Urbanecm added a comment.


  In T231276#5458915 , 
@Cparle wrote:
  
  > @Urbanecm the patch prevents the fatal error, but there are other errors 
if, for example, a user tries to edit a caption.
  
  That's the intention. I want to have it deployed soon-ish, to avoid fatals on 
viewing. More noticeable than exceptions on editing. Then we/you can work on 
how to fix the core issue later.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Urbanecm

Urbanecm added a comment.


  In T231276#5461117 , 
@zeljkofilipin wrote:
  
  > Lowered priority since it's not blocking the train any more.
  
  I raised the priority intentionally above, see history.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE

Pablo-WMDE added a comment.


  Just realized this affects the API, when searching via title, as well. e.g.
  
  
https://commons.wikimedia.org/w/api.php?action=wbgetentities&titles=File:Bolsonaro_with_Israeli_PM_Benjamin_Netanyahu,_Tel_Aviv,_31_March_2019.jpg&sites=commonswiki
  
{
"error": {
"code": 
"internal_api_error_Wikibase\\Lib\\Store\\BadRevisionException",
"info": "[XW6FvQpAMEYAACeJrDQAAABG] Caught exception of type 
Wikibase\\Lib\\Store\\BadRevisionException",
"errorclass": "Wikibase\\Lib\\Store\\BadRevisionException"
},
"servedby": "mw1235"
}

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Cparle

Cparle added a comment.


  @Pablo-WMDE if you change your mind let me know, and I'll fix up the broken 
unit tests

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Cparle

Cparle added a comment.


  Cool, sounds good to me

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Pablo-WMDE

Pablo-WMDE added a comment.


  @Cparle
  
  > AFAICS the introduction of EntityLookup::getEntity() has revealed a problem 
rather than causing one. The problem is that MediaInfo ids for a slot on a page 
are based on the id of the page,
  
  Well put, no discussion on that.
  
  > IMO @Urbanecm 's patch is fine [...] The MediaInfo *data* will still be 
found by getEntity() call
  
  The patch is one to wikibase, affects all entity types, and removes an 
exception that prevented the storage layer of handing out an `EntityRevision` 
for an entity which does not match the question it was asked for. As a 
consequence we find the consequences of the change to be quite profound 
compared to expected gain.
  We would prefer a patch, and are also looking into that question, which 
enables users to "at least view the page" while keeping the stopgap closer to 
the culprit.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Cparle

Cparle added a comment.


  @Pablo-WMDE this bit of code in WikibaseMediaInfoHooks.php is what triggers 
the error:
  
$entityId = $this->entityIdFromPageId( $pageId );

$wbRepo = WikibaseRepo::getDefaultInstance();
$entityLookup = $wbRepo->getEntityLookup();
$entity = $entityLookup->getEntity( $entityId );
  
  If, for example, I have a page with id 1234 then data for the MediaInfo slot 
on that page is stored as a json blob, and the json will include the field 
`"id": "M1234"`. If then the page id subsequently changes to 1235 the json blob 
isn't updated. The MediaInfo *data* will still be found by `getEntity()` call 
(because the sql used to find it is generated with the condition `'page_id' => 
$entityId->getNumericId()` (see MediaInfoEntityQuery.php::selectRows()), but 
the ids don't match, hence the exception

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-03 Thread Cparle

Cparle added a comment.


  The hook approach doesn't work for MediaInfo, becase the hook doesn't fire if 
a MediaInfo item doesn't exist for a File page - which it doesn't if no 
structured data has been added to the page
  
  AFAICS the introduction of `EntityLookup::getEntity()` has revealed a problem 
rather than causing one. The problem is that MediaInfo ids for a slot on a page 
are based on the id of the page, and if the page id changes so does the 
MediaInfo id
  
  IMO @Urbanecm 's patch is fine (providing I can fix the unit tests) for now, 
but we need to think about the hard-coding of the relationship between page id 
and MediaInfo id

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Urbanecm

Urbanecm added a comment.


  Thanks, running submodule update and composer install.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Pablo-WMDE

Pablo-WMDE added a comment.


  @Urbanecm `ItemId` is a class implemented in the dedicated data-model 
repository - make sure you have wikibase installed 
 correctly (composer, 
submodules).

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Urbanecm

Urbanecm added a comment.


  Patch works per @Cparle. I can't test locally due to probably unrelated error:
  
[dd239c1581da0431f6fd1e17] /wiki/Special:Version Error from line 35 of 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/lib/WikibaseLib.entitytypes.php:
 Class 'Wikibase\DataModel\Entity\ItemId' not found

Backtrace:

#0 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/repo/includes/WikibaseRepo.php(791):
 require()
#1 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/repo/includes/WikibaseRepo.php(406):
 Wikibase\Repo\WikibaseRepo::getDefaultEntityTypes()
#2 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/repo/includes/WikibaseRepo.php(563):
 Wikibase\Repo\WikibaseRepo::newInstance()
#3 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/extensions/Wikibase/repo/RepoHooks.php(104):
 Wikibase\Repo\WikibaseRepo::getDefaultInstance()
#4 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/core/includes/Hooks.php(174): 
Wikibase\RepoHooks::onSetupAfterCache()
#5 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/core/includes/Hooks.php(202): 
Hooks::callHook(string, array, array, NULL)
#6 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/core/includes/Setup.php(794): 
Hooks::run(string)
#7 
/mnt/c/Users/urban/unsynced/gerrit/mediawiki/core/includes/WebStart.php(81): 
require_once(string)
#8 /mnt/c/Users/urban/unsynced/gerrit/mediawiki/core/index.php(39): 
require(string)
#9 {main}

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Urbanecm

Urbanecm added a comment.


  Thanks @Cparle and @daniel. Fixed my patch. I felt something like that can be 
necessary, but don't have enough Wikibase knowledge to fully judge. Since I had 
about 10 spare mins when I thought about writing something to start the work to 
limit this bug's scope (speaking of user-visibility), I relied at 
jenkins/reviewers to help me in that area. Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread daniel

daniel added a comment.


  In T231276#5458962 , 
@Cparle wrote:
  
  >> The new "actual" ID needs to be forced into the Entity data, I commented 
on the patch to that effect.
  >
  > On @Urbanecm 's patch 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/533907 ? I 
don't see a comment (scratches head)
  
  Of course, I forgot to hit the big blue button...

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Cparle

Cparle added a comment.


  > The new "actual" ID needs to be forced into the Entity data, I commented on 
the patch to that effect.
  
  On @Urbanecm 's patch 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/533907 ? I 
don't see a comment (scratches head)

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Cparle

Cparle added a comment.


  > Maybe it's broken somehow, and every undelete changes the page ID again? 
Needs investigation, because if that was true, it would greatly aggravate the 
effect of the MediaInfoID problem.
  
  I don't think so - at least locally a delete/restore doesn't change the page 
ID. Obvs it does happen sometimes on production, but I don't know how

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread daniel

daniel added a comment.


  In T231276#5458915 , 
@Cparle wrote:
  
  > @Urbanecm the patch prevents the fatal error, but there are other errors 
if, for example, a user tries to edit a caption.
  
  The new "actual" ID needs to be forced into the Entity data, I commented on 
the patch to that effect.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread daniel

daniel added a comment.


  >> However, this doesn't solve the conceptual problem of breaking all 
existing references to the old entity ID, internal and external.
  >
  > Agreed, but that' longer-term problem. Still high, but not user-facing, at 
least to viewers.
  
  I'd count breaking links as user facing... but not as urgent, sure.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Cparle

Cparle added a comment.


  @Urbanecm the patch prevents the fatal error, but there are other errors if, 
for example, a user tries to edit a caption.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Urbanecm

Urbanecm added a comment.


  In T231276#5458493 , 
@daniel wrote:
  
  > Quick fix for the error: just remove the check that triggers the error. 
Could be converted to a warning, or just a debug message.
  
  Good idea, uploaded a patch.
  
  > However, this doesn't solve the conceptual problem of breaking all existing 
references to the old entity ID, internal and external.
  
  Agreed, but that' longer-term problem. Still high, but not user-facing, at 
least to viewers.
  
  > @Mholloway said:
  >
  >> What should happen here? Should the entity always retain its original ID 
even after a page move, or should the entity ID always reflect the current page 
ID of the page with which it's associated?
  >
  > [...]
  > From the Wikibase model perspective, entity IDs should never change. So the 
original ID needs to be retained. The question is how that could be made to 
work...
  
  Agreed, but topic for "after at least a stopgap is done", I guess.
  
  In T231276#5458596 , @Yann 
wrote:
  
  > In T231276#5458493 , 
@daniel wrote:
  >
  >> (...)I wonder though why the page ID wasn't restored in this case - I 
don't really see a reason for that, may be worth investigating.
  >
  > The file is a big file (708.4 MB) from 
https://archive.org/details/20190830_20190830_1349
  > This may partly explain that (time out?).
  
  Seems like a good way to go, hopefully, the patch above will work as a 
stopgap solution, until this is fully investigated.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, Hook696, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, alaa_wmde, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread gerritbot

gerritbot added a comment.


  Change 533907 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
  [mediawiki/extensions/Wikibase@master] [stopgap] Don't throw an exception on 
unexpected difference between M* ids
  
  https://gerrit.wikimedia.org/r/533907

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-09-02 Thread Yann

Yann added a comment.


  In T231276#5458493 , 
@daniel wrote:
  
  > (...)I wonder though why the page ID wasn't restored in this case - I don't 
really see a reason for that, may be worth investigating.
  
  The file is a big file (708.4 MB) from 
https://archive.org/details/20190830_20190830_1349
  This may partly explain that (time out?).

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Yann
Cc: daniel, Pablo-WMDE, Urbanecm, Zoranzoki21, Yann, WMDE-leszek, 
Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-30 Thread Cparle

Cparle added a comment.


  Not really - the MediaInfo id refers to a slot rather than a page, and isn't 
accessible via a url. I think the | `ArticleUndelete` 
 solution will work

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Cparle
Cc: Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-30 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.


  Not my decision to make but those are presumably stable identifiers that 
reusers of the data can rely on just like Wikidata Q-IDs for Items. In this 
case you'll probably want to make the data available under both IDs. Wikidata 
does this with redirects on Items and Lexemes.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Cparle, Mholloway, Addshore, hashar, ArielGlenn, 
Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Mholloway

Mholloway added a comment.


  Better, if we want to preserve the correspondence between mediainfo IDs and 
page IDs, would be to hook into ArticleUndelete 
 and update the 
mediainfo ID if the page ID has changed.  (Despite what its name might suggest, 
that hook isn't restricted to NS_MAIN, but appears to fire when any page from 
any namespace is restored.)

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Cparle, Mholloway, Addshore, hashar, ArielGlenn, Lucas_Werkmeister_WMDE, 
Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, 
Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-29 Thread Mholloway

Mholloway added a comment.


  What //should// happen here?  Should the entity always retain its original ID 
even after a page move, or should the entity ID always reflect the current page 
ID of the page with which it's associated?
  
  The assumption that the entity ID will always reflect the (current) page ID 
seems pretty well baked in at this point, so maybe the entity IDs should just 
be updated as discrepancies are found.  On the other hand, that risks masking 
any deeper issues that arise.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Cparle, Mholloway, Addshore, hashar, ArielGlenn, Lucas_Werkmeister_WMDE, 
Liuxinyu970226, Aklapper, zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, 
Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread hashar

hashar added a comment.


  The few errors showing are since 2019-08-26 09:40:00 UTC (there are a few 
before that).  Might just have been an edit on one of the pages that is 
introduced a fault that is not properly handled.
  
  The scope is fairly thin, it just a few items on commonswiki apparently. 
Hence does not seem to be worth blocking the train.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  In T231276#5441664 , 
@ArielGlenn wrote:
  
  > In T231276#5441586 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> 
  >
  > ...
  >
  >> It’s part of the serialization. Not sure why that would be a new issue, 
though – this seems like a fairly fundamental issue (tying the page ID to the 
page content even though it’s not stable across delete+restore). Is it possible 
that File:Bolsonaro_etc is just the first file with structured data that was 
deleted and then restored?
  >
  > I'd be willing to put money on that.
  
  I think you’d lose it :) found some more with an ugly query:
  
SELECT log_id, log_page, log_title, rev_id
FROM logging
JOIN revision ON log_page = rev_page
JOIN slots ON rev_id = slot_revision_id
-- this log entry restores a file
WHERE log_type = 'delete'
AND log_action = 'restore'
AND log_namespace = 6
-- and there is a corresponding revision, predating the restoration, that 
already had a mediainfo slot
AND slot_role_id = (SELECT role_id FROM slot_roles WHERE role_name = 
'mediainfo')
AND rev_timestamp < log_timestamp
-- captions were introduced in January 2019, so we can skip all earlier 
revisions and log entries
AND rev_timestamp > 2019010100
AND log_timestamp > 2019010100
-- the restoration did not reuse the page ID (which we get from a 
corresponding deletion)
AND log_page != (SELECT logdel.log_page FROM logging AS logdel WHERE 
logdel.log_type = 'delete' AND logdel.log_action = 'delete' AND 
logdel.log_namespace = 6 AND logdel.log_title = logging.log_title LIMIT 1)
LIMIT 10;
  
  For example, File:PL_Stanisław_Witkiewicz-Na_przełęczy_013.jpeg 

 had a caption in revision 334323754 
, 22:37, 10 
January 2019; then was deleted 
 23:10 of 
the same day; and later restored. Curiously enough, according to the log entry, 
the page ID at the time was 11632736 (`log_page` of `log_id = 278125433`); yet, 
the serialization of the previous revision, 334323754, already contains the 
entity ID M75745807 (checked using this code 
,
 but with `mediainfo` instead of `main` for the slot).
  
  Perhaps WikibaseMediaInfo already contains code that’s supposed to take care 
of this? (Although updating serializations of old revisions like that sounds 
super dangerous to me.) And it broke recently?

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: hashar, ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread hashar

hashar added a comment.


  Seems that is just a data error with a single entry?  I don't feel like this 
issue should be blocking the train.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread ArielGlenn

ArielGlenn added a comment.


  In T231276#5441586 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > 
  
  ...
  
  > It’s part of the serialization. Not sure why that would be a new issue, 
though – this seems like a fairly fundamental issue (tying the page ID to the 
page content even though it’s not stable across delete+restore). Is it possible 
that File:Bolsonaro_etc is just the first file with structured data that was 
deleted and then restored?
  
  I'd be willing to put money on that.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  > but then where does Wikibase(MediaInfo) get the idea that this is the real 
entity ID of the entity it’s loading from page 81625979?
  
  Ah, that’s where:
  
>>> $services = MediaWiki\MediaWikiServices::getInstance();
=> MediaWiki\MediaWikiServices {#211}
>>> $revision = $services->getRevisionStore()->getRevisionByPageId( 
81625979 );
=> MediaWiki\Revision\RevisionStoreRecord {#3075}
>>> $services->getBlobStore()->getBlob( $revision->getSlot( 'mediainfo' 
)->getAddress() );
=> 
"{"type":"mediainfo","id":"M77688146","labels":{"en":{"language":"en","value":"Bolsonaro
 with Israeli PM Benjamin Netanyahu, Tel Aviv, 31 March 
2019"}},"descriptions":[],"statements":[]}"
  
  It’s part of the serialization. Not sure why that would be a new issue, 
though – this seems like a fairly fundamental issue (tying the page ID to the 
page content even though it’s not stable across delete+restore). Is it possible 
that File:Bolsonaro_etc is just the first file with structured data that was 
deleted and then restored?

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  I can’t find any trace of this 77688146 ID in production – it’s not a 
`page_id`, `ar_id`, or `ar_page_id`. I assume it must have been the page ID of 
the page before it was deleted (and for some reason it was not reused on 
restore even though it looks like that’s supposed to happen) – but then where 
does Wikibase(MediaInfo) get the idea that this is the real entity ID of the 
entity it’s loading from page 81625979?

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread ArielGlenn

ArielGlenn added a comment.


  
https://commons.wikimedia.org/wiki/Special:Log?type=&user=&page=File%3ABolsonaro_with_Israeli_PM_Benjamin_Netanyahu%2C_Tel_Aviv%2C_31_March_2019.jpg&wpdate=&tagfilter=
  It was deleted and restored on 02:45, 26 Αυγούστου 2019 so I guess something 
isn't handled quite right in MediaInfo entities for these cases.

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArielGlenn
Cc: ArielGlenn, Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, 
zeljkofilipin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Ricordisamoa, Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T231276: RevisionBasedEntityLookup.php: Revision 363395998 belongs to M77688146 instead of expected M81625979

2019-08-27 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Also, https://commons.wikimedia.org/wiki/Special:EntityData/M77688146 shows 
another error:
  
  > [XWT28gpAAEIAAFLRMGgQ] 2019-08-27 09:25:06: Fatal exception of type 
"BadMethodCallException"

TASK DETAIL
  https://phabricator.wikimedia.org/T231276

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Liuxinyu970226, Aklapper, zeljkofilipin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

49 matches

Mail list logo