[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-14 Thread Ladsgroup 
Ladsgroup added a comment.


  I understand this might be frustrating but there are some points to consider:
  
  - you should avoid depending on the wikibase frontend code (according to 
public interface policy 
, they are 
considered unstable and prone to change at any time without prior warning). You 
should depend on hooks instead and if the hook for what you want doesn't exist, 
make a ticket and we address it.
  - These changes are important for performance 

 on network level (just this ticket, drops 30 GB/day. TBs for users every 
month). Cleaner RL modules makes the code more understandable to outside users 
(and provide tighter encapsulation) and even it reduces the time to load every 
item in wikidata (I estimate it will be between half a second to a second in 
total in every page view).
  - I understand the request for providing end results beforehand but the 
problem with this enormous codebase is that it was impossible to get end 
results (or goals) when we started. The dependency graph of the modules when we 
started was this:
  
  F30309312: G.png 
  (click on it to see, 4MB)
  It was so complicated that we ended up writing graph analysis tools to find 
dead modules, unused modules, "entry point" modules or modules that can be 
merged. We continue to make it better but the graph is slightly cleaner now but 
we still try to merge a module and we end up not doing it.
  HTH

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: eranroz, Rosalie_WMDE, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-12 Thread eranroz 
eranroz added a comment.


  I was using this RL and it just got disappear and broke gadgets that use it. 
  This breaks again wikidata usage, after "wikibase.client.getMwApiForRepo"  
was removed not long ago.
  
  For the next refactor - I suggest to first defined the end goal - so all 
gadgets can adapt to it and properly announce it.

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, eranroz
Cc: eranroz, Rosalie_WMDE, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-02 Thread gerritbot 
gerritbot added a comment.


  Change 538061 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Drop getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538061

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Rosalie_WMDE, Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-02 Thread gerritbot 
gerritbot added a comment.


  Change 538058 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexeme@master] Drop getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538058

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Rosalie_WMDE, Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-02 Thread gerritbot 
gerritbot added a comment.


  Change 538060 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Use wikibase.api.RepoApi 
instead of getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538060

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Rosalie_WMDE, Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-10-02 Thread gerritbot 
gerritbot added a comment.


  Change 538056 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add getLocationAgnosticMwApi to 
wikibase.api.RepoApi
  
  https://gerrit.wikimedia.org/r/538056

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Rosalie_WMDE, Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-09-19 Thread gerritbot 
gerritbot added a comment.


  Change 538061 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Drop getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538061

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-09-19 Thread gerritbot 
gerritbot added a comment.


  Change 538060 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/WikibaseMediaInfo@master] Use wikibase.api.RepoApi 
instead of getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538060

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-09-19 Thread gerritbot 
gerritbot added a comment.


  Change 538058 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/WikibaseLexeme@master] Drop getLocationAgnosticMwApi
  
  https://gerrit.wikimedia.org/r/538058

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233212: Merge wikibase.api.RepoApi and wikibase.api.getLocationAgnosticMwApi

2019-09-19 Thread gerritbot 
gerritbot added a comment.


  Change 538056 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Add getLocationAgnosticMwApi to 
wikibase.api.RepoApi
  
  https://gerrit.wikimedia.org/r/538056

TASK DETAIL
  https://phabricator.wikimedia.org/T233212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs