[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-23 Thread Mormegil 
Mormegil added a comment.


  I found this bug only after reducing my broken query until only this was left:
  
SELECT (MIN(?name) AS ?name) WHERE {
}
  
  Also, I noticed COUNT and SAMPLE work fine, while the other aggregate 
functions do not support this aliasing. If it is an error, a better error 
message would definitely come handy.

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mormegil
Cc: Mormegil, TomT0m, Lea_Lacroix_WMDE, Tagishsimon, Envlh, Mathew.onipe, 
Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-21 Thread Evilricepuddin 
Evilricepuddin added a comment.


  As a user, I'd be happy with the fix being that the variable re-use is 
detected and I'm given an appropriate error message (this was, after all, the 
fix that I deployed to work around the problem). I imagine that the 
StackOverflowError is not the intended "you've sent an invalid query" error. ;)

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Evilricepuddin
Cc: Lea_Lacroix_WMDE, Tagishsimon, Envlh, Mathew.onipe, Smalyshev, 
Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-21 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  That’s true, but Virtuoso also allows this, at least in the DBpedia endpoint 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lea_Lacroix_WMDE, Tagishsimon, Envlh, Mathew.onipe, Smalyshev, 
Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-19 Thread Tagishsimon 
Tagishsimon added a comment.


  Fix by all means, but I note "It is an error for aggregates to project 
variables with a name already used in other aggregate projections, or in the 
WHERE clause." https://www.w3.org/TR/sparql11-query/#aggregateExample

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tagishsimon
Cc: Tagishsimon, Envlh, Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, 
Igorkim78, Aklapper, Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, 
rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Igorkim78 
Igorkim78 added a comment.


  The LabelService optimizer was fixed (so it will not throw NPEs) this August, 
by reusing Blazegraph core utility 
com.bigdata.rdf.sparql.ast.StaticAnalysis.getVarsFromArguments(BOp) to run an 
introspection on variables used in filters and other clauses, so LabelService 
call placement could be properly adjusted, this introspection seems to come 
into infinite loop over the AST tree. Vars reuse to label aggregation after the 
original var is a common practice, so, yes it should be fixed. Looking on the 
workaround to extract referenced vars without catching into the infinite loop.

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Igorkim78
Cc: Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, 
Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-10-16T12:30:28Z] 
 Finished deploy [wdqs/wdqs@217cac5]: redeploy 
0.3.4-SNAPSHOT - T235540  (duration: 
03m 40s)

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, 
Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-10-16T12:26:56Z] 
 Started deploy [wdqs/wdqs@217cac5]: redeploy 
0.3.4-SNAPSHOT - T235540 

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, 
Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-10-16T12:15:36Z] 
 Finished deploy [wdqs/wdqs@c90503b]: Revert to fix 
T235540  (duration: 19m 09s)

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, 
Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Mathew.onipe 
Mathew.onipe added a comment.


  @Evilricepuddin We are currently deploying a revert. So you can keep your old 
query.

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mathew.onipe
Cc: Mathew.onipe, Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, 
Evilricepuddin, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-10-16T11:56:26Z] 
 Started deploy [wdqs/wdqs@c90503b]: Revert to fix 
T235540 

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Evilricepuddin 
Evilricepuddin added a comment.


  Thanks for the workaround, can confirm that the query is working again for me 
now :)

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Evilricepuddin
Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-15 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  @Evilricepuddin workaround: in
  
(GROUP_CONCAT(DISTINCT ?twitterId; SEPARATOR = ",") AS ?twitterId)
  
  change the final `?twitterId` to `?twitterId_`.
  
  But reusing the same variable name after aggregation is something I’ve also 
often done in the past, so ideally we should get this fixed.

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-15 Thread Smalyshev 
Smalyshev added a comment.


  Our fork is in https://github.com/wikimedia/wikidata-query-blazegraph

TASK DETAIL
  https://phabricator.wikimedia.org/T235540

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs