[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-03-06 Thread gerritbot 
gerritbot added a comment.


  Change 576374 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Handle middle clicks on 
autocomplete suggestions differently
  
  https://gerrit.wikimedia.org/r/576374

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, gerritbot
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, 
JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Darkminds3113, 
Anooprao, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, 
Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, WSH1906, Lewizho99, 
Maathavan, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, 
Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-03-03 Thread gerritbot 
gerritbot added a comment.


  Change 576374 had a related patch set uploaded (by Anne Tomasevich; owner: 
Anne Tomasevich):
  [mediawiki/extensions/WikibaseMediaInfo@master] Handle middle clicks on 
autocomplete suggestions differently
  
  https://gerrit.wikimedia.org/r/576374

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, gerritbot
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
CBogen, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-01-24 Thread AnneT 
AnneT added a comment.


  Oops, the patch I referred to isn't on production yet. EntityLookupElement 
was refactored to EntityInputWidget, which is live on prod at the moment with 
the failing `onMousedown` method.
  
  Stephen suggested this might be an issue related to the way events are 
connected and fired in OOUI, which I'll start digging into but may need help 
from the OOUI gods at some point...

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-01-24 Thread Niedzielski 
Niedzielski added a comment.


  @AnneT, eek, I'm not seeing that load either! I do see MenuOptionWidget.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Niedzielski
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-01-24 Thread AnneT 
AnneT added a comment.


  Hey @Niedzielski, that component was refactored into 
`EntityAutocompleteInputWidget` in a later patch, see here 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2020-01-23 Thread Niedzielski 
Niedzielski added a comment.


  I can repro the issue in the Chromium device emulator on Vector per the 
description:
  
  1. Enable device emulation.
  2. Visit 
https://commons.m.wikimedia.org/wiki/File:GOR_Ranggajati_Sumber.jpg?debug=true&useskin=vector.
  3. View the structured data tab.
  4. Type "a" in the depicts field.
  5. Tap the first entry.
  
  However, I don't actually see the EntityLookupElement class referenced in the 
linked patch loaded so either I've got something entirely wrong on my end or 
that's why the change had no effect.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Niedzielski
Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, 
Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, 
darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, 
Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, 
Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-12-16 Thread Sadads 
Sadads added a comment.


  Yep, still occurs for me to: tried adding palm tree to
  https://commons.m.wikimedia.org/wiki/File:GOR_Ranggajati_Sumber.jpg#/random
  and it opens wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Sadads
Cc: Sadads, Premeditated, SandraF_WMF, Tohaomg, Masumrezarock100, egardner, 
LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, Nandana, 
JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-12-13 Thread Tohaomg 
Tohaomg added a comment.


  In T237048#5741217 , 
@Ramsey-WMF wrote:
  
  > @Astinson this fix should be live on Commons now. Want to give a try?
  
  The bug still occurs.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Tohaomg
Cc: Premeditated, SandraF_WMF, Tohaomg, Masumrezarock100, egardner, 
LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, Nandana, 
JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-12-13 Thread Ramsey-WMF 
Ramsey-WMF added a comment.


  @Astinson this fix should be live on Commons now. Want to give a try?

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, Ramsey-WMF
Cc: Premeditated, SandraF_WMF, Tohaomg, Masumrezarock100, egardner, 
LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, Nandana, 
JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-12-06 Thread gerritbot 
gerritbot added a comment.


  Change 554901 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Explicitly prevent default 
link behavior for entity lookup options
  
  https://gerrit.wikimedia.org/r/554901

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, gerritbot
Cc: SandraF_WMF, Tohaomg, Masumrezarock100, egardner, LucasWerkmeister, 
Ramsey-WMF, Aklapper, Astinson, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, 
Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, 
E1presidente, Cparle, Darkminds3113, Anooprao, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, 
Acer, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, Base, 
matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, 
Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-12-05 Thread gerritbot 
gerritbot added a comment.


  Change 554901 had a related patch set uploaded (by Anne Tomasevich; owner: 
Anne Tomasevich):
  [mediawiki/extensions/WikibaseMediaInfo@master] Explicitly prevent default 
link behavior for entity lookup options
  
  https://gerrit.wikimedia.org/r/554901

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AnneT, gerritbot
Cc: SandraF_WMF, Tohaomg, Masumrezarock100, egardner, LucasWerkmeister, 
Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, DannyS712, Nandana, JKSTNK, 
Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, GoranSMilovanovic, 
QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, 
rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, Base, 
matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, 
Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-11-29 Thread Tohaomg 
Tohaomg added a comment.


  I faced the same issue and I tested it in different situations. This bug 
appears only on Android devices, but not on Apple devices. On Android devices 
(I tested it on several devices) it appears in all browsers (tested Opera, 
Chrome and built-in browser) in both desktop and mobile versions. So this must 
be an Android related problem.

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: egardner, Tohaomg
Cc: Tohaomg, Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, 
Aklapper, Astinson, darthmon_wmde, DannyS712, Nandana, JKSTNK, Lahi, 
PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
_jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-10-31 Thread Astinson 
Astinson added a comment.


  yeah, so I start typing, and try to select one of the options: but it opens a 
new tab. I am on Android devices, editing in Chrome, asking for the desktop 
version of the site so that I can edit the Structured Data -- in particular I 
would like to be able to do AC/DC while watching tv, while using a tablet :P

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Astinson
Cc: LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, DannyS712, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown

2019-10-31 Thread Ramsey-WMF 
Ramsey-WMF added a comment.


  @Astinson Hello. Just to clarify: this is an issue when attempting to select 
an entity listed in the autosuggest text box when you start typing?

TASK DETAIL
  https://phabricator.wikimedia.org/T237048

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ramsey-WMF
Cc: LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, DannyS712, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Cparle, Anooprao, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Susannaanas, Abit, Jane023, Wikidata-bugs, 
Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Fabrice_Florin, Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs