[Wikidata-bugs] [Maniphest] [Commented On] T246117: Improvement: Increase line-height of 14px font to 1.6 (22px)

2020-03-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Right, sorry, I mixed up the two line heights in the radio input.

TASK DETAIL
  https://phabricator.wikimedia.org/T246117

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T246117: Improvement: Increase line-height of 14px font to 1.6 (22px)

2020-03-11 Thread Sarai-WMDE
Sarai-WMDE added a comment.


  Unfortunately not for all text, only 14px (0.85rem) font should have a 1.6 
line-height.
  
  The line-height of the base 16px text is still 1.5 (this is actually the 
line-height applied to the larger text in the radio button, at least in the 
Storybook component!).

TASK DETAIL
  https://phabricator.wikimedia.org/T246117

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T246117: Improvement: Increase line-height of 14px font to 1.6 (22px)

2020-03-11 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  So does this mean that 1.6 is now our standard line-height for all text? IIRC 
we already use it for the larger text (16px) in the (shared) radio input 
component.

TASK DETAIL
  https://phabricator.wikimedia.org/T246117

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs