[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
gerritbot added a comment. Change 580369 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add ReferenceFormatterFactory https://gerrit.wikimedia.org/r/580369 TASK DETAIL https://phabricator.wikimedia.org/T247412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
gerritbot added a comment. Change 579276 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add ReferenceFormatter service https://gerrit.wikimedia.org/r/579276 TASK DETAIL https://phabricator.wikimedia.org/T247412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
gerritbot added a comment. Change 580369 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add ReferenceFormatterFactory https://gerrit.wikimedia.org/r/580369 TASK DETAIL https://phabricator.wikimedia.org/T247412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
Lucas_Werkmeister_WMDE added a comment.
> “Service” probably means something like “an interface, a class implementing
it which gets other ‘services’ as constructor parameters, and a getter on
`WikibaseClient`”.
I looked a bit into this. What I had in mind was the standard lazily
initialized service pattern that you see all over `WikibaseClient` and
`WikibaseRepo`:
private $dataBridgeReferenceFormatter = null;
public function getDataBridgeReferenceFormatter() {
if ( $this->dataBridgeReferenceFormatter === null ) {
$this->dataBridgeReferenceFormatter = new
DataBridgeReferenceFormatter( ... );
}
return $this->dataBridgeReferenceFormatter;
}
But I don’t think this works out directly – the
`DataBridgeReferenceFormatter` needs a `SnakFormatter` and a `MessageLocalizer`
injected, and both of these depend on a request context. I think the usual
solution to that in Wikibase is to make the lazily initialized service a
//factory// (e. g. `WikibaseClient::getSnakFormatterFactory()`,
`WikibaseClient::getDataAccessSnakFormatterFactory()`), and that factory then
has a method to create a new instance of the actual service given the request
context (language etc.). I think that’s a good solution for our case here as
well – we can even call the factory a more general `ReferenceFormatterFactory`,
for now only with a method `newDataBridgeReferenceFormatter()` but anticipating
that the same factory could in future create formatters for other styles as
well (thus avoiding cluttering `WikibaseClient` itself with one field+getter
per style).
TASK DETAIL
https://phabricator.wikimedia.org/T247412
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY,
Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde,
Meekrab2012, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420,
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86,
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382,
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99,
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude,
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
gerritbot added a comment. Change 579276 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: Add ReferenceFormatter service https://gerrit.wikimedia.org/r/579276 TASK DETAIL https://phabricator.wikimedia.org/T247412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247412: Implement PHP service to format references
Lucas_Werkmeister_WMDE added a comment. To separate the formatted reference values, this will probably need a message similar to our current `wikibase-client-data-bridge-reference-snak-separator`, but under a message key that’s not Bridge-specific. We could rename that message, or drop it (currently there are no translations for it) and recreate it separately. Maybe quickly discuss this with TranslateWiki.net folks. TASK DETAIL https://phabricator.wikimedia.org/T247412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
