[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-03-17T00:57:15Z] 
 Synchronized 
php-1.35.0-wmf.23/extensions/Wikibase/lib/includes/Formatters/: Ic77b2c6b33a, 
T247458  (duration: 01m 12s)

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, 
Aklapper, brennen, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[gerritbot]

gerritbot added a comment.


  Change 580112 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not assume 
wgKartographerLiveData is always set
  
  https://gerrit.wikimedia.org/r/580112

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, 
Aklapper, brennen, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[gerritbot]

gerritbot added a comment.


  Change 580112 had a related patch set uploaded (by Krinkle; owner: Thiemo 
Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.23] Do not assume 
wgKartographerLiveData is always set
  
  https://gerrit.wikimedia.org/r/580112

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[gerritbot]

gerritbot added a comment.


  Change 579525 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Do not assume wgKartographerLiveData 
is always set
  
  https://gerrit.wikimedia.org/r/579525

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, 
Aklapper, brennen, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[gerritbot]

gerritbot added a comment.


  Change 579525 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/extensions/Wikibase@master] Do not assume wgKartographerLiveData 
is always set
  
  https://gerrit.wikimedia.org/r/579525

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, 
Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[brennen]

brennen added a comment.


  Setting as UBN as long as this is marked a train blocker.  Sounds like it's 
not serious in terms of real impact but it would be nice to eliminate logspam.

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015, Krinkle, Aklapper, 
brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[thiemowmde]

thiemowmde added a comment.


  I do not know the involved CachingKartographerEmbeddingHandler class in 
Wikibase very well. But according to what I see in 
https://codesearch.wmflabs.org/search/?q=wgKartographerLiveData I suspect that:
  
  1. I believe this is **not** a serious issue. Just a notice. The missing 
variable is cast to an empty array. From there, I believe all following code is 
fine with an empty array.
  2. The root cause appears to be a mismatch between the code in the 
Kartographer extension where the variable is created, and the code in Wikibase 
that consumes it. Note that the variable is only created under specific 
circumstances, but Wikibase **always** expects it.
  
  Just a few lines below in the same class is a check that creates the variable 
in case it is missing. 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php#174
 But this line is in JavaScript. It appears like the same check needs to be 
done in PHP.

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Agusbou2015, Krinkle, Aklapper, brennen, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

[Krinkle]

Krinkle added a comment.


  Undefined variables seem quite serious, especially config variables. Blocker 
imho.

TASK DETAIL
  https://phabricator.wikimedia.org/T247458

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs