[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[gerritbot]

gerritbot added a comment.


  Change 596522 abandoned by Jdlrobson:
  BaseTemplate: language_urls property should always reflect true emptiness
  
  Reason:
  Okay, I'm going to move this decision into the skins themselves. It seems 
like the path of least resistance right now.
  
  https://gerrit.wikimedia.org/r/596522

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, gerritbot
Cc: RhinosF1, Theklan, jeblad, 1339861mzb, Acamicamacaraca, Bencemac, 
abhaynatu, Tiven2240, ImprovedWikiImprovment, mxn, M2k_dewiki, MBH, Ghuron, 
minhhuy, Vachovec1, IKhitron, Iniquity, Agusbou2015, Josve05a, Base, Lofhi, 
Huji, NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T252800#6175054 , @Huji 
wrote:
  
  > In T252800#6174656 , 
@Jdforrester-WMF wrote:
  >
  >> In T252800#6174604 , 
@Huji wrote:
  >>
  >>> And finally, if that is correct, would it be fair to say that the next 
time we can expect the patches for this task to go live would be June 2nd?
  >>
  >> No. Should be within the hour, assuming we find all the bugs and get it 
out.
  >
  > But if we were unsuccessful in resolving the blockers, then the whole train 
would be pushed back by one week, correct? (Or do we use an earlier SWAT window 
in such circumstances?)
  
  Not a whole week; it'd be pushed to the next deployment day, which in this 
case would have been Monday 1 June.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdforrester-WMF
Cc: RhinosF1, Theklan, jeblad, 1339861mzb, Acamicamacaraca, Bencemac, 
abhaynatu, Tiven2240, ImprovedWikiImprovment, mxn, M2k_dewiki, MBH, Ghuron, 
minhhuy, Vachovec1, IKhitron, Iniquity, Agusbou2015, Josve05a, Base, Lofhi, 
Huji, NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Huji]

Huji added a comment.


  In T252800#6174656 , 
@Jdforrester-WMF wrote:
  
  > In T252800#6174604 , 
@Huji wrote:
  >
  >> And finally, if that is correct, would it be fair to say that the next 
time we can expect the patches for this task to go live would be June 2nd?
  >
  > No. Should be within the hour, assuming we find all the bugs and get it out.
  
  But if we were unsuccessful in resolving the blockers, then the whole train 
would be pushed back by one week, correct? (Or do we use an earlier SWAT window 
in such circumstances?)

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Huji
Cc: RhinosF1, Theklan, jeblad, 1339861mzb, Acamicamacaraca, Bencemac, 
abhaynatu, Tiven2240, ImprovedWikiImprovment, mxn, M2k_dewiki, MBH, Ghuron, 
minhhuy, Vachovec1, IKhitron, Iniquity, Agusbou2015, Josve05a, Base, Lofhi, 
Huji, NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  In T252800#6174604 , @Huji 
wrote:
  
  > @Jdforrester-WMF can I use this opportunity to learn the deployment process 
better?
  
  Of course.
  
  > Do I understand correctly that the patches associated with the current task 
were supposed to be deployed in the //Mediawiki train - American Version// 
window (19-21 UTC today) in which 1.35.0-wmf.34 would be deployed?
  
  Yes.
  
  > Given that we are at 21:03 UTC right now and the change is still not seen 
on Wikipedias, I checked Special:Version on Wikipedias and they are still on MW 
1.35.0-wmf.32; is it safe to assume that the issue is that wmf.34 has blockers 
(i.e. T253022  is still open)?
  
  Yes, that's indicated on the given task. Working on it now.
  
  > And finally, if that is correct, would it be fair to say that the next time 
we can expect the patches for this task to go live would be June 2nd?
  
  No. Should be within the hour, assuming we find all the bugs and get it out.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdforrester-WMF
Cc: RhinosF1, Theklan, jeblad, 1339861mzb, Acamicamacaraca, Bencemac, 
abhaynatu, Tiven2240, ImprovedWikiImprovment, mxn, M2k_dewiki, MBH, Ghuron, 
minhhuy, Vachovec1, IKhitron, Iniquity, Agusbou2015, Josve05a, Base, Lofhi, 
Huji, NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  Yes, this was broken by the wmf.32 release which reached Wikipedias a few 
hours ago (and all other wikis a week ago); the next release, wmf.34, is being 
branched now, and should fix that for all, but won't be on Wikipedias for 
another 50 hours.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdforrester-WMF
Cc: NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[NickK]

NickK added a comment.


  Looks like this is getting works. Multiple reports from users today on ukwiki 
who can no longer add articles, while it work for them as late as yesterday.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, NickK
Cc: NickK, alanajjar, Raymond, Roy17, JAnD, MB-one, Ninovolador, Nikerabbit, 
WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, 
Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, 
hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Arrbee, santhosh, 
KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[ovasileva]

ovasileva added a comment.


  In T252800#6152293 , 
@hashar wrote:
  
  > ContentTranslation and UniversalLanguageSelector are affected as well.
  >
  > I am aiming at pushing 1.35.0-wmf.32 on the remaining wiki on Monday 25th 
during European afternoon. We will thus have those features hidden/disabled 
until the next version reaches all wikis on Thursday May 28th. Is that ok for 
everyone?
  
  Sounds good to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: Nikerabbit, WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, 
Pginer-WMF, Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, 
Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, Aklapper, Vriullop, 
Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, Alter-paule, Beast1978, 
Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, holger.knust, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Soum213, Taiwania_Justo, Scott_WUaS, Wong128hk, Wikidata-bugs, 
aude, Ebe123, Arrbee, santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[hashar]

hashar added a comment.


  ContentTranslation and UniversalLanguageSelector are affected as well.
  
  I am aiming at pushing 1.35.0-wmf.32 on the remaining wiki on Monday 25th 
during European afternoon. We will thus have those features hidden/disabled 
until the next version reaches all wikis on Thursday May 28th. Is that ok for 
everyone?

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, hashar
Cc: Nikerabbit, WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, 
Pginer-WMF, Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, 
Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, Aklapper, Vriullop, 
Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, Alter-paule, Beast1978, 
Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, holger.knust, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Soum213, Taiwania_Justo, Scott_WUaS, Wong128hk, Wikidata-bugs, 
aude, Ebe123, Arrbee, santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[ovasileva]

ovasileva added a comment.


  Discussed with @Lydia_Pintscher @Pginer-WMF and we decided that, given the 
risks, it would be okay to wait until next week's train, so long as we don't 
see this affecting articles that already have language links.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: Nikerabbit, WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, 
Pginer-WMF, Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, 
Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, Aklapper, Vriullop, 
Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, Alter-paule, Beast1978, 
Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, holger.knust, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Soum213, Taiwania_Justo, Scott_WUaS, Wong128hk, Wikidata-bugs, 
aude, Ebe123, Arrbee, santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Nikerabbit]

Nikerabbit added a comment.


  It seems this affects:
  
  - No Wikidata link to add interlanguage links
  - No Content Translation grey links to start a translation
  - No UniversalLanguageSelector cog for easy access to language settings.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Nikerabbit
Cc: Nikerabbit, WMDE-leszek, Ladsgroup, Jdforrester-WMF, polishdeveloper, 
Pginer-WMF, Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, 
Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, Aklapper, Vriullop, 
Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, Alter-paule, Beast1978, 
Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, holger.knust, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Soum213, Taiwania_Justo, Scott_WUaS, Wong128hk, Wikidata-bugs, 
aude, Ebe123, Arrbee, santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdlrobson]

Jdlrobson added a comment.


  I talked to @ovasileva  earlier today and  my understand is she felt it was 
not a train blocker per a conversation with @Pginer-WMF . She said she'd reach 
out to Lydia.
  
  The risk here from a development perspective is that such a fix will be 
bespoke for this particular branch. Note: rolling back is not an option due to 
caching implications.
  
  FWIW if we do need to patch this we're likely looking at a patch Wednesday PM 
earliest but most likely sometime Thursday. For me to feel comfortable with 
this, it will involve:
  
  1. 1-2hrs writing a new patch specifically for this branch
  2. getting that patch code reviewed
  3. getting it staged on a labs wiki for QA (as this patch will have been 
untested in a production like setting)
  4. QA
  5. SWAT.
  
  The question is whether this issue is serious enough to commit to all that 
right now given the limited availability schedules of teams.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdlrobson
Cc: Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, Ankry, 
Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, 
Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, 
Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Nikerabbit, Arrbee, 
santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdforrester-WMF]

Jdforrester-WMF added a comment.


  Isn't this still a train blocker, per Lydia?

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdforrester-WMF
Cc: Jdforrester-WMF, polishdeveloper, Pginer-WMF, Edtadros, Ankry, 
Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, 
Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, 
Alter-paule, Beast1978, Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Soum213, Taiwania_Justo, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Ebe123, Nikerabbit, Arrbee, 
santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  I can't judge the risk but I'd say from the product side it's pretty bad and 
I'd rather not leave it broken for another week.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Lydia_Pintscher
Cc: Pginer-WMF, Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, 
Lucas_Werkmeister_WMDE, Robby, Jdlrobson, hashar, Aklapper, Vriullop, 
Liuxinyu970226, Blissjay007, Oblanco79, sgrabarczuk, Alter-paule, Beast1978, 
Rileych, Un1tY, Demian, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, 
darthmon_wmde, Kent7301, holger.knust, Meekrab2012, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, _jensen, 
rosalieper, Soum213, Taiwania_Justo, Scott_WUaS, Wong128hk, Wikidata-bugs, 
aude, Ebe123, Nikerabbit, Arrbee, santhosh, KartikMistry, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[hashar]

hashar added a comment.


  What Lucas Said, the fix would only land next week May 27/28.
  
  So I guess we can backport the Vector patch and swat it for the wikis that 
are currently using 1.35.0-wmf.32 (group1 right now).  And when the rest of 
wikis are promoted next Monday they will have the fix as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, hashar
Cc: Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, 
Jdlrobson, hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Un1tY, Demian, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Note that there’s no train this week (releng offsite, apparently), so this 
would remain unfixed until //next// Wednesday/Thursday.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Lucas_Werkmeister_WMDE
Cc: Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, 
Jdlrobson, hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Un1tY, Demian, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[Jdlrobson]

Jdlrobson added a comment.


  I can but given it doesn't swat cleanly my preference would be to let this 
ride the train then to deploy an untested bespoke patch? The languages box does 
display - it just doesn't display on pages without any languages. I agree 
that's not ideal, but it can be worked around and feels like something that we 
could leave broken until Wednesday/Thursday.
  
  The core change is not needed - that deals with the bigger issue that led to 
this bug.

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdlrobson
Cc: Edtadros, Ankry, Lydia_Pintscher, Mike_Peel, Lucas_Werkmeister_WMDE, Robby, 
Jdlrobson, hashar, Aklapper, Vriullop, Liuxinyu970226, Blissjay007, Oblanco79, 
sgrabarczuk, Alter-paule, Beast1978, Un1tY, Demian, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[gerritbot]

gerritbot added a comment.


  Change 596522 had a related patch set uploaded (by Jdlrobson; owner: 
Jdlrobson):
  [mediawiki/core@master] BaseTemplate: language_urls property should always 
reflect emptiness
  
  https://gerrit.wikimedia.org/r/596522

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson, gerritbot
Cc: Jdlrobson, hashar, MarcoAurelio, Aklapper, Vriullop, Liuxinyu970226, 
Demian, darthmon_wmde, holger.knust, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Winter, _jensen, rosalieper, Scott_WUaS, 
Wong128hk, Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[gerritbot]

gerritbot added a comment.


  Change 596516 **merged** by jenkins-bot:
  [mediawiki/skins/Vector@master] Show empty language portal if HTML has been 
added after portal
  
  https://gerrit.wikimedia.org/r/596516

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson, gerritbot
Cc: Jdlrobson, hashar, MarcoAurelio, Aklapper, Vriullop, Liuxinyu970226, 
Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Demian, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, holger.knust, 
Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Winter, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T252800: Regression: Option add links in other languages has disappeared

[gerritbot]

gerritbot added a comment.


  Change 596516 had a related patch set uploaded (by Jdlrobson; owner: 
Jdlrobson):
  [mediawiki/skins/Vector@master] Show empty language portal if HTML has been 
added after portal
  
  https://gerrit.wikimedia.org/r/596516

TASK DETAIL
  https://phabricator.wikimedia.org/T252800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson, gerritbot
Cc: Jdlrobson, hashar, MarcoAurelio, Aklapper, Vriullop, Liuxinyu970226, 
Demian, darthmon_wmde, holger.knust, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Winter, _jensen, rosalieper, Scott_WUaS, 
Wong128hk, Wikidata-bugs, aude, Isarra, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs