[Wikidata-bugs] [Maniphest] [Commented On] T253728: Fetch schema context is not working

2020-05-28 Thread Ladsgroup 
Ladsgroup added a comment.


  I made this as a possible solution: 
https://github.com/wmde/reference-island/pull/63 Which seems easy and 
straightforward.

TASK DETAIL
  https://phabricator.wikimedia.org/T253728

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, ItamarWMDE, Tarrow, Ladsgroup, Ferdinand0101, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T253728: Fetch schema context is not working

2020-05-27 Thread Tarrow 
Tarrow added a comment.


  Looks like this is due to the environment it is run in.
  
  wikidatarefisland/data_access/schema_context_downloader.py:15 has a try/catch 
clause on a JSONDecodeError from the python standard json library.
  
  This stack trace seems to show an attempt to use the simplejson library. 
Maybe the way requests was installed means it uses this? Or is simplejson 
monkey patched over the standard library or something?
  
  Could the try/catch have be phrased differently to catch all JSONDecode 
errors?

TASK DETAIL
  https://phabricator.wikimedia.org/T253728

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Aklapper, ItamarWMDE, Tarrow, Ladsgroup, Ferdinand0101, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs