[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error
thiemowmde added a comment. I do not plan to invest more time on this right now. Everything you said is fine. But even considering all this I think my patch https://gerrit.wikimedia.org/r/349878 is acceptable and does not interfere with one of the possible future solutions you proposed.TASK DETAILhttps://phabricator.wikimedia.org/T52202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, hoo, aude, Addshore, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm, Lydia_Pintscher, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Jackmcbarn, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error
daniel added a comment. @thiemowmde Whether the diff view code for EntityContent is called or not depends on which way you ask for the diff. When comparing two different kinds of content, it's unclear which diff code to use - that's exactly the reason the exception is thrown. The real solution to this problem would be to throw a more specific exception in this case, and catch it in Article or DifferenceEngine, and show a nice message. Or catch the condition earlier, before it triggers an exception, in Article or DifferenceEngine.TASK DETAILhttps://phabricator.wikimedia.org/T52202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: thiemowmde, hoo, aude, Addshore, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm, Lydia_Pintscher, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Jackmcbarn, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error
gerritbot added a comment. Change 349878 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Proper error when Special:ComparePages diffs entity with non-entity https://gerrit.wikimedia.org/r/349878TASK DETAILhttps://phabricator.wikimedia.org/T52202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: thiemowmde, hoo, aude, Addshore, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm, Lydia_Pintscher, daniel, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Jackmcbarn, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T52202: Diffing between different content models throws a fatal error
gerritbot added a comment. Change 349878 had a related patch set uploaded (by Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Proper error when Special:ComparePages diffs entity with non-entity https://gerrit.wikimedia.org/r/349878TASK DETAILhttps://phabricator.wikimedia.org/T52202EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Bugreporter, Ricordisamoa, Aklapper, Jasper, Legoktm, Lydia_Pintscher, daniel, QZanden, Izno, Wikidata-bugs, aude, Jackmcbarn, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
