[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
gerritbot added a comment. Change 379703 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Reduce duplicate code in EntityIdHtmlLinkFormatter https://gerrit.wikimedia.org/r/379703TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: matej_suchanek, gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
Lydia_Pintscher added a comment. Button to resolve the redirect: only as a gadget Allowing linking to redirects: No there should be no reason to do thatTASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Lydia_PintscherCc: matej_suchanek, gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
matej_suchanek added a comment. In T70567#3642537, @thiemowmde wrote: @matej_suchanek, feel free to jump in and tell us what you think. :-) Ok, gladly. We may also want a "resolve redirect" button, though the implementation of that button would have to be quite different for the main snak, qualifiers, and references. Something for #wikidata-gadgets maybe? We also need to decide whether the entity selector should allow redirects to be entered, and if yes, how they could be marked in the autocompletion list. On Wikipedia, you may want to link to a redirect when it's a placeholder for topic that is close to the linked one. However, redirects on Wikidata are created when the topics are same (. So the only reason for linking to a redirect is that it's incorrect and should be undone.TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
thiemowmde added a comment. I'm afraid the acceptance criteria of this ticket are not clear. @daniel mentioned so many things in the task description. To me this even sounds like it's talking about three or four different tickets. @daniel, can you please specify the description and make the acceptance criteria much more obvious? Thanks a lot. One possible set of acceptance criteria I can see is: Add the mw-redirect CSS class to links that point to redirects. This is what the two current patches do. Make the tooltip consistent to what core does. @matej_suchanek, feel free to jump in and tell us what you think. :-)TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, thiemowmdeCc: matej_suchanek, gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
gerritbot added a comment. Change 379545 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add CSS class to item redirects in UI https://gerrit.wikimedia.org/r/379545TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
gerritbot added a comment. Change 379703 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Reduce duplicate code in EntityIdHtmlLinkFormatter https://gerrit.wikimedia.org/r/379703TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
gerritbot added a comment. Change 379545 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [mediawiki/extensions/Wikibase@master] Add CSS class to item redirects in UI https://gerrit.wikimedia.org/r/379545TASK DETAILhttps://phabricator.wikimedia.org/T70567EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hoo, PokestarFan, thiemowmde, adrianheine, aude, Snaterlicious, Lydia_Pintscher, daniel, JohnLewis, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
thiemowmde added a comment. @Lydia_Pintscher, yes, in Wikipedia it's `a href=... title=... class=mw-redirect` with no visual difference to direct links. Most users don't know it's a redirect from looking at it, but they can tell from the redirected from sub-title shown on the target page. We should try to do the same, if possible. TASK DETAIL https://phabricator.wikimedia.org/T70567 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: JohnLewis, daniel, aude, thiemowmde, Snaterlicious, adrianlang, Lydia_Pintscher, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T70567: Make EntityView UI aware of redirects
Lydia_Pintscher added a comment. Ok thanks. Then we should follow that. TASK DETAIL https://phabricator.wikimedia.org/T70567 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: JohnLewis, daniel, aude, thiemowmde, Snaterlicious, adrianlang, Lydia_Pintscher, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
