[Wikidata-bugs] [Maniphest] [Commented On] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

[Daimona]

Daimona added a comment.
Hm, looking at this, it seems like $revision::getContent() is returning null although $revision is not null. However, looking at RevisionRecord and similar classes, I couldn't find a case when this can happen, given that we use RAW as audience (so deleted content shouldn't be a problem). To avoid the error we could just check that $oldcontent is not null, but this wouldn't help much, as we should understand the root cause.TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, dmaza, Litanwei, Wong128hk, Luke081515, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

[Krinkle]

Krinkle added a comment.
Seen still/again on 1.32.0-wmf.24:

SpecialUploadPHP Fatal Error: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content, null given

#0 /srv/mediawiki/php-1.32.0-wmf.24/extensions/AbuseFilter/includes/AbuseFilterHooks.php(801): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.32.0-wmf.24/extensions/AbuseFilter/includes/AbuseFilterHooks.php(729): AbuseFilterHooks::filterUpload(string, UploadFromFile, User, array, string, boolean, NULL)
#2 /srv/mediawiki/php-1.32.0-wmf.24/includes/Hooks.php(174): AbuseFilterHooks::onUploadVerifyUpload(UploadFromFile, User, array, string, boolean, NULL)
#3 /srv/mediawiki/php-1.32.0-wmf.24/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#4 /srv/mediawiki/php-1.32.0-wmf.24/includes/upload/UploadBase.php(852): Hooks::run(string, array)
#5 /srv/mediawiki/php-1.32.0-wmf.24/includes/specials/SpecialUpload.php(568): UploadBase->performUpload(string, boolean, boolean, User, array)
#6 /srv/mediawiki/php-1.32.0-wmf.24/includes/specials/SpecialUpload.php(207): SpecialUpload->processUpload()
#7 /srv/mediawiki/php-1.32.0-wmf.24/includes/specialpage/SpecialPage.php(569): SpecialUpload->execute(NULL)

ApiUploadPHP Fatal Error: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content, null given

#0 /srv/mediawiki/php-1.32.0-wmf.24/extensions/AbuseFilter/includes/AbuseFilterHooks.php(801): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-1.32.0-wmf.24/extensions/AbuseFilter/includes/AbuseFilterHooks.php(729): AbuseFilterHooks::filterUpload(string, UploadFromFile, User, array, string, string, NULL)
#2 /srv/mediawiki/php-1.32.0-wmf.24/includes/Hooks.php(174): AbuseFilterHooks::onUploadVerifyUpload(UploadFromFile, User, array, string, string, NULL)
#3 /srv/mediawiki/php-1.32.0-wmf.24/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#4 /srv/mediawiki/php-1.32.0-wmf.24/includes/upload/UploadBase.php(852): Hooks::run(string, array)
#5 /srv/mediawiki/php-1.32.0-wmf.24/includes/api/ApiUpload.php(828): UploadBase->performUpload(string, string, boolean, User, NULL)
#6 /srv/mediawiki/php-1.32.0-wmf.24/includes/api/ApiUpload.php(146): ApiUpload->performUpload(array)
#7 /srv/mediawiki/php-1.32.0-wmf.24/includes/api/ApiUpload.php(104): ApiUpload->getContextResult()
#8 /srv/mediawiki/php-1.32.0-wmf.24/includes/api/ApiMain.php(1587): ApiUpload->execute()



Impact

Some users who are using Special:Upload or ApiUpload receive a "Wikimedia Error - Technical problems" error page with no further information about what went wrong.TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, dmaza, Daimona, Litanwei, Wong128hk, Luke081515, Nirmos, Huji, Jdforrester-WMF, Jackmcbarn, Jay8g, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs