[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Jdlrobson added a comment. Mobile doesn't support gadgets so this will need to be moved into the wikidata extension itself to work. What is an identifier? TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Jdlrobson added a comment. I see. So it takes a value and enhances it e.g. turns it into a link e.g. takes the IMDB identifier and makes it a link Any reason this is not done on the backend? TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Lydia_Pintscher added a comment. Hmm @maxsem said that was possible? An identifier is for example tt0133093 which is then linked to http://www.imdb.com/title/tt0133093 by this gadget on https://www.wikidata.org/wiki/Q83495. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Lydia_Pintscher added a comment. Exactly. We don't have it in Wikibase itself so far for two reasons: - Wikibase should not have any knowledge about special properties. Here it would have to know that some properties turn their value into links. We'd like to avoid this as much as possible. - We didn't have a proper way to store the URL used for expanding the identifier. We have that now with statements on properties. So we will need to figure out a way to do that in Wikibase as well but I am not sure how yet. Until then it'd be good to get this working with the gadget. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Florian added a comment. It should be possible to migrate this Gadget into a module and add the dependencies: AuthorityControl[ResourceLoader|default|**dependencies=wikibase.api.RepoApi**]|AuthorityControl.js Another way would be to add a wrapper JS module for it (to make sure, that the dependencies are loaded) and load the Gadget with mw.loader.load( 'gadget-url' ); But it should be configurable to be a specific module for wikidata. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Jdlrobson added a comment. Mobile has no plans to support global site gadgets right now. They make it really difficult to debug issues and lack a code review process which is pretty important when it comes to exposing JS code to mobile users. I think if we can find a way to do this on the backend in a generic way this would be the best solution for the long term lifespan of this project. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Jdlrobson added a comment. Yep but no easy way of setting that target. I guess what I'm saying is I discourage the use of a global gadget on mobile. User scripts are fine but I think we have to be more responsible when considering the quirks, performance issues and capabilities of mobile phones. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Legoktm, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Lydia_Pintscher added a comment. I think we all agree that ultimately it should be in Wikibase itself somehow. Question is: Can we do anything until that happens? TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Legoktm, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
MaxSem added a comment. wikibase.api.RepoApi looks like it's safe to slap a mobile target on it and load it on demand - after it's mibilified, the above change should just work. However, for me this gadget doesn't work in Chrome even on desktop. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: MaxSem Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Legoktm, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85365: identifiers are not linked on mobile
Jdlrobson added a comment. We don't know if it is safe. I would want to review this firstand would still prefer us to find a non gadget based solution. TASK DETAIL https://phabricator.wikimedia.org/T85365 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Jdlrobson, MaxSem, Snaterlicious, adrianlang, thiemowmde, Lydia_Pintscher, Florian, Legoktm, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
