[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2016-02-08 Thread gerritbot
gerritbot added a comment.

Change 254645 merged by jenkins-bot:
Use custom generator for mobile search on Wikidata

https://gerrit.wikimedia.org/r/254645


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene, gerritbot
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, debt, Gehel, Izno, Wikidata-bugs, Deskana, 
Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2016-01-27 Thread Bene
Bene added a comment.

Patches that need to be merged:

- https://gerrit.wikimedia.org/r/#/c/251207/ (MobileFrontend)
- https://gerrit.wikimedia.org/r/#/c/254645/ (Config)

When done, this can be closed as resolved.


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, debt, Wikidata-bugs, Deskana, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-12-03 Thread daniel
daniel added a comment.

@aude thanks, with the two extra settings, it works as expected.

Still blocked on minor escaping and naming issues in 
https://gerrit.wikimedia.org/r/#/c/251207/


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene, daniel
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, dpatrick, Wikidata-bugs, Bawolff, Deskana, 
Jalexander, Parent5446, Anomie, Grunny, MaxSem, csteipp, Mbch331, Krenair, 
Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-12-02 Thread aude
aude added a comment.

In https://phabricator.wikimedia.org/T85368#1833737, @daniel wrote:

> Tested this locally, with the following settings:
>
>   $wgMFNearby = true;
>   $wgMFQueryPropModules[] = 'pageterms';
>   $wgMFSearchAPIParams['wbptterms'] = array( 'label' );
>   $wgMFSearchGenerator = array(
>   'name' => 'wbsearch',
>   'prefix' => 'wbs'
>   );
>
>
> I tested with latest master of core, Wikibase, and MobileFrontend.
>
> I found the following:
>
> - In the search box, I get matches for labels, but labels are not used for 
> display. I just see IDs, no labels or descriptions.
> - On Special:Nearby, labels are used for display, but no descriptions are 
> shown.


Do you have the following settings?

  $wgMFUseWikibaseDescription = true;   
  
  $wgMFDisplayWikibaseDescription = true;

descriptions are a separate, general feature that works on any client wiki, 
including wikidata.

alternatively:

  $wgMFSearchAPIParams['wbptterms'] = array( 'label', 'description' );

might work.

> - Also, I found https://phabricator.wikimedia.org/T119707


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene, aude
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, dpatrick, Wikidata-bugs, Bawolff, Deskana, 
Jalexander, Parent5446, Anomie, Grunny, MaxSem, csteipp, Mbch331, Krenair, 
Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-11-30 Thread daniel
daniel added a comment.

So, this is blocked on https://gerrit.wikimedia.org/r/#/c/251207/ as far as I 
can tell.


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene, daniel
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, dpatrick, Wikidata-bugs, Bawolff, Deskana, 
Jalexander, Parent5446, Anomie, Grunny, MaxSem, csteipp, Mbch331, Krenair, 
Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-11-26 Thread Bene
Bene added a comment.

> - In the search box, I get matches for labels, but labels are not used for 
> display. I just see IDs, no labels or descriptions.

Matched terms will be shown as soon as 
https://gerrit.wikimedia.org/r/#/c/251207/ is merged.

> - On Special:Nearby, labels are used for display, but no descriptions are 
> shown.

I don't know how Special:Nearby works but that is unrelated to this task.

> - Also, I found T119707

Perhaps my MobileFrontend ticket suffers from the same issues... :S


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene
Cc: Tobi_WMDE_SW, JanZerebecki, Bene, Liuxinyu970226, gerritbot, Florian, 
thiemowmde, adrianheine, aude, Snaterlicious, Aklapper, Lydia_Pintscher, 
Jdlrobson, daniel, Manybubbles, dpatrick, Wikidata-bugs, Bawolff, Deskana, 
Jalexander, Parent5446, Anomie, Grunny, MaxSem, csteipp, Mbch331, Krenair, 
Legoktm



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-11-25 Thread Bene
Bene added a comment.

The only thing for this to be done is getting the config patch merged: 
https://gerrit.wikimedia.org/r/#/c/254645/ Maybe someone can have a look into 
that?


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bene
Cc: Bene, Liuxinyu970226, gerritbot, Florian, thiemowmde, adrianheine, aude, 
Snaterlicious, Aklapper, Lydia_Pintscher, Jdlrobson, daniel, Manybubbles, 
Wikidata-bugs, Deskana, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-11-21 Thread gerritbot
gerritbot added a comment.

Change 238983 abandoned by Bene:
Configure MobileFrontend to use wbsearch as generator

Reason:
Done in config: https://gerrit.wikimedia.org/r/#/c/254645/1

https://gerrit.wikimedia.org/r/238983


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Bene, Liuxinyu970226, gerritbot, Florian, thiemowmde, adrianheine, aude, 
Snaterlicious, Aklapper, Lydia_Pintscher, Jdlrobson, daniel, Manybubbles, 
Wikidata-bugs, Deskana, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T85368: [Story] Search for Wikidata should give meaningful results on mobile as well

2015-11-21 Thread gerritbot
gerritbot added a comment.

Change 254645 had a related patch set uploaded (by Bene):
Use custom generator for mobile search on Wikibase

https://gerrit.wikimedia.org/r/254645


TASK DETAIL
  https://phabricator.wikimedia.org/T85368

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Bene, Liuxinyu970226, gerritbot, Florian, thiemowmde, adrianheine, aude, 
Snaterlicious, Aklapper, Lydia_Pintscher, Jdlrobson, daniel, Manybubbles, 
Wikidata-bugs, Deskana, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs