[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I’ve uploaded a WIP patch  moving 
`extension-view-wip.json` to the `view/` subdirectory, if you want to try it 
out.

TASK DETAIL
  https://phabricator.wikimedia.org/T88434

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, 
JanZerebecki, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, 
Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > There's some precedent with respect to how ConfirmEdit has "sub-extensions" 
in the same repo.
  
  Thanks, that’s good to know. In Wikibase, I noticed two problems (so far) in 
Special:Version when putting the `extension.json` in a subdirectory: the “and 
more” entry in the authors list is no longer a hyperlink because the `CREDITS` 
file doesn’t reside next to the `extension.json`, and there’s no Git 
information because the `extension.json` is not in the Git repository root.
  
  It looks like ConfirmEdit doesn’t have any solutions for these problems (the 
FancyCaptcha entry on meta:Special:Version 

 exhibits them as well) – but they’re less serious there, because ConfirmEdit 
still has the root extension with correct Git information and author credits. 
In Wikibase we don’t have that, at least not with the current plan, as far as 
I’m aware (there’d be no general Wikibase extension in the root directory of 
the Git repository).
  
  Both of the problems can be solved as far as MediaWiki is concerned by 
symlinking `CREDITS` and `.git` into the subdirectory, but obviously for `.git` 
that’s not a workable solution, since Git will then think the subdirectory is a 
Git repository root. (For `CREDITS`, it works well enough, though I suppose we 
could also have separate per-subdirectory `CREDITS` files if we wanted to.) 
Perhaps some new settings for `extension.json` can be added, telling the 
extension registry where to look for the Git repository root and possibly other 
information? It could either be one general setting “look in `../` for anything 
not found in `./`” (where the `../` would be the setting’s value) or one 
setting for the Git repository root, one for the `CREDITS` file, and others for 
whatever other problems turn up (I probably haven’t found all of them yet).

TASK DETAIL
  https://phabricator.wikimedia.org/T88434

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, 
JanZerebecki, Aklapper, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, 
Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Legoktm]

Legoktm added a comment.


  In T88434#5196007 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I just came back across this point while looking into T223214: Start 
converting Wikibase extensions to use extension registration 
, because the location of the 
`extension.json` file(s) for Wikibase is influenced by this as well. If we keep 
the current `repo/includes/` etc. pattern, then there’s a clear place for the 
JSON files: `repo/extension.json`. On the other hand, with `includes/repo/`, 
the most natural (to me) placement of the JSON files would place them all in 
the repository root, where they would collide with each other. I guess that 
could be resolved by departing from the standard `extension.json` name and 
having `extension-repo.json` etc., but I’m not sure how ugly that is compared 
to other approaches…
  
  
  There's some precedent with respect to how ConfirmEdit has "sub-extensions" 
in the same repo.

TASK DETAIL
  https://phabricator.wikimedia.org/T88434

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Legoktm
Cc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, 
JanZerebecki, Aklapper, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, 
Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Hm, I guess that would also work.TASK DETAILhttps://phabricator.wikimedia.org/T88434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, JanZerebecki, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Legoktm]

Legoktm added a comment.
That's one possible option, yes. Or you can adopt the standard layout in one repo, but slightly reversed: includes/lib/, includes/repo/, tests/phpunit/client/. That's more up to the maintainers of Wikibase to figure out, but CI (and a growing number of tools) do assume the standard layout.TASK DETAILhttps://phabricator.wikimedia.org/T88434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, JanZerebecki, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T88434: generate Wikibase.git code coverage on Jenkins

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Well, the three extensions included in Wikibase.git (WikibaseLib, WikibaseRepo, WikibaseClient) already follow that layout (lib/includes/, repo/includes/, client/tests/phpunit/, etc.)… are you saying we need to split them into three Git repositories?TASK DETAILhttps://phabricator.wikimedia.org/T88434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, JanZerebecki, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs