[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
gerritbot added a comment. Change 225036 merged by jenkins-bot: Drop some unused code from ResultBuilder and related https://gerrit.wikimedia.org/r/225036 TASK DETAIL https://phabricator.wikimedia.org/T92970 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, gerritbot Cc: gerritbot, Addshore, Tobi_WMDE_SW, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, jayvdb, Legoktm, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
gerritbot added a comment. Change 223794 merged by jenkins-bot: Move ApiResult::getIsRawMode call to ApiHelperFactory https://gerrit.wikimedia.org/r/223794 TASK DETAIL https://phabricator.wikimedia.org/T92970 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
gerritbot added a comment. Change 225036 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Drop some unused code from ResultBuilder and related https://gerrit.wikimedia.org/r/225036 TASK DETAIL https://phabricator.wikimedia.org/T92970 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 223794 had a related patch set uploaded (by Addshore): Move ApiResult::getIsRawMode call to ApiHelperFactory https://gerrit.wikimedia.org/r/223794 TASK DETAIL https://phabricator.wikimedia.org/T92970 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Addshore, Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
Addshore added a subscriber: Addshore. Addshore added a comment. For everyone's info I have just started looking at all of this TASK DETAIL https://phabricator.wikimedia.org/T92970 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Addshore, Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
aude added a comment. @anomie thanks for noticing that. I suggest we make a new task for those. TASK DETAIL https://phabricator.wikimedia.org/T92970 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude Cc: Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
Anomie added a comment. Despite https://phabricator.wikimedia.org/T93353 being closed, I still see calls to getIsRawMode() in ResultBuilder and GetEntities, and to setRawMode() in some tests. TASK DETAIL https://phabricator.wikimedia.org/T92970 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Tobi_WMDE_SW, ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
Lydia_Pintscher added a comment. I'll put it on the list for the sprint start meeting on Tuesday. TASK DETAIL https://phabricator.wikimedia.org/T92970 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
ksmith added a subscriber: ksmith. ksmith added a comment. This issue is blocking 7 commits in mediawiki core (the blocker noted here is blocking others), so it would help us if it could make it into the next sprint. TASK DETAIL https://phabricator.wikimedia.org/T92970 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ksmith Cc: ksmith, Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92970: Replace ApiResult::setRawMode use in EntityDataSerializationService
Anomie added a comment. You've also got calls to getIsRawMode() in ResultBuilder and GetEntities, and some calls to setRawMode() in some unit tests. TASK DETAIL https://phabricator.wikimedia.org/T92970 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Lydia_Pintscher, Anomie, daniel, JanZerebecki, aude, Aklapper, Wikidata-bugs, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs