[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Jdlrobson added a comment. > 1. Add the banner via CSS, not as an tag. This way we can easily > configure the size of the image by creating responsive css rules with > `@media` queries. We can also easily create a different stylesheet for the > MobileFrontend extension. It's actually better to use an img and use the srcset attribute. This is how we should configure the size of the image. I've suggested @sumit switches back to using an img tag TASK DETAIL https://phabricator.wikimedia.org/T93106 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Moushira, Bene, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Sumit added a comment. @Jdlrobson, descoped the "editing of banner image source using UI" part of the proposal as per your suggestion. TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Nemo_bis, Bene, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Jdlrobson added a comment.
@Sumit my opinion on Phase V: I think you should de-scope this from your GSoc
proposal. {{PAGEBANNER}} should be completely optional and simply used for
overriding the value from Wikidata. For this reason I think an editor might not
make sense here as a first version. Clicking an "Edit on Wikidata" link might
suffice. It would be far better to have a generic image selector on Wikidata
itself or fallback to VE. I really think the phases before it are ample work
for a GSoc project already :-)
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sumit, Jdlrobson
Cc: Nemo_bis, Bene, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian,
Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari,
Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs,
aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Nemo_bis added a comment. I'm still not seeing which Wikivoyage edition(s) volunteered to test/adopt this extension. TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Nemo_bis Cc: Bene, Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Bene added a comment.
I'm not sure if we need an edit widget for changes to the wikitext variable,
maybe something that hooks into VisualEditor would be nice like it is done for
`{{DISPLAYTITLE}}` already.
Changing the value on Wikidata requries more investigation because it will
affect all wikis which have an article about that topic and are linked to
Wikidata. I'm not sure how to find a nice solution here. I think you should
focus on a VisualEditor integration and leave the Wikidata remote editing as a
todo for later if there is still time left.
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sumit, Bene
Cc: Bene, Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian,
Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari,
Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs,
aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Sumit added a comment. @Bene, thanks for your suggestions. Just a small view regarding: > Concerning the edit box, as it should also be possible to edit Wikidata in > this box, please work closely with the Wikidata team for that feature. The current pagebanner template uses a different url in wikitext(as a parameter) to specify an alternative pagebanner, different from wikidata value. As per my plan, the edit feature targets to replace this url in the **wikitext**(using a UI), to make only local changes, keeping the wikidata value intact. If this scheme does not look right, I'll change it to editing the wikidata value. Views? TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Bene, Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Jdlrobson added a comment. +1 to everything @bene says :) TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Bene, Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Bene added a comment.
Hey, I have a few suggestions to your proposal:
1. Use an article keyword like `{{DISPLAYTITLE:Abc}}` instead of a parser
function, as it affects the article's header and will not be replaced by some
html but rather modify another part of the page. I'd suggest
`{{ARTICLEBANNER}}` or `{{PAGEBANNER}}`.
2. Don't use lua please but fetch the image automatically in the Extension so
we won't need any template placed on the pages. The property to use can be
specified in the config and you can get the statement for this property by
using the Wikibase Extension in your PHP code.
3. Don't add all those symbols by wikitext, but use Wikidata's badges instead
which can also be fetched automatically in your PHP code. Some of them don't
exist on Wikidata yet so they should be created and added to the configuration.
This requires a task on the Wikidata board.
4. Add the banner via CSS, not as an tag. This way we can easily
configure the size of the image by creating responsive css rules with `@media`
queries. We can also easily create a different stylesheet for the
MobileFrontend extension.
5. Concerning the edit box, as it should also be possible to edit Wikidata in
this box, please work closely with the Wikidata team for that feature.
TASK DETAIL
https://phabricator.wikimedia.org/T93106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Sumit, Bene
Cc: Bene, Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian,
Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari,
Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs,
aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Jdlrobson added a comment. @Wrh2 thanks for sharing the links and @Nemo_bis thanks for the poke, super keen to set @sumit up for success! TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Wrh2 added a comment. In https://phabricator.wikimedia.org/T93106#1173339, @Nemo_bis wrote: > Wikivoyage in what language? What language editions have been contacted about > this proposal? I'm not sure of all notifications that have been done, but I've seen feedback solicited in the English Wikivoyage pub (https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Pagebanner_extension_for_wikivoyage), and I posted a link to the phabricator discussion on the Wikivoyage page on meta so that other languages would be notified (https://meta.wikimedia.org/wiki/Wikivoyage/Lounge#Pagebanner_extension). TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Wrh2 Cc: Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Nemo_bis added a subscriber: Nemo_bis. Nemo_bis added a comment. > Wikivoyage uses the concept of pagebanners and horizontal table of contents > on each of its page Wikivoyage in what language? What language editions have been contacted about this proposal? Please edit this task's description to fix the typos in your proposal. TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Nemo_bis Cc: Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Sumit added a comment. I've setup the boilerplate extension on my userspace at github, now filling in a request at https://www.mediawiki.org/wiki/Gerrit/New_repositories for migrating this to gerrit for further development https://github.com/codez266/WikiDataPageBannerExtension TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Jdlrobson added a comment. If anyone takes on the microtask associated with that and completes it I have plenty more to add and it would certainly make someone a stronger candidate in my eyes. TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Qgil added a comment. @Sumit, thank you for this project proposal. Have you got a chance to complete one or more microtasks? I am not the right person to evaluate your proposal, but I can tell that you have clearly put a good amount of work here, and complementing this with completed microtasks would make you a stronger candidate. TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign . EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Qgil Cc: Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
