[Wikidata-bugs] [Maniphest] [Commented On] T95168: Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-08-05 Thread gerritbot 
gerritbot added a comment.

Change 227667 merged by jenkins-bot:
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667


TASK DETAIL
  https://phabricator.wikimedia.org/T95168

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: gerritbot, Addshore, Anomie, aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T95168: Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-08-05 Thread daniel 
daniel added a subscriber: daniel.
daniel added a comment.

Seems like ResultBuilder.php is still using getIsRawMode quite a bit. 
ApiHelperFactoryTest.php mocks that method (needlessly?). ApiXmlFormatTest.php 
uses setRawMode().


TASK DETAIL
  https://phabricator.wikimedia.org/T95168

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, daniel
Cc: daniel, gerritbot, Addshore, Anomie, aude, Aklapper, Wikidata-bugs, 
Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T95168: Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-07-29 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 227667 had a related patch set uploaded (by Addshore):
APIPOKE - Return for-language key for non raw fallbacks

https://gerrit.wikimedia.org/r/227667


TASK DETAIL
  https://phabricator.wikimedia.org/T95168

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: gerritbot, Addshore, Anomie, aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T95168: Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-07-29 Thread Addshore 
Addshore added a comment.

All of the re factoring to make this easier is now done.
Now just to make a few API breaks and pokes in order to be able to totally 
remove our usage of getIsRawMode etc.


TASK DETAIL
  https://phabricator.wikimedia.org/T95168

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Anomie, aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T95168: Remove calls to getIsRawMode() in Wikibase, and calls to setRawMode() in tests

2015-07-15 Thread Addshore 
Addshore added a subscriber: Addshore.
Addshore added a comment.

I am looking at this now, bit of re factoring to do first though


TASK DETAIL
  https://phabricator.wikimedia.org/T95168

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Anomie, aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs