[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
gerritbot added a comment. Change 206386 abandoned by Hoo man: Make label/description uniqueness checks case insensitive for properties Reason: Seems like the current behavior is fine. https://gerrit.wikimedia.org/r/206386 TASK DETAIL https://phabricator.wikimedia.org/T97129 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, gerritbot Cc: Bene, Tobi_WMDE_SW, daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW. Tobi_WMDE_SW added a comment. Removed this from the sprint as it is currently not worked on. See comment by @Lydia_Pintscher. TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: Tobi_WMDE_SW, daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
Lydia_Pintscher added a comment. Just discussed this more with Daniel. I'll discuss this more on-wiki. Let's hold off for now. TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
gerritbot added a comment. Change 206820 abandoned by Thiemo Mättig (WMDE): Revert Ignore capitalization for label and description conflicts. Reason: Per https://phabricator.wikimedia.org/T97129#1241103 https://gerrit.wikimedia.org/r/206820 TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
daniel added a comment. For reference, the relevant report on Wikidata is https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Problem_on_Upper.2Flower_case pointing to https://www.wikidata.org/wiki/Q563116 (SOO) vs. https://www.wikidata.org/wiki/Q1230747 (Soo). Both of these have the description Wikipedia disambiguation page. I think the issue here is mainly that we have some types of pseudo-items for disambiguation pages, categories, etc, that all have the same description. That's contrary to the original intent to use different descriptions to differentiate between items with the same or similar names. Case insensitive uniqueness checks avoid duplicates caused by different capitalization (War and Peace vs War And Peace vs War and peace). It also forces more meaningful descriptions that help users to choose the correct item from the type-ahead suggestions in the entity selector (instead of FOO (company) and Foo (company) users would perhaps see FOO (American company) and Foo (Chinese electronics company). I hope a different solution can be found for disambiguation pages and categories. Ideally, those would not be shown at all when editing statements (since they should generally not be used in statement values, I think). TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
daniel added a subscriber: daniel. daniel added a comment. Items only conflict if label *and* description are the same. In which cases does this cause problems? Are there items that have labels that are only different in case, and also have the same description? Would it not be more sensible to give them different descriptions? TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
daniel added a comment. In https://phabricator.wikimedia.org/T97129#1238460, @thiemowmde wrote: Please let's revert https://gerrit.wikimedia.org/r/#/c/203531/ first if it's a problem in production. The proposed patch is way to big to get it reviewed and merged in a few hours. Let's not revert, we should really have case-insensitive uniqueness checks for properties. TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
gerritbot added a comment. Change 206820 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Revert Ignore capitalization for label and description conflicts. https://gerrit.wikimedia.org/r/206820 TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
thiemowmde added a subscriber: thiemowmde. thiemowmde added a comment. Please let's revert https://gerrit.wikimedia.org/r/#/c/203531/ first if it's a problem in production. The proposed patch is way to big to get it reviewed and merged in a few hours. TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97129: don't take case into consideration for item labels
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 206386 had a related patch set uploaded (by Hoo man): Make label/description uniqueness checks case insensitive for properties https://gerrit.wikimedia.org/r/206386 TASK DETAIL https://phabricator.wikimedia.org/T97129 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, hoo, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
