[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Jdlrobson added a comment. @Sumit is this task complete? TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Andyrom75 added a comment. Don't know if it helpful, but according to the image optimization paragraph inside the mobile section of this link https://developers.google.com/speed/pagespeed/insights/?url=http%3A%2F%2Fpagebanner.wmflabs.org%2Fwiki%2FRoppongitab=mobile it says that it could be saved 99% of the information transfered between server and client. I suppose that the reason can be found on the fact that it download this file https://upload.wikimedia.org/wikipedia/commons/6/6c/Ladakh_banner.jpg instead of a pre-resized version of it, for the small screen of a mobile. There's something that can be done? TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Andyrom75 Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Andyrom75 added a comment. Don't know if it helpful, but according to the image optimization paragraph inside the mobile section of this link https://developers.google.com/speed/pagespeed/insights/?url=http%3A%2F%2Fpagebanner.wmflabs.org%2Fwiki%2FRoppongitab=mobile it says that it could be saved 99% of the information transfered between server and client. I suppose that the reason can be found on the fact that it download this file https://upload.wikimedia.org/wikipedia/commons/6/6c/Ladakh_banner.jpg instead of a pre-resized version of it, for the small screen of a mobile. There's something that can be done? TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Andyrom75 Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Andyrom75 added a comment. A minor thing. In http://pagebanner.wmflabs.org/wiki/Culver_City caption parameter doesn't work. TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Andyrom75 Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Jdlrobson added a comment. Not closing until we've got the flash of styles fixed! TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
gerritbot added a comment. Change 218672 merged by jenkins-bot: WikidataPageBanner toc added https://gerrit.wikimedia.org/r/218672 TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, gerritbot Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Andyrom75 added a comment. Good to know :-) TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Andyrom75 Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Andyrom75 added a comment. Nicolas consider that other language versions (and/or other article types) may have more root sections and with longer names so they could fill at least two rows. Maybe it's not a problem, but it must be taken into account. TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Andyrom75 Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Jdlrobson added a comment. @Andyrom75 when @sumit works on making the table of contents mobile friendly we should find a suitable way of dealing with this. Should definitely be taken into account. TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Jdlrobson added a comment. Actually it looks like it has already been taken into account: :) F183284: Screen Shot 2015-06-24 at 12.02.34 PM.png https://phabricator.wikimedia.org/F183284 TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Sumit added a comment. Here is a preview of the TOC by current version of the above patch on a page about Asia http://pagebanner.wmflabs.org/wiki/Asia TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Nicolas_Raoul added a comment. Very nice! I like the fact that links are copyable via right-click (needed when sharing deep links). The TOC does not appear in preview. While not useful during preview, it is good to have the same appearance during preview if possible. Wikivoyage articles have only few root sections, with short names, so overflowing is not a problem for now (unless on mobile I guess). Example: http://pagebanner.wmflabs.org/wiki/Roppongi TASK DETAIL https://phabricator.wikimedia.org/T97839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Nicolas_Raoul Cc: gerritbot, Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97839: drop-down TOC for wikivoyage banners
Jdlrobson added a comment. Note: $parserOutput-setTOCEnabled( false ); can be used to disable the initial table of contents. As a starting point I would look to enable a one level table of contents. If you can do this great but I don't think this is vital for the success of this project and can be added later on. TASK DETAIL https://phabricator.wikimedia.org/T97839 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Jdlrobson Cc: Andyrom75, Danapit, Glaisher, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Wrh2, Bene, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
