[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
gerritbot added a comment. Change 209871 merged by jenkins-bot: Don't output an empty h1 element https://gerrit.wikimedia.org/r/209871 TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
gerritbot added a comment. Change 209870 merged by jenkins-bot: Don't output an empty h1 element https://gerrit.wikimedia.org/r/209870 TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian, gerritbot Cc: gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
Florian added a comment. Doing it for Vector and MonoBook, Minerva already checks, if a title is set before creating the h1 element. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian Cc: gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
gerritbot added a comment. Change 209871 had a related patch set uploaded (by Florianschmidtwelzow): Don't output an empty h1 element https://gerrit.wikimedia.org/r/209871 TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 209870 had a related patch set uploaded (by Florianschmidtwelzow): Don't output an empty h1 element https://gerrit.wikimedia.org/r/209870 TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
Jdlrobson added a comment. Doing this for Vector and mobile skin seems like a good start. TASK DETAIL https://phabricator.wikimedia.org/T97891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude, Jdforrester-WMF ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
Florian added a comment. In https://phabricator.wikimedia.org/T97891#1258140, @Jdlrobson wrote: Do we have an appropriate project for skin architecture @matmarex? https://phabricator.wikimedia.org/tag/mediawiki-interface/ ? :) TASK DETAIL https://phabricator.wikimedia.org/T97891 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian Cc: KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
KLans_WMF added a subscriber: KLans_WMF. KLans_WMF added a comment. @jdlrobson can you give us a sense of the urgency of this from your POV? Trying to figure out how to prioritize this. TASK DETAIL https://phabricator.wikimedia.org/T97891 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: KLans_WMF Cc: KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
Jdlrobson added a comment. It can be hacked around so not urgent but I keep hitting this bug in all the projects I have worked on. It's something that should be done in core as there is clearly a need. Do we have an appropriate project for skin architecture @matmarex? TASK DETAIL https://phabricator.wikimedia.org/T97891 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: KLans_WMF, adrianheine, thiemowmde, matmarex, Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T97891: setHTMLTitle to empty string or false should prevent rendering of H1 on page
Florian added a subscriber: Florian. Florian added a comment. I think you mean OutputPage::setPageTitle()? OutputPage::setHTMLTitle() only set's the title-tag in head. The problem is, that the h1 element isn't created by mediawiki core. Each skin uses the title (which can be set by OutputPage) to create the h1 tag alone, see e.g. Vector https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/VectorTemplate.php#L110-L114. So, for compatible reasons,it's abit more complicated to find a standard way (but would be possible and we could start implementing a way for wmf-deployed skins). TASK DETAIL https://phabricator.wikimedia.org/T97891 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian Cc: Florian, Aklapper, Jdlrobson, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
