[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues

2015-07-03 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 222693 had a related patch set uploaded (by Sumit):
WikidataPageBanner fixes for skin Minerva

https://gerrit.wikimedia.org/r/222693


TASK DETAIL
  https://phabricator.wikimedia.org/T98034

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, 
Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues

2015-07-03 Thread Florian 
Florian added a comment.

@Jdlrobson Sorry, that i haven't answered, i'm still in vacation :)

You can hide the title with:
$out-setPageTitle( '' );

That disables the html title tag, too, so after that, set it to the correct one:
$out-setHTMLTitle( $out-getTitle() );


TASK DETAIL
  https://phabricator.wikimedia.org/T98034

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Florian
Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, 
Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues

2015-07-03 Thread Jdlrobson 
Jdlrobson added a comment.

Apologies I didn't reply to your message. The banners in mobile are currently 
only present in the beta of the site accessible via Special:MobileOptions

$out-setPageTitle( false) ; should remove the title from the page - you 
shouldn't need to use css


TASK DETAIL
  https://phabricator.wikimedia.org/T98034

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, 
Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues

2015-06-24 Thread Sumit 
Sumit added a subscriber: Sumit.
Sumit added a comment.

Immediately visible issues of Mobile skin with WikidataPageBanner issues:

- Mobile frontend has a banner module which adds a style for banner with class 
name **.banner-image**, which is same as this extension. Changing classname in 
this extension would help remove unintentional styles.
- WikidataPageBanner extension hides the primary page heading in non-mobile 
skin and adds its own heading to the browser. It needs to do the same for 
Mobile Frontend. However care must be taken to keep the edit buttons at the top 
in shape.
- The heading of banner needs to shrink and the toc should move out of banner 
once the screen-width is below a threshold.

I think having a different style targeting mobile skin would help keep the 
issues separate.


TASK DETAIL
  https://phabricator.wikimedia.org/T98034

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sumit
Cc: Sumit, phuedx, kaldari, Aklapper, Jdlrobson, Wikidata-bugs, aude, 
Lydia_Pintscher



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs